From: David Miller <davem@davemloft.net>
To: cai@gmx.us
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, joe@perches.com,
stephen@networkplumber.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net/core: tidy up an error message
Date: Mon, 03 Dec 2018 16:15:14 -0800 (PST) [thread overview]
Message-ID: <20181203.161514.1229179839092578403.davem@davemloft.net> (raw)
In-Reply-To: <20181202021119.7737-1-cai@gmx.us>
From: Qian Cai <cai@gmx.us>
Date: Sat, 1 Dec 2018 21:11:19 -0500
> netif_napi_add() could report an error like this below due to it allows
> to pass a format string for wildcarding before calling
> dev_get_valid_name(),
>
> "netif_napi_add() called with weight 256 on device eth%d"
>
> For example, hns_enet_drv module does this.
>
> hns_nic_try_get_ae
> hns_nic_init_ring_data
> netif_napi_add
> register_netdev
> dev_get_valid_name
>
> Hence, make it a bit more human-readable by using netdev_err_once()
> instead.
>
> Signed-off-by: Qian Cai <cai@gmx.us>
Applied, thanks.
prev parent reply other threads:[~2018-12-04 0:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-02 2:11 [PATCH v2] net/core: tidy up an error message Qian Cai
2018-12-04 0:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203.161514.1229179839092578403.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cai@gmx.us \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=stephen@networkplumber.org \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).