* [PATCH] net: marvell: convert to DEFINE_SHOW_ATTRIBUTE
@ 2018-12-03 14:34 Yangtao Li
2018-12-04 1:30 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Yangtao Li @ 2018-12-03 14:34 UTC (permalink / raw)
To: mlindner, stephen, davem; +Cc: netdev, linux-kernel, Yangtao Li
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/net/ethernet/marvell/skge.c | 14 +-------------
drivers/net/ethernet/marvell/sky2.c | 14 +-------------
2 files changed, 2 insertions(+), 26 deletions(-)
diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c
index 9c08c3650c02..04fd1f135011 100644
--- a/drivers/net/ethernet/marvell/skge.c
+++ b/drivers/net/ethernet/marvell/skge.c
@@ -3732,19 +3732,7 @@ static int skge_debug_show(struct seq_file *seq, void *v)
return 0;
}
-
-static int skge_debug_open(struct inode *inode, struct file *file)
-{
- return single_open(file, skge_debug_show, inode->i_private);
-}
-
-static const struct file_operations skge_debug_fops = {
- .owner = THIS_MODULE,
- .open = skge_debug_open,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(skge_debug);
/*
* Use network device events to create/remove/rename
diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
index 697d9b374f5e..f4aa01ab3580 100644
--- a/drivers/net/ethernet/marvell/sky2.c
+++ b/drivers/net/ethernet/marvell/sky2.c
@@ -4623,19 +4623,7 @@ static int sky2_debug_show(struct seq_file *seq, void *v)
napi_enable(&hw->napi);
return 0;
}
-
-static int sky2_debug_open(struct inode *inode, struct file *file)
-{
- return single_open(file, sky2_debug_show, inode->i_private);
-}
-
-static const struct file_operations sky2_debug_fops = {
- .owner = THIS_MODULE,
- .open = sky2_debug_open,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(sky2_debug);
/*
* Use network device events to create/remove/rename
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: marvell: convert to DEFINE_SHOW_ATTRIBUTE
2018-12-03 14:34 [PATCH] net: marvell: convert to DEFINE_SHOW_ATTRIBUTE Yangtao Li
@ 2018-12-04 1:30 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-12-04 1:30 UTC (permalink / raw)
To: tiny.windzz; +Cc: mlindner, stephen, netdev, linux-kernel
From: Yangtao Li <tiny.windzz@gmail.com>
Date: Mon, 3 Dec 2018 09:34:11 -0500
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-04 1:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-03 14:34 [PATCH] net: marvell: convert to DEFINE_SHOW_ATTRIBUTE Yangtao Li
2018-12-04 1:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).