From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Joey Pabalinas <joeypabalinas@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH v4 7/7] zram: writeback throttle
Date: Mon, 3 Dec 2018 15:11:48 +0900 [thread overview]
Message-ID: <20181203061148.GF427@jagdpanzerIV> (raw)
In-Reply-To: <20181203060208.GE427@jagdpanzerIV>
On (12/03/18 15:02), Sergey Senozhatsky wrote:
> Seems like I misread writeback_limit_store() a bit.
>
> So, if I want to, say, let only 10M of writteback pages, I need to
> do
>
> echo 0 > writeback_limit
> echo 10M > writeback_limit_store // memparse format is for
> // simplicity only; I know
> // it should be in 4K units.
>
> every day. How about dropping the "echo 0" and ->stop_writeback?
Ah, this breaks the unlimited writeback.
So, nevermind my comment.
-ss
next prev parent reply other threads:[~2018-12-03 6:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 2:40 [PATCH v4 0/7] zram idle page writeback Minchan Kim
2018-12-03 2:40 ` [PATCH v4 1/7] zram: fix lockdep warning of free block handling Minchan Kim
2018-12-03 2:40 ` [PATCH v4 2/7] zram: fix double free backing device Minchan Kim
2018-12-03 2:40 ` [PATCH v4 3/7] zram: refactoring flags and writeback stuff Minchan Kim
2018-12-03 2:40 ` [PATCH v4 4/7] zram: introduce ZRAM_IDLE flag Minchan Kim
2018-12-03 2:40 ` [PATCH v4 5/7] zram: support idle/huge page writeback Minchan Kim
2018-12-03 2:40 ` [PATCH v4 6/7] zram: add bd_stat statistics Minchan Kim
2018-12-03 2:40 ` [PATCH v4 7/7] zram: writeback throttle Minchan Kim
2018-12-03 5:50 ` Sergey Senozhatsky
2018-12-03 6:02 ` Sergey Senozhatsky
2018-12-03 6:11 ` Sergey Senozhatsky [this message]
2018-12-04 2:08 ` [PATCH v4 0/7] zram idle page writeback Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203061148.GF427@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=joeypabalinas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).