From: Ingo Molnar <mingo@kernel.org>
To: Wen Yang <wen.yang99@zte.com.cn>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
paulmck@linux.ibm.com, Josh Triplett <josh@joshtriplett.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn
Subject: Re: [PATCH v2] locktorture: Fix assignment of boolean variables
Date: Mon, 3 Dec 2018 09:00:39 +0100 [thread overview]
Message-ID: <20181203080039.GA25965@gmail.com> (raw)
In-Reply-To: <20181203022318.58083-1-wen.yang99@zte.com.cn>
* Wen Yang <wen.yang99@zte.com.cn> wrote:
> Fix the following warnings reported by coccinelle:
>
> kernel/locking/locktorture.c:703:6-10: WARNING: Assignment of bool to 0/1
> kernel/locking/locktorture.c:918:2-20: WARNING: Assignment of bool to 0/1
> kernel/locking/locktorture.c:949:3-20: WARNING: Assignment of bool to 0/1
> kernel/locking/locktorture.c:682:2-19: WARNING: Assignment of bool to 0/1
> kernel/locking/locktorture.c:688:2-19: WARNING: Assignment of bool to 0/1
> kernel/locking/locktorture.c:648:2-20: WARNING: Assignment of bool to 0/1
> kernel/locking/locktorture.c:654:2-20: WARNING: Assignment of bool to 0/1
>
> This patch also makes the code more readable.
No, it doesn't make the code more readable!
0/1 patterns are blatantly obvious and shorter to both write and read
than false/true text.
NAK.
Thanks,
Ingo
prev parent reply other threads:[~2018-12-03 8:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 2:23 [PATCH v2] locktorture: Fix assignment of boolean variables Wen Yang
2018-12-03 8:00 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203080039.GA25965@gmail.com \
--to=mingo@kernel.org \
--cc=dave@stgolabs.net \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=wen.yang99@zte.com.cn \
--cc=will.deacon@arm.com \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).