linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] locktorture: style fix - spaces required around
@ 2018-12-03  2:23 Wen Yang
  2018-12-03  8:01 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Wen Yang @ 2018-12-03  2:23 UTC (permalink / raw)
  To: Davidlohr Bueso, paulmck, Josh Triplett, Peter Zijlstra,
	Ingo Molnar, Will Deacon
  Cc: linux-kernel, zhong.weidong, Wen Yang

This patch fixes the following checkpatch.pl errors:

ERROR: spaces required around that ':' (ctx:VxW)
+                torture_type, tag, cxt.debug_lock ? " [debug]": "",
                                                               ^

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
CC: Davidlohr Bueso <dave@stgolabs.net>
CC: "Paul E. McKenney" <paulmck@linux.ibm.com>
CC: Josh Triplett <josh@joshtriplett.org>
CC: Peter Zijlstra <peterz@infradead.org>
CC: Ingo Molnar <mingo@redhat.com>
CC: Will Deacon <will.deacon@arm.com>
CC: linux-kernel@vger.kernel.org
---
 kernel/locking/locktorture.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c
index cd95c01491d8..d1d8356b770a 100644
--- a/kernel/locking/locktorture.c
+++ b/kernel/locking/locktorture.c
@@ -790,7 +790,7 @@ lock_torture_print_module_parms(struct lock_torture_ops *cur_ops,
 {
 	pr_alert("%s" TORTURE_FLAG
 		 "--- %s%s: nwriters_stress=%d nreaders_stress=%d stat_interval=%d verbose=%d shuffle_interval=%d stutter=%d shutdown_secs=%d onoff_interval=%d onoff_holdoff=%d\n",
-		 torture_type, tag, cxt.debug_lock ? " [debug]": "",
+		 torture_type, tag, cxt.debug_lock ? " [debug]" : "",
 		 cxt.nrealwriters_stress, cxt.nrealreaders_stress, stat_interval,
 		 verbose, shuffle_interval, stutter, shutdown_secs,
 		 onoff_interval, onoff_holdoff);
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] locktorture: style fix - spaces required around
  2018-12-03  2:23 [PATCH v2] locktorture: style fix - spaces required around Wen Yang
@ 2018-12-03  8:01 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2018-12-03  8:01 UTC (permalink / raw)
  To: Wen Yang
  Cc: Davidlohr Bueso, paulmck, Josh Triplett, Peter Zijlstra,
	Ingo Molnar, Will Deacon, linux-kernel, zhong.weidong


* Wen Yang <wen.yang99@zte.com.cn> wrote:

> This patch fixes the following checkpatch.pl errors:
> 
> ERROR: spaces required around that ':' (ctx:VxW)
> +                torture_type, tag, cxt.debug_lock ? " [debug]": "",

There's literally 1 million checkpatch 'failures' in the kernel, so 
unless we want to apply 1 million commits (we don't), please do such 
cleanups as part of some real feature, simplification or optimization 
work.

Thanks,

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-03  8:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-03  2:23 [PATCH v2] locktorture: style fix - spaces required around Wen Yang
2018-12-03  8:01 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).