From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: dwmw2@infradead.org, computersforpeace@gmail.com,
marek.vasut@gmail.com, richard@nod.at, robh+dt@kernel.org,
mark.rutland@arm.com, yuenn@google.com, venture@google.com,
brendanhiggins@google.com, avifishman70@gmail.com,
joel@jms.id.au, linux-mtd@lists.infradead.org,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v1 0/2] SPI-NOR add NPCM FIU controller driver
Date: Mon, 3 Dec 2018 10:22:40 +0100 [thread overview]
Message-ID: <20181203102240.79a86a26@bbrezillon> (raw)
In-Reply-To: <20181203091456.454030-1-tmaimon77@gmail.com>
On Mon, 3 Dec 2018 11:14:54 +0200
Tomer Maimon <tmaimon77@gmail.com> wrote:
> This patch set adds Flash Interface Unit(FIU) SPI-NOR
> support for the Nuvoton NPCM Baseboard Management
> Controller (BMC).
>
> The FIU supports single, dual or quad communication interface.
>
> the FIU controller can operate in following modes:
> - User Mode Access(UMA): provides flash access by using an
> indirect address/data mechanism.
> - direct rd/wr mode: maps the flash memory into the core
> address space.
> - SPI-X mode: used for an expansion bus to an ASIC or CPLD.
>
> The NPCM750/730/715/710 supports up to three FIU devices:
> - FIU0 supports two chip select.
> - FIU3 supports four chip select.
> - FIUX supports two chip select.
>
> The NPCM FIU driver tested on NPCM750 evaluation board.
>
> Tomer Maimon (2):
> dt-binding: mtd: add NPCM FIU controller
> mtd: spi-nor: add NPCM FIU controller driver
>
> Documentation/devicetree/bindings/mtd/npcm-fiu.txt | 64 ++
> drivers/mtd/spi-nor/Kconfig | 8 +
> drivers/mtd/spi-nor/Makefile | 1 +
> drivers/mtd/spi-nor/npcm-fiu.c | 930 +++++++++++++++++++++
We are currently trying to move all SPI NOR controller drivers out of
drivers/mtd/spi-nor. Can you try to implement the spi-mem interface [1]
and place your driver in drivers/spi/.
[1]https://elixir.bootlin.com/linux/v4.20-rc5/source/include/linux/spi/spi-mem.h#L185
next prev parent reply other threads:[~2018-12-03 9:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 9:14 [PATCH v1 0/2] SPI-NOR add NPCM FIU controller driver Tomer Maimon
2018-12-03 9:14 ` [PATCH v1 1/2] dt-binding: mtd: add NPCM FIU controller Tomer Maimon
2018-12-19 15:54 ` Rob Herring
2018-12-03 9:14 ` [PATCH v1 2/2] mtd: spi-nor: add NPCM FIU controller driver Tomer Maimon
2018-12-04 0:01 ` kbuild test robot
2018-12-12 15:37 ` kbuild test robot
2018-12-03 9:22 ` Boris Brezillon [this message]
[not found] ` <CAP6Zq1ib3p=UVC8ct_gvB801_XjTwknXMKPfFCq7=d1Jxv0Dfg@mail.gmail.com>
2018-12-03 14:30 ` [PATCH v1 0/2] SPI-NOR " Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203102240.79a86a26@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=avifishman70@gmail.com \
--cc=brendanhiggins@google.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).