From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] tools: Fix diverse typos
Date: Mon, 3 Dec 2018 11:52:19 +0100 [thread overview]
Message-ID: <20181203105219.GA104329@gmail.com> (raw)
In-Reply-To: <20181203103107.GC11573@hirez.programming.kicks-ass.net>
* Peter Zijlstra <peterz@infradead.org> wrote:
> On Mon, Dec 03, 2018 at 11:22:00AM +0100, Ingo Molnar wrote:
> > Go over the tools/ files that are maintained in Arnaldo's tree and
> > fix common typos: half of them were in comments, the other half
> > in JSON files.
> >
> > ( Care should be taken not to re-import these typos in the future,
> > if the JSON files get updated by the vendor without fixing the typos. )
>
> > .../perf/pmu-events/arch/x86/broadwell/cache.json | 4 +--
> > .../pmu-events/arch/x86/broadwell/pipeline.json | 2 +-
> > .../pmu-events/arch/x86/broadwellde/cache.json | 4 +--
> > .../pmu-events/arch/x86/broadwellde/pipeline.json | 2 +-
> > .../perf/pmu-events/arch/x86/broadwellx/cache.json | 4 +--
> > .../pmu-events/arch/x86/broadwellx/pipeline.json | 2 +-
> > tools/perf/pmu-events/arch/x86/jaketown/cache.json | 4 +--
> > .../pmu-events/arch/x86/jaketown/pipeline.json | 2 +-
> > .../pmu-events/arch/x86/knightslanding/cache.json | 30 +++++++++++-----------
> > .../pmu-events/arch/x86/sandybridge/cache.json | 4 +--
> > .../pmu-events/arch/x86/sandybridge/pipeline.json | 2 +-
> > .../pmu-events/arch/x86/skylakex/uncore-other.json | 12 ++++-----
>
> Yeah, so I think those are generated from somewhere, fixing them here
> isn't going to nessecarily help much.
It's in our source code, the output is visible to our users, so such
typos should be fixed.
But yes, I agree that the fixes should also be applied at the Intel
source of the JSON definitions.
Thanks,
Ingo
next prev parent reply other threads:[~2018-12-03 10:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 10:22 [PATCH] tools: Fix diverse typos Ingo Molnar
2018-12-03 10:31 ` Peter Zijlstra
2018-12-03 10:52 ` Ingo Molnar [this message]
2018-12-04 17:16 ` Andi Kleen
2018-12-04 17:40 ` Arnaldo Carvalho de Melo
2018-12-04 13:41 ` Arnaldo Carvalho de Melo
2018-12-04 16:46 ` Steven Rostedt
2018-12-14 20:40 ` [tip:perf/core] perf vendor events intel: " tip-bot for Ingo Molnar
2018-12-14 20:40 ` [tip:perf/core] tools lib traceevent: Fix diverse typos in comments tip-bot for Ingo Molnar
2018-12-14 20:41 ` [tip:perf/core] perf tools Documentation: Fix diverse typos tip-bot for Ingo Molnar
2018-12-14 20:41 ` [tip:perf/core] perf bpf-loader: Fix debugging message typo tip-bot for Ingo Molnar
2018-12-14 20:42 ` [tip:perf/core] perf tools: Fix diverse comment typos tip-bot for Ingo Molnar
2018-12-14 20:43 ` [tip:perf/core] tools lib subcmd: Fix a few source code " tip-bot for Ingo Molnar
2018-12-18 14:07 ` [tip:perf/core] perf vendor events intel: Fix diverse typos tip-bot for Ingo Molnar
2018-12-18 14:07 ` [tip:perf/core] tools lib traceevent: Fix diverse typos in comments tip-bot for Ingo Molnar
2018-12-18 14:08 ` [tip:perf/core] perf tools Documentation: Fix diverse typos tip-bot for Ingo Molnar
2018-12-18 14:08 ` [tip:perf/core] perf bpf-loader: Fix debugging message typo tip-bot for Ingo Molnar
2018-12-18 14:09 ` [tip:perf/core] perf tools: Fix diverse comment typos tip-bot for Ingo Molnar
2018-12-18 14:09 ` [tip:perf/core] tools lib subcmd: Fix a few source code " tip-bot for Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203105219.GA104329@gmail.com \
--to=mingo@kernel.org \
--cc=acme@infradead.org \
--cc=andi@firstfloor.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).