From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: dri-devel@lists.freedesktop.org, Icenowy Zheng <icenowy@aosc.io>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Chen-Yu Tsai <wens@csie.org>, David Airlie <airlied@linux.ie>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-sunxi@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: gpu: add Allwinner H6 Mali Midgard binding
Date: Mon, 3 Dec 2018 13:42:07 +0100 [thread overview]
Message-ID: <20181203124207.qqasvbio67u7bhvz@flea> (raw)
In-Reply-To: <11894938.HOUtrQJeEF@phil>
[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]
On Mon, Dec 03, 2018 at 01:25:21PM +0100, Heiko Stuebner wrote:
> > - reg : Physical base address of the device and length of the register area.
> >
> > @@ -44,6 +45,18 @@ Optional properties:
> > for details.
> >
> >
> > +Vendor-specific bindings
> > +------------------------
> > +
> > +The Mali GPU is integrated very differently from one SoC to
> > +another. In order to accomodate those differences, you have the option
> > +to specify one more vendor-specific compatible, among:
> > +
> > + - allwinner,sun50i-h6-mali
> > + Required properties:
> > + * resets: phandle to the reset line for the GPU
>
> While this paragraph is similar to how it is done in Utgard, I'm
> wondering why we cannot just describe the "resets" as regular
> optional property above that.
Because it's not really optional, it's mandatory on some platforms
(like this one) and has no significance on others.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2018-12-03 12:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 7:42 [PATCH 1/2] dt-bindings: gpu: add bus clock for Mali Midgard GPUs Icenowy Zheng
2018-11-27 7:42 ` [PATCH 2/2] dt-bindings: gpu: add Allwinner H6 Mali Midgard binding Icenowy Zheng
2018-12-03 12:25 ` Heiko Stuebner
2018-12-03 12:42 ` Maxime Ripard [this message]
2018-12-11 17:04 ` Rob Herring
2018-12-11 22:11 ` Rob Herring
2018-12-02 13:46 ` [PATCH 1/2] dt-bindings: gpu: add bus clock for Mali Midgard GPUs Icenowy Zheng
2018-12-11 22:09 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203124207.qqasvbio67u7bhvz@flea \
--to=maxime.ripard@bootlin.com \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=icenowy@aosc.io \
--cc=jernej.skrabec@siol.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).