From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: Tomasz Duszynski <tduszyns@gmail.com>
Cc: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 3/3] iio: chemical: sps30: add device tree support
Date: Mon, 3 Dec 2018 13:10:31 +0000 [thread overview]
Message-ID: <20181203131031.00006b26@huawei.com> (raw)
In-Reply-To: <20181202182943.GA8286@arch>
On Sun, 2 Dec 2018 19:29:44 +0100
Tomasz Duszynski <tduszyns@gmail.com> wrote:
> On Sun, Nov 25, 2018 at 08:59:39AM +0000, Jonathan Cameron wrote:
> > On Sat, 24 Nov 2018 23:14:15 +0100
> > Tomasz Duszynski <tduszyns@gmail.com> wrote:
> >
> > > Add device tree support for Sensirion SPS30 particulate
> > > matter sensor.
> > >
> > > Signed-off-by: Tomasz Duszynski <tduszyns@gmail.com>
> > one comment inine, around the fact we are trying to move
> > to generic names in DT where ever possible. Now we don't
> > have a suitable one (IIRC) yet so time to make one up ;)
> >
> > +CC Rob for his input on that.
> > > ---
> > > .../bindings/iio/chemical/sensirion,sps30.txt | 12 ++++++++++++
> > > 1 file changed, 12 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/iio/chemical/sensirion,sps30.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/chemical/sensirion,sps30.txt b/Documentation/devicetree/bindings/iio/chemical/sensirion,sps30.txt
> > > new file mode 100644
> > > index 000000000000..6eee2709b5b6
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/iio/chemical/sensirion,sps30.txt
> > > @@ -0,0 +1,12 @@
> > > +* Sensirion SPS30 particulate matter sensor
> > > +
> > > +Required properties:
> > > +- compatible: must be "sensirion,sps30"
> > > +- reg: the I2C address of the sensor
> > > +
> > > +Example:
> > > +
> > > +sps30@69 {
> > We should define a generic type. Rob, what would work for this
> > one?
> >
> > particlesensor@69?
> >
>
> Wouldn't air-pollution-sensor be somewhat more generic? At least
> wikipedia has some article about that. Various other names like
> particle-sensor, pm-sensor, particulate-matter-sensor,
> air-quality-sensor, tend to return more or less similar number
> of search hits. Which means there's no universal naming convention.
I have not strong feeling in favor of a particular choice.
Happy with wherever the discussion converges.
Jonathan
>
> > > + compatible = "sensirion,sps30";
> > > + reg = <0x69>;
> > > +};
> >
next prev parent reply other threads:[~2018-12-03 13:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-24 22:14 [PATCH 0/3] add support for Sensirion SPS30 PM sensor Tomasz Duszynski
2018-11-24 22:14 ` [PATCH 1/3] iio: add IIO_MASSCONCENTRATION channel type Tomasz Duszynski
2018-11-25 8:35 ` Jonathan Cameron
2018-11-25 15:19 ` Tomasz Duszynski
2018-11-25 13:51 ` Matt Ranostay
2018-11-25 14:03 ` Jonathan Cameron
2018-11-25 14:14 ` Matt Ranostay
2018-11-25 15:44 ` Tomasz Duszynski
2018-12-01 15:48 ` Jonathan Cameron
2018-12-02 11:32 ` Matt Ranostay
2018-11-25 15:35 ` Tomasz Duszynski
2018-11-24 22:14 ` [PATCH 2/3] iio: chemical: add support for Sensirion SPS30 sensor Tomasz Duszynski
2018-11-25 8:56 ` Jonathan Cameron
2018-11-25 19:05 ` Tomasz Duszynski
2018-12-01 15:58 ` Jonathan Cameron
2018-12-03 10:30 ` Andreas Brauchli
2018-12-04 18:47 ` Tomasz Duszynski
2018-11-25 10:44 ` Himanshu Jha
2018-11-26 20:48 ` Tomasz Duszynski
2018-12-01 16:02 ` Jonathan Cameron
2018-11-24 22:14 ` [PATCH 3/3] iio: chemical: sps30: add device tree support Tomasz Duszynski
2018-11-25 8:59 ` Jonathan Cameron
2018-12-02 18:29 ` Tomasz Duszynski
2018-12-03 13:10 ` Jonathan Cameron [this message]
2018-11-26 4:11 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203131031.00006b26@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@jic23.retrosnub.co.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tduszyns@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).