From: Pavel Machek <pavel@ucw.cz>
To: Michal Hocko <mhocko@kernel.org>
Cc: Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Chanho Min <chanho.min@lge.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] Revert "exec: make de_thread() freezable (was: Re: Linux 4.20-rc4)
Date: Mon, 3 Dec 2018 15:45:36 +0100 [thread overview]
Message-ID: <20181203144536.GA15279@amd> (raw)
In-Reply-To: <20181203141737.GY31738@dhcp22.suse.cz>
[-- Attachment #1: Type: text/plain, Size: 2742 bytes --]
On Mon 2018-12-03 15:17:37, Michal Hocko wrote:
> On Mon 03-12-18 15:14:59, Pavel Machek wrote:
> > On Mon 2018-12-03 14:53:51, Michal Hocko wrote:
> > > On Mon 03-12-18 14:10:06, Pavel Machek wrote:
> > > > On Mon 2018-12-03 13:38:57, Michal Hocko wrote:
> > > > > On Mon 03-12-18 13:31:49, Oleg Nesterov wrote:
> > > > > > On 12/03, Michal Hocko wrote:
> > > > > > >
> > > > > > > Now, I wouldn't mind to revert this because the code is really old and
> > > > > > > we haven't seen many bug reports about failing suspend yet. But what is
> > > > > > > the actual plan to make this work properly?
> > > > > >
> > > > > > I don't see a simple solution...
> > > > > >
> > > > > > But we need to fix exec/de_thread anyway, then we can probably reconsider
> > > > > > this patch.
> > > > >
> > > > > My concern is that de_thread fix might be too disruptive for stable
> > > > > kernels while we might want to have a simple enough fix for the the
> > > > > suspend issue in the meantime. That was actually the primary reason I've
> > > > > acked the hack even though I didn't like it.
> > > >
> > > > Do we care about failing sleep in stable? Does someone hit the issue there?
> > > >
> > > > This sounds like issue only Android is hitting, and they run very
> > > > heavily patched kernels, far away from mainline or stable.
> > >
> > > But the underlying issue is the same and independent on their patches
> > > AFAIU. And is this really a common problem to care about in stable? I
> > > dunno to be honest but it sounds annoying for sure. Failing suspend is
> > > something that doesn't make your day when you are in hurry and want
> > > find out only later when your laptop heats up your bag ;)
> >
> > In general, yes. In practice, if it happens 1 in 1000000 suspends, you
> > don't care that much (but Android cares).
>
> This argument just doesn't make any sense. Rare bugs are maybe even
> more
I guess argumenting about this just does not make sense. Just bear in
mind -stable is not for theoretical problems.
> annoying because you do not expect them to happen. But I would be more
> interested to see whether they are any downside. Is there any actual
> risk to silence the lockup detector that you can see?
As someone else noticed:
a) the bug can be triggered outside suspend
b) the lockdep report is real. You'll still get suspend failure, but
you now need two processes to trigger it
> > Do we actually have reports of this happening for people outside
> > Android?
>
> Not that I am aware of.
Good.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-12-03 14:45 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-25 23:02 Linux 4.20-rc4 Linus Torvalds
2018-12-03 7:47 ` [PATCH] Revert "exec: make de_thread() freezable (was: Re: Linux 4.20-rc4) Ingo Molnar
2018-12-03 8:39 ` Michal Hocko
2018-12-03 12:03 ` Rafael J. Wysocki
2018-12-03 12:31 ` Oleg Nesterov
2018-12-03 12:38 ` Michal Hocko
2018-12-03 13:10 ` Pavel Machek
2018-12-03 13:53 ` Michal Hocko
2018-12-03 14:14 ` Pavel Machek
2018-12-03 14:17 ` Michal Hocko
2018-12-03 14:45 ` Pavel Machek [this message]
2018-12-03 17:06 ` Linus Torvalds
2018-12-03 17:18 ` Michal Hocko
2018-12-03 18:55 ` Pavel Machek
2018-12-04 9:02 ` Ingo Molnar
2018-12-04 9:10 ` Michal Hocko
2018-12-04 9:33 ` Ingo Molnar
2018-12-04 9:58 ` Michal Hocko
2018-12-04 17:31 ` Linus Torvalds
2018-12-04 18:17 ` Michal Hocko
2018-12-04 19:33 ` Linus Torvalds
2018-12-04 19:49 ` Linus Torvalds
2018-12-04 20:05 ` Linus Torvalds
2018-12-04 19:55 ` Pavel Machek
2018-12-04 19:42 ` Pavel Machek
2018-12-04 19:29 ` Pavel Machek
2018-12-03 13:40 ` Oleg Nesterov
2018-12-03 11:56 ` Oleg Nesterov
2018-12-04 9:17 ` Ingo Molnar
2018-12-05 14:36 ` Oleg Nesterov
2018-12-06 8:54 ` Chanho Min
2018-12-06 8:57 ` Pavel Machek
2018-12-06 9:07 ` Chanho Min
2018-12-03 12:00 ` Rafael J. Wysocki
2018-12-04 8:42 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203144536.GA15279@amd \
--to=pavel@ucw.cz \
--cc=a.p.zijlstra@chello.nl \
--cc=chanho.min@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=rafael.j.wysocki@intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).