* [PATCH] ext4: fix possible use after free in ext4_quota_enable
@ 2018-11-26 3:21 Pan Bian
2018-11-27 9:14 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Pan Bian @ 2018-11-26 3:21 UTC (permalink / raw)
To: Theodore Ts'o, Andreas Dilger; +Cc: linux-ext4, linux-kernel, Pan Bian
The function frees qf_inode via iput but then pass qf_inode to
lockdep_set_quota_inode on the failure path. This may result in a
use-after-free bug. The patch frees df_inode only when it is never used.
Signed-off-by: Pan Bian <bianpan2016@163.com>
Fixes: daf647d2dd5("ext4: add lockdep annotations for i_data_sem")
---
fs/ext4/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 53ff6c2..35689eb 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -5690,9 +5690,9 @@ static int ext4_quota_enable(struct super_block *sb, int type, int format_id,
qf_inode->i_flags |= S_NOQUOTA;
lockdep_set_quota_inode(qf_inode, I_DATA_SEM_QUOTA);
err = dquot_enable(qf_inode, type, format_id, flags);
- iput(qf_inode);
if (err)
lockdep_set_quota_inode(qf_inode, I_DATA_SEM_NORMAL);
+ iput(qf_inode);
return err;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: fix possible use after free in ext4_quota_enable
2018-11-26 3:21 [PATCH] ext4: fix possible use after free in ext4_quota_enable Pan Bian
@ 2018-11-27 9:14 ` Jan Kara
2018-12-04 4:33 ` Theodore Y. Ts'o
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kara @ 2018-11-27 9:14 UTC (permalink / raw)
To: Pan Bian; +Cc: Theodore Ts'o, Andreas Dilger, linux-ext4, linux-kernel
On Mon 26-11-18 11:21:06, Pan Bian wrote:
> The function frees qf_inode via iput but then pass qf_inode to
> lockdep_set_quota_inode on the failure path. This may result in a
> use-after-free bug. The patch frees df_inode only when it is never used.
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> Fixes: daf647d2dd5("ext4: add lockdep annotations for i_data_sem")
Thanks for the fix! The patch looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 53ff6c2..35689eb 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -5690,9 +5690,9 @@ static int ext4_quota_enable(struct super_block *sb, int type, int format_id,
> qf_inode->i_flags |= S_NOQUOTA;
> lockdep_set_quota_inode(qf_inode, I_DATA_SEM_QUOTA);
> err = dquot_enable(qf_inode, type, format_id, flags);
> - iput(qf_inode);
> if (err)
> lockdep_set_quota_inode(qf_inode, I_DATA_SEM_NORMAL);
> + iput(qf_inode);
>
> return err;
> }
> --
> 2.7.4
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: fix possible use after free in ext4_quota_enable
2018-11-27 9:14 ` Jan Kara
@ 2018-12-04 4:33 ` Theodore Y. Ts'o
0 siblings, 0 replies; 3+ messages in thread
From: Theodore Y. Ts'o @ 2018-12-04 4:33 UTC (permalink / raw)
To: Jan Kara; +Cc: Pan Bian, Andreas Dilger, linux-ext4, linux-kernel
On Tue, Nov 27, 2018 at 10:14:53AM +0100, Jan Kara wrote:
> On Mon 26-11-18 11:21:06, Pan Bian wrote:
> > The function frees qf_inode via iput but then pass qf_inode to
> > lockdep_set_quota_inode on the failure path. This may result in a
> > use-after-free bug. The patch frees df_inode only when it is never used.
> >
> > Signed-off-by: Pan Bian <bianpan2016@163.com>
> > Fixes: daf647d2dd5("ext4: add lockdep annotations for i_data_sem")
>
> Thanks for the fix! The patch looks good. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-04 4:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-26 3:21 [PATCH] ext4: fix possible use after free in ext4_quota_enable Pan Bian
2018-11-27 9:14 ` Jan Kara
2018-12-04 4:33 ` Theodore Y. Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).