From: Lee Jones <lee.jones@linaro.org>
To: Vignesh R <vigneshr@ti.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-input@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: ti-tsc-adc: Add new compatible for AM654 SoCs
Date: Tue, 4 Dec 2018 09:52:33 +0000 [thread overview]
Message-ID: <20181204095233.GT26661@dell> (raw)
In-Reply-To: <4b42082c-462d-3d94-8ee9-6e7a61f57134@ti.com>
On Tue, 04 Dec 2018, Vignesh R wrote:
> Hi,
>
> On 19/11/18 3:15 PM, Vignesh R wrote:
> > AM654 SoCs has ADC IP which is similar to AM335x. Add new compatible to
> > handle AM654 SoCs. Also, it seems that existing compatible strings used
> > in the kernel DTs were never documented. So, document them now.
> >
> > Signed-off-by: Vignesh R <vigneshr@ti.com>
> > ---
>
> Gentle ping on this patch..
Don't do that.
If you think your patch has been forgotten, please submit a [RESEND].
> > .../devicetree/bindings/input/touchscreen/ti-tsc-adc.txt | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
> > index b1163bf97146..aad5e34965eb 100644
> > --- a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
> > +++ b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
> > @@ -2,7 +2,12 @@
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Required properties:
> > +- mfd
> > + compatible: Should be
> > + "ti,am3359-tscadc" for AM335x/AM437x SoCs
> > + "ti,am654-tscadc", "ti,am3359-tscadc" for AM654 SoCs
> > - child "tsc"
> > + compatible: Should be "ti,am3359-tsc".
> > ti,wires: Wires refer to application modes i.e. 4/5/8 wire touchscreen
> > support on the platform.
> > ti,x-plate-resistance: X plate resistance
> > @@ -25,6 +30,9 @@ Required properties:
> > AIN0 = 0, AIN1 = 1 and so on till AIN7 = 7.
> > XP = 0, XN = 1, YP = 2, YN = 3.
> > - child "adc"
> > + compatible: Should be
> > + "ti,am3359-adc" for AM335x/AM437x SoCs
> > + "ti,am654-adc", "ti,am3359-adc" for AM654 SoCs
> > ti,adc-channels: List of analog inputs available for ADC.
> > AIN0 = 0, AIN1 = 1 and so on till AIN7 = 7.
> >
> >
>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-12-04 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 9:45 [PATCH] dt-bindings: ti-tsc-adc: Add new compatible for AM654 SoCs Vignesh R
2018-12-04 8:30 ` Vignesh R
2018-12-04 9:52 ` Lee Jones [this message]
2018-12-04 9:54 ` Lee Jones
2018-12-04 23:16 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204095233.GT26661@dell \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).