From: Dou Liyang <douliyangs@gmail.com>
To: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Cc: tglx@linutronix.de, kashyap.desai@broadcom.com,
shivasharan.srikanteshwara@broadcom.com,
sumit.saxena@broadcom.com, ming.lei@redhat.com, hch@lst.de,
bhelgaas@google.com, douliyang1@huawei.com,
Dou Liyang <douliyangs@gmail.com>
Subject: [PATCH 3/3] irq/affinity: Fix a possible breakage
Date: Tue, 4 Dec 2018 23:51:22 +0800 [thread overview]
Message-ID: <20181204155122.6327-4-douliyangs@gmail.com> (raw)
In-Reply-To: <20181204155122.6327-1-douliyangs@gmail.com>
In case of irq_default_affinity != cpu_possible_mask, setting the affinity
for the pre/post vectors to irq_default_affinity is a breakage.
Just set the pre/post vectors to cpu_possible_mask and be done with it.
Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Dou Liyang <douliyangs@gmail.com>
---
kernel/irq/affinity.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/kernel/irq/affinity.c b/kernel/irq/affinity.c
index d122575ba1b4..aaa1dd82c3df 100644
--- a/kernel/irq/affinity.c
+++ b/kernel/irq/affinity.c
@@ -257,7 +257,7 @@ irq_create_affinity_masks(int nvecs, const struct irq_affinity *affd)
/* Fill out vectors at the beginning that don't need affinity */
for (curvec = 0; curvec < affd->pre_vectors; curvec++)
- cpumask_copy(&masks[curvec].mask, irq_default_affinity);
+ cpumask_copy(&masks[curvec].mask, cpu_possible_mask);
/*
* Spread on present CPUs starting from affd->pre_vectors. If we
* have multiple sets, build each sets affinity mask separately.
@@ -282,12 +282,15 @@ irq_create_affinity_masks(int nvecs, const struct irq_affinity *affd)
}
/* Fill out vectors at the end that don't need affinity */
- if (usedvecs >= affvecs)
+ if (usedvecs >= affvecs) {
curvec = affd->pre_vectors + affvecs;
- else
+ } else {
curvec = affd->pre_vectors + usedvecs;
+ for (; curvec < affd->pre_vectors + affvecs; curvec++)
+ cpumask_copy(&masks[curvec].mask, irq_default_affinity);
+ }
for (; curvec < nvecs; curvec++)
- cpumask_copy(&masks[curvec].mask, irq_default_affinity);
+ cpumask_copy(&masks[curvec].mask, cpu_possible_mask);
/* Setup complementary information */
for (i = 0; i < nvecs; i++) {
--
2.17.2
next prev parent reply other threads:[~2018-12-04 15:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 15:51 [PATCH 0/3] irq/core: Fix and expand the irq affinity descriptor Dou Liyang
2018-12-04 15:51 ` [PATCH 1/3] genirq/core: Add a new interrupt " Dou Liyang
2018-12-19 10:37 ` [tip:irq/core] genirq/core: Introduce struct irq_affinity_desc tip-bot for Dou Liyang
2018-12-04 15:51 ` [PATCH 2/3] irq/affinity: Add is_managed into " Dou Liyang
2018-12-18 15:26 ` Thomas Gleixner
2018-12-19 10:38 ` [tip:irq/core] genirq/affinity: Add is_managed to " tip-bot for Dou Liyang
2018-12-04 15:51 ` Dou Liyang [this message]
2018-12-05 8:28 ` [PATCH 3/3] irq/affinity: Fix a possible breakage Thomas Gleixner
2018-12-11 16:27 ` Dou Liyang
2018-12-19 10:53 ` [PATCH 0/3] irq/core: Fix and expand the irq affinity descriptor Thomas Gleixner
2018-12-19 12:55 ` Sumit Saxena
2018-12-28 9:54 ` Sumit Saxena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204155122.6327-4-douliyangs@gmail.com \
--to=douliyangs@gmail.com \
--cc=bhelgaas@google.com \
--cc=douliyang1@huawei.com \
--cc=hch@lst.de \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).