From: Rob Herring <robh@kernel.org>
To: Andrei.Stefanescu@microchip.com
Cc: linus.walleij@linaro.org, gregkh@linuxfoundation.org,
Nicolas.Ferre@microchip.com, mark.rutland@arm.com,
Ludovic.Desroches@microchip.com, Cristian.Birsan@microchip.com,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: gpio: add SAMA5D2 PIOBU support
Date: Tue, 4 Dec 2018 17:22:37 -0600 [thread overview]
Message-ID: <20181204232237.GA16883@bogus> (raw)
In-Reply-To: <1542701330-23466-2-git-send-email-andrei.stefanescu@microchip.com>
On Tue, Nov 20, 2018 at 08:08:36AM +0000, Andrei.Stefanescu@microchip.com wrote:
> This patch describes the compatible and the device tree
> bindings necessary for the SAMA5D2 PIOBU GPIO.
>
> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@microchip.com>
> ---
> .../bindings/gpio/gpio-sama5d2-piobu.txt | 31 ++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-sama5d2-piobu.txt
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-sama5d2-piobu.txt b/Documentation/devicetree/bindings/gpio/gpio-sama5d2-piobu.txt
> new file mode 100644
> index 0000000..2e260e1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-sama5d2-piobu.txt
microchip,sama5d2-piobu.txt for the file name.
> @@ -0,0 +1,31 @@
> +GPIO controller for SAMA5D2 PIOBU pins.
> +
> +These pins have the property of not losing their voltage
> +during Backup/Self-refresh mode.
> +
> +These bindings should be set to a node in the dtsi file.
> +
> +Required properties:
> +- compatible: "syscon", "microchip,sama5d2-piobu"
syscon should be removed.
> +- #gpio-cells: There are 2. The pin number is the
> + first, the second represents additional
> + parameters such as GPIO_ACTIVE_HIGH/LOW.
> +- gpio-controller: Marks the port as GPIO controller.
> +
> +Note that the driver uses syscon and should be the child of
> +the syscon node.
child of the "atmel,sama5d2-secumod" node to be more specific.
But why do you need a child node? The parent can be a gpio provider.
What other nodes does this need?
> +
> +Example:
> +
> + secumod@fc040000 {
> + compatible = "atmel,sama5d2-secumod", "syscon", "simple-mfd";
This is not documented as being a simple-mfd.
> + status = "okay";
> + reg = <0xfc040000 0x100>;
> +
> + pioBU: piobu {
gpio {
Is there not a register range you can put here?
> + status = "okay";
> + compatible = "microchip,sama5d2-piobu";
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> + };
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-12-04 23:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 8:08 [PATCH v2 0/2] add SAMA5D2 PIOBU GPIO driver Andrei.Stefanescu
2018-11-20 8:08 ` [PATCH v2 1/2] dt-bindings: gpio: add SAMA5D2 PIOBU support Andrei.Stefanescu
2018-12-04 9:58 ` Andrei.Stefanescu
2018-12-04 23:22 ` Rob Herring [this message]
2018-12-05 11:06 ` Andrei.Stefanescu
2018-12-05 15:22 ` Rob Herring
2018-11-20 8:08 ` [PATCH v2 2/2] gpio: add driver for SAMA5D2 PIOBU pins Andrei.Stefanescu
2018-11-20 10:02 ` [PATCH v2 0/2] add SAMA5D2 PIOBU GPIO driver Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204232237.GA16883@bogus \
--to=robh@kernel.org \
--cc=Andrei.Stefanescu@microchip.com \
--cc=Cristian.Birsan@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).