From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Lee Jones <lee.jones@linaro.org>, <linux-kernel@vger.kernel.org>,
<patches@opensource.cirrus.com>
Subject: Re: [PATCH 18/22] mfd: wm831x-i2c: Make it explicitly non-modular
Date: Wed, 5 Dec 2018 11:38:20 +0000 [thread overview]
Message-ID: <20181205113820.GZ16508@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <1543811009-15112-19-git-send-email-paul.gortmaker@windriver.com>
On Sun, Dec 02, 2018 at 11:23:25PM -0500, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> drivers/mfd/Kconfig:config MFD_WM831X_I2C
> drivers/mfd/Kconfig: bool "Wolfson Microelectronics WM831x/2x PMICs with I2C"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> We explicitly disallow a driver unbind, since that doesn't have a
> sensible use case anyway, and it allows us to drop the ".remove"
> code for non-modular drivers.
>
> Since module_init was not in use by this code, the init ordering
> remains unchanged with this commit.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: patches@opensource.cirrus.com
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
> -static int wm831x_i2c_remove(struct i2c_client *i2c)
> -{
> - struct wm831x *wm831x = i2c_get_clientdata(i2c);
> -
> - wm831x_device_exit(wm831x);
These patches remove the only callers of wm831x_device_exit, so I
guess we should probably remove that function too?
Thanks,
Charles
next prev parent reply other threads:[~2018-12-05 11:38 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 4:23 [PATCH v2 00/22] mfd: demodularization of non-modular drivers Paul Gortmaker
2018-12-03 4:23 ` [PATCH 01/22] mfd: aat2870-core: Make it explicitly non-modular Paul Gortmaker
2018-12-03 4:23 ` [PATCH 02/22] mfd: adp5520: " Paul Gortmaker
2018-12-03 4:23 ` [PATCH 03/22] mfd: as3711: " Paul Gortmaker
2018-12-03 4:23 ` [PATCH 04/22] mfd: da903x: " Paul Gortmaker
2018-12-03 4:23 ` [PATCH 05/22] mfd: da9052-*: " Paul Gortmaker
2018-12-03 4:23 ` [PATCH 06/22] mfd: da9055-i2c: " Paul Gortmaker
2018-12-03 4:23 ` [PATCH 07/22] mfd: da9055-core: make " Paul Gortmaker
2018-12-03 4:23 ` [PATCH 08/22] mfd: db8500-prcmu: drop unused MODULE_ tags from non-modular code Paul Gortmaker
2018-12-07 12:25 ` Linus Walleij
2018-12-03 4:23 ` [PATCH 09/22] mfd: htc-i2cpld: Make it explicitly non-modular Paul Gortmaker
2018-12-03 4:23 ` [PATCH 10/22] mfd: max8925-core: drop unused MODULE_ tags from non-modular code Paul Gortmaker
2018-12-03 4:23 ` [PATCH 11/22] mfd: rc5t583: Make it explicitly non-modular Paul Gortmaker
2018-12-03 4:23 ` [PATCH 12/22] mfd: sta2x11: drop unused MODULE_ tags from non-modular code Paul Gortmaker
2018-12-03 11:14 ` Lee Jones
2018-12-03 15:07 ` Paul Gortmaker
2018-12-04 9:23 ` Davide Ciminaghi
2018-12-07 16:39 ` Alessandro Rubini
2018-12-03 4:23 ` [PATCH 13/22] mfd: syscon: Make it explicitly non-modular Paul Gortmaker
2018-12-03 4:23 ` [PATCH 14/22] mfd: tps65090: " Paul Gortmaker
2018-12-03 4:23 ` [PATCH 15/22] mfd: tps65910: " Paul Gortmaker
2018-12-03 4:23 ` [PATCH 16/22] mfd: tps80031: " Paul Gortmaker
2018-12-03 4:23 ` [PATCH 17/22] mfd: wm831x-spi: " Paul Gortmaker
2018-12-03 4:23 ` [PATCH 18/22] mfd: wm831x-i2c: " Paul Gortmaker
2018-12-05 11:38 ` Charles Keepax [this message]
2018-12-07 18:16 ` Paul Gortmaker
2018-12-03 4:23 ` [PATCH 19/22] mfd: wm831x-core: drop unused MODULE_ tags from non-modular code Paul Gortmaker
2018-12-05 11:36 ` Charles Keepax
2018-12-03 4:23 ` [PATCH 20/22] mfd: wm8350-i2c: Make it explicitly non-modular Paul Gortmaker
2018-12-05 11:39 ` Charles Keepax
2018-12-03 4:23 ` [PATCH 21/22] mfd: wm8350-core: drop unused MODULE_ tags from non-modular code Paul Gortmaker
2018-12-05 11:39 ` Charles Keepax
2018-12-03 4:23 ` [PATCH 22/22] mfd: wm8400-core: Make it explicitly non-modular Paul Gortmaker
2018-12-05 11:41 ` Charles Keepax
2018-12-05 11:35 ` [PATCH v2 00/22] mfd: demodularization of non-modular drivers Charles Keepax
2018-12-05 11:48 ` Linus Walleij
2018-12-05 13:40 ` Charles Keepax
2018-12-05 11:50 ` Linus Walleij
2018-12-05 12:01 ` Steve Twiss
2018-12-05 12:12 ` Steve Twiss
2018-12-05 18:08 ` Paul Gortmaker
[not found] ` <20181207203021.GR23156@windriver.com>
2019-08-07 10:43 ` Steve Twiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205113820.GZ16508@imbe.wolfsonmicro.main \
--to=ckeepax@opensource.cirrus.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).