From: Joerg Roedel <joro@8bytes.org>
To: Yu Zhao <yuzhao@google.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu: fix amd_iommu=force_isolation
Date: Wed, 5 Dec 2018 17:09:55 +0100 [thread overview]
Message-ID: <20181205160955.p3juusqdxarmo2yc@8bytes.org> (raw)
In-Reply-To: <20181204223716.214159-1-yuzhao@google.com>
On Tue, Dec 04, 2018 at 03:37:16PM -0700, Yu Zhao wrote:
> The parameter is still there but it's ignored. We need to check its
> value before deciding to go into passthrough mode for AMD IOMMU.
>
> Fixes: aafd8ba0ca74 ("iommu/amd: Implement add_device and remove_device")
>
> Signed-off-by: Yu Zhao <yuzhao@google.com>
> ---
> drivers/iommu/amd_iommu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> index 1167ff0416cf..3e4219e6cff0 100644
> --- a/drivers/iommu/amd_iommu.c
> +++ b/drivers/iommu/amd_iommu.c
> @@ -2195,7 +2195,8 @@ static int amd_iommu_add_device(struct device *dev)
>
> BUG_ON(!dev_data);
>
> - if (iommu_pass_through || dev_data->iommu_v2)
> + if (iommu_pass_through ||
> + (!amd_iommu_force_isolation && dev_data->iommu_v2))
This breaks the iommu_v2 use-case, as it needs a direct mapping for the
devices that support it.
I think the force_isolation parameter does not make sense anymore today
and should be removed.
Regards,
Joerg
next prev parent reply other threads:[~2018-12-05 16:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 22:37 [PATCH] iommu: fix amd_iommu=force_isolation Yu Zhao
2018-12-05 16:09 ` Joerg Roedel [this message]
2018-12-05 19:30 ` Yu Zhao
2018-12-06 21:39 ` [PATCH v2] " Yu Zhao
2018-12-07 13:08 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205160955.p3juusqdxarmo2yc@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).