From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Tony Luck <tony.luck@intel.com>, X86 ML <x86@kernel.org>,
linux-edac <linux-edac@vger.kernel.org>
Subject: Re: [PATCH] x86/mce: Streamline MCE subsystem's naming
Date: Wed, 5 Dec 2018 18:00:06 +0100 [thread overview]
Message-ID: <20181205170006.GK29510@zn.tnic> (raw)
In-Reply-To: <20181205163037.GC109259@gmail.com>
On Wed, Dec 05, 2018 at 05:30:37PM +0100, Ingo Molnar wrote:
> Would it make sense to organize it a bit more and separate out vendor
> specific functionality:
>
> mce/cpu/intel.c
> mce/cpu/intel-p5.c
> mce/cpu/amd.c
> mce/cpu/winchip.c
That's too fine-grained IMO and look at the path we'd get then:
arch/x86/kernel/cpu/mce/cpu/intel.c
^^^ ^^^
which brings me to something we already talked about: the "kernel" part
of the arch/x86/ paths. See this thread:
https://lkml.kernel.org/r/20140114185802.GB29871@pd.tnic
from 2014. We practically agreed there that "kernel/" is redundant as it
all is kernel. So maybe we should start moving stuff up into arch/x86/
and then kill kernel/ eventually.
> This way there's a clear separation between low level, vendor specific
> MCE logic and higher level MCE logic.
>
> mce/apei.c, if this is an Intel-only feature, could perhaps become
> mce/cpu/intel-apei.c?
Yeah, I think the pile in mce/ is pretty succinct now. We can always
separate it more later, if it starts to hurt but right now it is ok,
IMO.
> Anyway, your patch is fine too, so whichever subset you decide to use:
>
> Reviewed-by: Ingo Molnar <mingo@kernel.org>
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-12-05 17:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 14:13 [PATCH] x86/mce: Streamline MCE subsystem's naming Borislav Petkov
2018-12-05 16:30 ` Ingo Molnar
2018-12-05 17:00 ` Borislav Petkov [this message]
2018-12-05 18:01 ` Ingo Molnar
2018-12-05 19:03 ` Borislav Petkov
2018-12-06 16:27 ` Ingo Molnar
2018-12-06 17:36 ` Luck, Tony
2018-12-06 18:05 ` Borislav Petkov
2018-12-05 16:57 ` Luck, Tony
2018-12-05 20:09 ` [PATCH] x86/mce: Unify pr_* prefix Borislav Petkov
2018-12-11 13:31 ` [tip:ras/core] " tip-bot for Borislav Petkov
2018-12-18 18:25 ` [PATCH] x86/mce: Restore MCE injector's module name Borislav Petkov
2018-12-18 23:09 ` [tip:ras/core] " tip-bot for Borislav Petkov
2018-12-11 13:30 ` [tip:ras/core] x86/mce: Streamline MCE subsystem's naming tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205170006.GK29510@zn.tnic \
--to=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).