From: Sicilia Cristian <sicilia.cristian@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Bryan O Donoghue <pure.logic@nexus-software.ie>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
greybus-dev@lists.linaro.org
Subject: Re: [PATCH 1/2] staging: greybus: Align function call parameters to parenthesis
Date: Wed, 5 Dec 2018 22:09:51 +0100 [thread overview]
Message-ID: <20181205210951.GA24993@peano> (raw)
In-Reply-To: <20181205084603.GA4987@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]
On Wed, Dec 05, 2018 at 09:46:03AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Dec 04, 2018 at 09:58:14PM +0100, Cristian Sicilia wrote:
> > Aligned some parameters to the previous parenthesis.
> >
> > Signed-off-by: Cristian Sicilia <sicilia.cristian@gmail.com>
> > ---
> > drivers/staging/greybus/loopback.c | 10 ++++++----
> > 1 file changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> > index e4d42c1..1085e06 100644
> > --- a/drivers/staging/greybus/loopback.c
> > +++ b/drivers/staging/greybus/loopback.c
> > @@ -638,7 +638,8 @@ static int gb_loopback_async_transfer(struct gb_loopback *gb, u32 len)
> > retval = gb_loopback_async_operation(gb, GB_LOOPBACK_TYPE_TRANSFER,
> > request, len + sizeof(*request),
> > len + response_len,
> > - gb_loopback_async_transfer_complete);
> > + gb_loopback_async_transfer_complete
> > + );
>
> Ick, why do this? That's not really needed.
>
Ok, better to leave it unchanged
> thanks,
>
> greg k-h
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2018-12-05 21:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 20:58 [PATCH 0/2] staging: greybus: Fix parameters alignment and strings concatenation Cristian Sicilia
2018-12-04 20:58 ` [PATCH 1/2] staging: greybus: Align function call parameters to parenthesis Cristian Sicilia
2018-12-05 8:46 ` Greg Kroah-Hartman
2018-12-05 21:09 ` Sicilia Cristian [this message]
2018-12-04 20:58 ` [PATCH 2/2] staging: greybus: Added space between string concatenated Cristian Sicilia
2018-12-05 10:12 ` Bryan O'Donoghue
2018-12-05 21:00 ` Sicilia Cristian
2018-12-06 9:43 ` Bryan O'Donoghue
2018-12-06 15:05 ` Greg Kroah-Hartman
2018-12-06 16:14 ` Bryan O'Donoghue
2018-12-06 16:23 ` Greg Kroah-Hartman
2018-12-06 16:24 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205210951.GA24993@peano \
--to=sicilia.cristian@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).