linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, mdf@kernel.org,
	Heiko Stuebner <heiko.stuebner@bq.com>
Subject: Re: [PATCH v2] power: supply: bq24190_charger: add support for bq24196 variant
Date: Wed, 5 Dec 2018 23:03:40 +0100	[thread overview]
Message-ID: <20181205220340.soejl65puivnwhz7@earth.universe> (raw)
In-Reply-To: <20181113124753.29948-1-heiko@sntech.de>

[-- Attachment #1: Type: text/plain, Size: 2599 bytes --]

Hi,

On Tue, Nov 13, 2018 at 01:47:53PM +0100, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@bq.com>
> 
> The bq24196 is another variant of the bq24190 charger ic.
> Its register set is identical to the bq24192 and it even reuses
> the same part number (0x5).
> 
> Signed-off-by: Heiko Stuebner <heiko.stuebner@bq.com>
> ---

Thanks, queued.

-- Sebastian

> This should go on top of the bq24192 support patches from Brian Masney /
> Jonathan Marek [0]
> 
> [0] https://patchwork.kernel.org/patch/10663409/
> 
> changes in v2:
> - add missing compatible to dt-binding
> 
>  Documentation/devicetree/bindings/power/supply/bq24190.txt | 1 +
>  drivers/power/supply/bq24190_charger.c                     | 4 +++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/bq24190.txt b/Documentation/devicetree/bindings/power/supply/bq24190.txt
> index c8ac028bd3c7..ffe2be408bb6 100644
> --- a/Documentation/devicetree/bindings/power/supply/bq24190.txt
> +++ b/Documentation/devicetree/bindings/power/supply/bq24190.txt
> @@ -5,6 +5,7 @@ Required properties:
>      * "ti,bq24190"
>      * "ti,bq24192"
>      * "ti,bq24192i"
> +    * "ti,bq24196"
>  - reg: integer, I2C address of the charger.
>  - interrupts[-extended]: configuration for charger INT pin.
>  
> diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
> index 4e64e6ac95c5..effa7c3c21e6 100644
> --- a/drivers/power/supply/bq24190_charger.c
> +++ b/drivers/power/supply/bq24190_charger.c
> @@ -143,7 +143,7 @@
>  #define BQ24190_REG_VPRS_PN_MASK		(BIT(5) | BIT(4) | BIT(3))
>  #define BQ24190_REG_VPRS_PN_SHIFT		3
>  #define BQ24190_REG_VPRS_PN_24190			0x4
> -#define BQ24190_REG_VPRS_PN_24192			0x5 /* Also 24193 */
> +#define BQ24190_REG_VPRS_PN_24192			0x5 /* Also 24193, 24196 */
>  #define BQ24190_REG_VPRS_PN_24192I			0x3
>  #define BQ24190_REG_VPRS_TS_PROFILE_MASK	BIT(2)
>  #define BQ24190_REG_VPRS_TS_PROFILE_SHIFT	2
> @@ -1973,6 +1973,7 @@ static const struct i2c_device_id bq24190_i2c_ids[] = {
>  	{ "bq24190" },
>  	{ "bq24192" },
>  	{ "bq24192i" },
> +	{ "bq24196" },
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(i2c, bq24190_i2c_ids);
> @@ -1982,6 +1983,7 @@ static const struct of_device_id bq24190_of_match[] = {
>  	{ .compatible = "ti,bq24190", },
>  	{ .compatible = "ti,bq24192", },
>  	{ .compatible = "ti,bq24192i", },
> +	{ .compatible = "ti,bq24196", },
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(of, bq24190_of_match);
> -- 
> 2.18.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2018-12-05 22:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13 12:47 [PATCH v2] power: supply: bq24190_charger: add support for bq24196 variant Heiko Stuebner
2018-11-17 15:44 ` Rob Herring
2018-11-29 14:07 ` Heiko Stuebner
2018-12-05 22:03 ` Sebastian Reichel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181205220340.soejl65puivnwhz7@earth.universe \
    --to=sebastian.reichel@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko.stuebner@bq.com \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mdf@kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).