Re: [PATCH 3/4] power: reset: at91-poweroff: check shdwc data structure at the beginning of probe

From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Claudiu.Beznea@microchip.com
Cc: Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com,
	linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] power: reset: at91-poweroff: check shdwc data structure at the beginning of probe
Date: Wed, 5 Dec 2018 23:38:25 +0100	[thread overview]
Message-ID: <20181205223825.vkye6tgvan2laxlu@earth.universe> (raw)
In-Reply-To: <1541416443-4321-4-git-send-email-claudiu.beznea@microchip.com>

[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]

Hi,

On Mon, Nov 05, 2018 at 11:14:28AM +0000, Claudiu.Beznea@microchip.com wrote:
> Check at91_shdwc before continuing with probe since we want only one instance of
> this driver. Inspired from commit 9f1e44774be5 ("power: reset: at91-poweroff:
> do not procede if at91_shdwc is allocated").
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---

This depends on patch 2, so I skipped this one.

-- Sebastian

>  drivers/power/reset/at91-poweroff.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/power/reset/at91-poweroff.c b/drivers/power/reset/at91-poweroff.c
> index 48661e04a3de..e75d8f0f0526 100644
> --- a/drivers/power/reset/at91-poweroff.c
> +++ b/drivers/power/reset/at91-poweroff.c
> @@ -160,6 +160,9 @@ static int __init at91_poweroff_probe(struct platform_device *pdev)
>  	u32 ddr_type;
>  	int ret;
>  
> +	if (at91_shdwc)
> +		return -EBUSY;
> +
>  	at91_shdwc = devm_kzalloc(&pdev->dev, sizeof(*at91_shdwc), GFP_KERNEL);
>  	if (!at91_shdwc)
>  		return -ENOMEM;
> -- 
> 2.7.4
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]