From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A096C04EB8 for ; Thu, 6 Dec 2018 13:11:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28FEE208E7 for ; Thu, 6 Dec 2018 13:11:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28FEE208E7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729614AbeLFNLK (ORCPT ); Thu, 6 Dec 2018 08:11:10 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:50136 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728482AbeLFNLK (ORCPT ); Thu, 6 Dec 2018 08:11:10 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1859DA78; Thu, 6 Dec 2018 05:11:10 -0800 (PST) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DBEDF3F575; Thu, 6 Dec 2018 05:11:09 -0800 (PST) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id EEE3A1AE0BAD; Thu, 6 Dec 2018 13:11:30 +0000 (GMT) Date: Thu, 6 Dec 2018 13:11:30 +0000 From: Will Deacon To: Joerg Roedel Cc: iommu@lists.linux-foundation.org, Robin Murphy , linux-kernel@vger.kernel.org, Joerg Roedel Subject: Re: [PATCH 3/9] iommu/arm-smmu: Use helper functions to access dev->iommu_fwspec Message-ID: <20181206131130.GA27744@arm.com> References: <20181204163002.15800-1-joro@8bytes.org> <20181204163002.15800-4-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181204163002.15800-4-joro@8bytes.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 04, 2018 at 05:29:56PM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > Use the new helpers dev_iommu_fwspec_get()/set() to access > the dev->iommu_fwspec pointer. This makes it easier to move > that pointer later into another struct. > > Cc: Will Deacon > Cc: Robin Murphy > Signed-off-by: Joerg Roedel > --- > drivers/iommu/arm-smmu-v3.c | 16 +++++++++------- > drivers/iommu/arm-smmu.c | 12 ++++++------ > 2 files changed, 15 insertions(+), 13 deletions(-) Looks straighforward enough to me: Acked-by: Will Deacon Will