From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94A97C04EB8 for ; Thu, 6 Dec 2018 14:57:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5BFFC20700 for ; Thu, 6 Dec 2018 14:57:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544108268; bh=mvCBfPpOgq9Lbeq4KoowCH9L/yMZXCOKAhTqX1Nh85M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=wRBzfzNcO/Onj3vhYmAgN2Z79B12DueFecrDUKhuhoQeWvi9QlkvjqJEqYt46Bi3c Mmre1XcOptXqU9Qn3ydfhSov7qh9ItcO33bC19ZfcfdnCMKYPYRR2Ei/qDmV2bV7Ls ys8IqI2yOBw1KEKvxwiZUqPHs0/It+/LTvUXkp9w= DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BFFC20700 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730477AbeLFOm3 (ORCPT ); Thu, 6 Dec 2018 09:42:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:46692 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730457AbeLFOmX (ORCPT ); Thu, 6 Dec 2018 09:42:23 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DF430214C1; Thu, 6 Dec 2018 14:42:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544107343; bh=mvCBfPpOgq9Lbeq4KoowCH9L/yMZXCOKAhTqX1Nh85M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fs8YOtIIDbNA6R5a3kntaLWBAvLBBScTPLThr4SzPs/NGznzPlR8OmY4eLWuXNGNI MYDU7UBdYkoVTTEyLgkQcIjYgF2uUPfSgQ/MNML9mOq/Sai4XkotRyVw9h3w9g4kw/ NjIlHntqra7Ihdcx4qssTQMMrp+OdVUZ+oW1q6NI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sam Bobroff , Dave Airlie Subject: [PATCH 4.14 18/55] drm/ast: Fix incorrect free on ioregs Date: Thu, 6 Dec 2018 15:38:52 +0100 Message-Id: <20181206143002.696870186@linuxfoundation.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181206143001.749982936@linuxfoundation.org> References: <20181206143001.749982936@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sam Bobroff commit dc25ab067645eabd037f1a23d49a666f9e0b8c68 upstream. If the platform has no IO space, ioregs is placed next to the already allocated regs. In this case, it should not be separately freed. This prevents a kernel warning from __vunmap "Trying to vfree() nonexistent vm area" when unloading the driver. Fixes: 0dd68309b9c5 ("drm/ast: Try to use MMIO registers when PIO isn't supported") Signed-off-by: Sam Bobroff Cc: Signed-off-by: Dave Airlie Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/ast/ast_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/ast/ast_main.c +++ b/drivers/gpu/drm/ast/ast_main.c @@ -583,7 +583,8 @@ void ast_driver_unload(struct drm_device drm_mode_config_cleanup(dev); ast_mm_fini(ast); - pci_iounmap(dev->pdev, ast->ioregs); + if (ast->ioregs != ast->regs + AST_IO_MM_OFFSET) + pci_iounmap(dev->pdev, ast->ioregs); pci_iounmap(dev->pdev, ast->regs); kfree(ast); }