LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Qian Cai <cai@gmx.us>
Cc: akpm@linux-foundation.org, gregkh@linuxfoundation.org,
	rafael@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] drivers/base: kmemleak ignore a known leak
Date: Thu, 6 Dec 2018 17:59:49 +0000
Message-ID: <20181206175949.GR54495@arrakis.emea.arm.com> (raw)
In-Reply-To: <20181206160751.36211-1-cai@gmx.us>

On Thu, Dec 06, 2018 at 11:07:51AM -0500, Qian Cai wrote:
> unreferenced object 0xffff808ec6dc5a80 (size 128):
>   comm "swapper/0", pid 1, jiffies 4294938063 (age 2560.530s)
>   hex dump (first 32 bytes):
>     ff ff ff ff 00 00 00 00 6b 6b 6b 6b 6b 6b 6b 6b  ........kkkkkkkk
>     6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b  kkkkkkkkkkkkkkkk
>   backtrace:
>     [<00000000476dcf8c>] kmem_cache_alloc_trace+0x430/0x500
>     [<000000004f708d37>] platform_device_register_full+0xbc/0x1e8
>     [<000000006c2a7ec7>] acpi_create_platform_device+0x370/0x450
>     [<00000000ef135642>] acpi_default_enumeration+0x34/0x78
>     [<000000003bd9a052>] acpi_bus_attach+0x2dc/0x3e0
>     [<000000003cf4f7f2>] acpi_bus_attach+0x108/0x3e0
>     [<000000003cf4f7f2>] acpi_bus_attach+0x108/0x3e0
>     [<000000002968643e>] acpi_bus_scan+0xb0/0x110
>     [<0000000010dd0bd7>] acpi_scan_init+0x1a8/0x410
>     [<00000000965b3c5a>] acpi_init+0x408/0x49c
>     [<00000000ed4b9fe2>] do_one_initcall+0x178/0x7f4
>     [<00000000a5ac5a74>] kernel_init_freeable+0x9d4/0xa9c
>     [<0000000070ea6c15>] kernel_init+0x18/0x138
>     [<00000000fb8fff06>] ret_from_fork+0x10/0x1c
>     [<0000000041273a0d>] 0xffffffffffffffff
> 
> Then, faddr2line pointed out this line,
> 
> /*
>  * This memory isn't freed when the device is put,
>  * I don't have a nice idea for that though.  Conceptually
>  * dma_mask in struct device should not be a pointer.
>  * See http://thread.gmane.org/gmane.linux.kernel.pci/9081
>  */
> pdev->dev.dma_mask =
> 	kmalloc(sizeof(*pdev->dev.dma_mask), GFP_KERNEL);
> 
> Since this leak has been existed for more than 8-year now and it does not
> reference other part of the memory, let kmemleak ignore it, so users don't
> need to waste time reporting this in the future.
> 
> Signed-off-by: Qian Cai <cai@gmx.us>

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29 15:12 [PATCH] " Qian Cai
2018-12-06 16:07 ` [RESEND PATCH] " Qian Cai
2018-12-06 17:59   ` Catalin Marinas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181206175949.GR54495@arrakis.emea.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=cai@gmx.us \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git