LKML Archive on lore.kernel.org
 help / Atom feed
* [PATCH] riscv: remove unused variable in ftrace
@ 2018-12-06 10:26 David Abdurachmanov
  2018-12-06 19:20 ` Olof Johansson
  0 siblings, 1 reply; 3+ messages in thread
From: David Abdurachmanov @ 2018-12-06 10:26 UTC (permalink / raw)
  To: palmer, aou, linux-riscv, linux-kernel; +Cc: David Abdurachmanov

Noticed while building kernel-4.20.0-0.rc5.git2.1.fc30 for
Fedora 30/RISCV.

[..]
BUILDSTDERR: arch/riscv/kernel/ftrace.c: In function 'prepare_ftrace_return':
BUILDSTDERR: arch/riscv/kernel/ftrace.c:135:6: warning: unused variable 'err' [-Wunused-variable]
BUILDSTDERR:   int err;
BUILDSTDERR:       ^~~
[..]

Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
---
 arch/riscv/kernel/ftrace.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/riscv/kernel/ftrace.c b/arch/riscv/kernel/ftrace.c
index c433f6d3dd64..a840b7d074f7 100644
--- a/arch/riscv/kernel/ftrace.c
+++ b/arch/riscv/kernel/ftrace.c
@@ -132,7 +132,6 @@ void prepare_ftrace_return(unsigned long *parent, unsigned long self_addr,
 {
 	unsigned long return_hooker = (unsigned long)&return_to_handler;
 	unsigned long old;
-	int err;
 
 	if (unlikely(atomic_read(&current->tracing_graph_pause)))
 		return;
-- 
2.19.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] riscv: remove unused variable in ftrace
  2018-12-06 10:26 [PATCH] riscv: remove unused variable in ftrace David Abdurachmanov
@ 2018-12-06 19:20 ` Olof Johansson
  2018-12-07  1:07   ` Steven Rostedt
  0 siblings, 1 reply; 3+ messages in thread
From: Olof Johansson @ 2018-12-06 19:20 UTC (permalink / raw)
  To: David Abdurachmanov
  Cc: Palmer Dabbelt, Albert Ou, linux-riscv,
	Linux Kernel Mailing List, Steven Rostedt

On Thu, Dec 6, 2018 at 2:26 AM David Abdurachmanov
<david.abdurachmanov@gmail.com> wrote:
>
> Noticed while building kernel-4.20.0-0.rc5.git2.1.fc30 for
> Fedora 30/RISCV.
>
> [..]
> BUILDSTDERR: arch/riscv/kernel/ftrace.c: In function 'prepare_ftrace_return':
> BUILDSTDERR: arch/riscv/kernel/ftrace.c:135:6: warning: unused variable 'err' [-Wunused-variable]
> BUILDSTDERR:   int err;
> BUILDSTDERR:       ^~~
> [..]
>
> Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>

Please add a:
Fixes: e949b6db51dc1 ("riscv/function_graph: Simplify with
function_graph_enter()")
Reviewed-by: Olof Johansson <olof@lixom.net>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] riscv: remove unused variable in ftrace
  2018-12-06 19:20 ` Olof Johansson
@ 2018-12-07  1:07   ` Steven Rostedt
  0 siblings, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2018-12-07  1:07 UTC (permalink / raw)
  To: Olof Johansson
  Cc: David Abdurachmanov, Palmer Dabbelt, Albert Ou, linux-riscv,
	Linux Kernel Mailing List

On Thu, 6 Dec 2018 11:20:31 -0800
Olof Johansson <olof@lixom.net> wrote:

> On Thu, Dec 6, 2018 at 2:26 AM David Abdurachmanov
> <david.abdurachmanov@gmail.com> wrote:
> >
> > Noticed while building kernel-4.20.0-0.rc5.git2.1.fc30 for
> > Fedora 30/RISCV.
> >
> > [..]
> > BUILDSTDERR: arch/riscv/kernel/ftrace.c: In function 'prepare_ftrace_return':
> > BUILDSTDERR: arch/riscv/kernel/ftrace.c:135:6: warning: unused variable 'err' [-Wunused-variable]
> > BUILDSTDERR:   int err;
> > BUILDSTDERR:       ^~~

Bah. I could have sworn I checked for all the error messages when I did
my cross-compiling of the architectures. I fixed this issue in other
places, not sure how I missed riscv.

Thanks for fixing it.

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

 
> > [..]
> >
> > Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>  
> 
> Please add a:
> Fixes: e949b6db51dc1 ("riscv/function_graph: Simplify with
> function_graph_enter()")
> Reviewed-by: Olof Johansson <olof@lixom.net>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-06 10:26 [PATCH] riscv: remove unused variable in ftrace David Abdurachmanov
2018-12-06 19:20 ` Olof Johansson
2018-12-07  1:07   ` Steven Rostedt

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox