From: Rob Herring <robh@kernel.org>
To: Eugen.Hristev@microchip.com
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
thierry.reding@gmail.com, airlied@linux.ie,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Nicolas.Ferre@microchip.com, Cristian.Birsan@microchip.com
Subject: Re: [PATCH 2/3] dt-bindings: drm/panel: simple: add support for PDA 91-00156-A0
Date: Thu, 6 Dec 2018 17:45:50 -0600 [thread overview]
Message-ID: <20181206234550.GA3012@bogus> (raw)
In-Reply-To: <1542789804-4584-3-git-send-email-eugen.hristev@microchip.com>
On Wed, Nov 21, 2018 at 08:48:00AM +0000, Eugen.Hristev@microchip.com wrote:
> From: Cristian Birsan <cristian.birsan@microchip.com>
>
> PDA 91-00156-A0 5.0 is a 5.0" WVGA TFT LCD panel.
> This panel with backlight is found in PDA 5" LCD screen (TM5000 series or
> AC320005-5).
> Adding Device Tree bindings for this panel.
>
> Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
> ---
> .../devicetree/bindings/display/panel/pda,91-00156-a0.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.txt
>
> diff --git a/Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.txt b/Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.txt
> new file mode 100644
> index 0000000..52f0da9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.txt
> @@ -0,0 +1,7 @@
> +PDA 91-00156-A0 5.0" WVGA TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "pda,91-00156-a0"
> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.
You need to explicitly list what properties from this are used. Does
this have a single supply or did you just forget to add supplies for
example? I don't know.
Rob
next prev parent reply other threads:[~2018-12-06 23:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 8:47 [PATCH 0/3] drm: Add panel support for PDA 91-00156-A0 Eugen.Hristev
2018-11-21 8:47 ` [PATCH 1/3] dt-bindings: add vendor prefix for PDA Precision Design Associates, Inc Eugen.Hristev
2018-12-06 23:44 ` Rob Herring
2018-11-21 8:48 ` [PATCH 2/3] dt-bindings: drm/panel: simple: add support for PDA 91-00156-A0 Eugen.Hristev
2018-12-06 23:45 ` Rob Herring [this message]
2018-11-21 8:48 ` [PATCH 3/3] drm/panel: simple: add support for PDA 91-00156-A0 panel Eugen.Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206234550.GA3012@bogus \
--to=robh@kernel.org \
--cc=Cristian.Birsan@microchip.com \
--cc=Eugen.Hristev@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).