From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Oleg Nesterov <oleg@redhat.com>, Breno Leitao <leitao@debian.org>,
Andy Lutomirski <luto@kernel.org>,
Eugene Syromyatnikov <esyr@redhat.com>,
Elvira Khabirova <lineprinter@altlinux.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call
Date: Fri, 7 Dec 2018 04:19:47 +0300 [thread overview]
Message-ID: <20181207011946.GA18558@altlinux.org> (raw)
In-Reply-To: <20181203031823.GE11573@altlinux.org>
[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]
On Mon, Dec 03, 2018 at 06:18:23AM +0300, Dmitry V. Levin wrote:
> From: Elvira Khabirova <lineprinter@altlinux.org>
>
> Arch code should use tracehook_*() helpers, as documented
> in include/linux/tracehook.h,
> ptrace_report_syscall() is not expected to be used outside that file.
>
> Co-authored-by: Dmitry V. Levin <ldv@altlinux.org>
> Fixes: 5521eb4bca2d ("powerpc/ptrace: Add support for PTRACE_SYSEMU")
> Signed-off-by: Elvira Khabirova <lineprinter@altlinux.org>
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> ---
> v4: rewritten to call tracehook_report_syscall_entry() once, compile-tested
> v3: add a descriptive comment
> v2: explicitly ignore tracehook_report_syscall_entry() return code
>
> arch/powerpc/kernel/ptrace.c | 54 +++++++++++++++++++++++-------------
> 1 file changed, 35 insertions(+), 19 deletions(-)
Sorry, this patch does not work, please ignore it.
However, the bug blocks PTRACE_GET_SYSCALL_INFO, so please fix it.
I'm going to use
if (tracehook_report_syscall_entry(regs))
return -1;
return -1;
in the series until you have a better fix.
--
ldv
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2018-12-07 1:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 11:17 [PATCH v2] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call Elvira Khabirova
2018-11-16 12:42 ` Michael Ellerman
2018-11-19 21:01 ` [PATCH v3] " Dmitry V. Levin
2018-11-21 21:17 ` Michael Ellerman
2018-12-03 3:18 ` [PATCH v4] " Dmitry V. Levin
2018-12-07 1:19 ` Dmitry V. Levin [this message]
2018-12-07 11:12 ` Michael Ellerman
2018-12-07 15:42 ` Dmitry V. Levin
2018-12-07 15:56 ` [PATCH v5] " Dmitry V. Levin
2018-12-07 18:52 ` [PATCH v6] " Dmitry V. Levin
2018-12-10 13:28 ` Oleg Nesterov
2018-12-10 13:36 ` Dmitry V. Levin
2018-12-16 17:28 ` [PATCH] powerpc/ptrace: cleanup do_syscall_trace_enter Dmitry V. Levin
2018-12-17 11:20 ` Michael Ellerman
2018-12-17 11:23 ` Dmitry V. Levin
2018-12-17 11:27 ` Oleg Nesterov
2018-12-22 9:54 ` Michael Ellerman
2018-12-11 13:45 ` [v5] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call Michael Ellerman
2018-12-07 16:34 ` [PATCH v4] " Oleg Nesterov
2018-12-07 18:42 ` Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207011946.GA18558@altlinux.org \
--to=ldv@altlinux.org \
--cc=benh@kernel.crashing.org \
--cc=esyr@redhat.com \
--cc=leitao@debian.org \
--cc=lineprinter@altlinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).