From: Herbert Xu <herbert@gondor.apana.org.au>
To: NeilBrown <neilb@suse.com>
Cc: Thomas Graf <tgraf@suug.ch>, Tom Herbert <tom@quantonium.net>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] rhashtable: further improve stability of rhashtable_walk
Date: Fri, 7 Dec 2018 13:39:44 +0800 [thread overview]
Message-ID: <20181207053943.7zacyn5uvqkfnfoi@gondor.apana.org.au> (raw)
In-Reply-To: <87zhtkeimx.fsf@notabene.neil.brown.name>
On Wed, Dec 05, 2018 at 02:51:02PM +1100, NeilBrown wrote:
>
> If the sequence:
> obj = rhashtable_walk_next(iter);
> rhashtable_walk_stop(iter);
> rhashtable_remove_fast(ht, &obj->head, params);
> rhashtable_walk_start(iter);
>
> races with another thread inserting or removing
> an object on the same hash chain, a subsequent
> rhashtable_walk_next() is not guaranteed to get the "next"
> object. It is possible that an object could be
> repeated, or missed.
>
> This can be made more reliable by keeping the objects in a hash chain
> sorted by memory address. A subsequent rhashtable_walk_next()
> call can reliably find the correct position in the list, and thus
> find the 'next' object.
>
> It is not possible to take this approach with an rhltable as keeping
> the hash chain in order is not so easy. When the first object with a
> given key is removed, it is replaced in the chain with the next
> object with the same key, and the address of that object may not be
> correctly ordered.
> I have not yet found any way to achieve the same stability
> with rhltables, that doesn't have a major impact on lookup
> or insert. No code currently in Linux would benefit from
> such extra stability.
>
> With this patch:
> - a new object is always inserted after the last object with a
> smaller address, or at the start.
> - when rhashtable_walk_start() is called, it records that 'p' is not
> 'safe', meaning that it cannot be dereferenced. The revalidation
> that was previously done here is moved to rhashtable_walk_next()
> - when rhashtable_walk_next() is called while p is not NULL and not
> safe, it walks the chain looking for the first object with an
> address greater than p and returns that. If there is none, it moves
> to the next hash chain.
>
> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
>
> This is a resend of a patch that I sent back in July. I couldn't
> applied then because it assumed another rhashtable patch which hadn't
> landed yet - it now has.
I thought we had agreed to drop this because nobody needs it
currently and it doesn't handle rhlist?
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2018-12-07 5:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 7:11 [PATCH 0/3] rhashtable: replace rhashtable_walk_peek implementation NeilBrown
2018-07-06 7:11 ` [PATCH 3/3] rhashtable: implement rhashtable_walk_peek() using rhashtable_walk_last_seen() NeilBrown
2018-07-06 7:11 ` [PATCH 1/3] rhashtable: further improve stability of rhashtable_walk NeilBrown
2018-07-06 8:24 ` kbuild test robot
2018-07-06 9:50 ` NeilBrown
2018-07-06 8:59 ` Paolo Abeni
2018-07-06 9:55 ` NeilBrown
2018-07-06 10:12 ` Paolo Abeni
2018-07-06 9:25 ` kbuild test robot
2018-12-05 3:51 ` [PATCH net-next] " NeilBrown
2018-12-07 5:39 ` Herbert Xu [this message]
2018-12-09 22:50 ` NeilBrown
2018-12-11 5:17 ` Herbert Xu
2018-12-12 0:02 ` NeilBrown
2018-12-12 5:46 ` Herbert Xu
2018-12-12 6:41 ` NeilBrown
2018-12-12 8:00 ` Herbert Xu
2018-12-12 8:49 ` NeilBrown
2018-12-13 1:43 ` Herbert Xu
2018-12-13 3:48 ` NeilBrown
2018-12-13 8:47 ` Herbert Xu
2018-07-06 7:11 ` [PATCH 2/3] rhashtable: add rhashtable_walk_last_seen() NeilBrown
2018-07-10 23:55 ` David Miller
2018-07-15 23:58 ` NeilBrown
2018-07-10 23:55 ` [PATCH 0/3] rhashtable: replace rhashtable_walk_peek implementation David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207053943.7zacyn5uvqkfnfoi@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=tom@quantonium.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).