* [PATCH 0/3] Add ALC294 quirks for ASUS laptops
@ 2018-12-05 7:42 Jian-Hong Pan
2018-12-05 7:42 ` [PATCH 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN Jian-Hong Pan
` (2 more replies)
0 siblings, 3 replies; 21+ messages in thread
From: Jian-Hong Pan @ 2018-12-05 7:42 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai
Cc: Kailang Yang, Hui Wang, alsa-devel, linux-kernel, linux, Jian-Hong Pan
Add Realtek ALC294 quirks for ASUS X542UN, UX533FD and UX433FN laptops.
Chris Chiu (1):
ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN
Jian-Hong Pan (2):
ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294
ALSA: hda/realtek: Enable audio jacks of ASUS UX433FN with ALC294
sound/pci/hda/patch_realtek.c | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
--
2.11.0
^ permalink raw reply [flat|nested] 21+ messages in thread* [PATCH 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN 2018-12-05 7:42 [PATCH 0/3] Add ALC294 quirks for ASUS laptops Jian-Hong Pan @ 2018-12-05 7:42 ` Jian-Hong Pan 2018-12-05 8:36 ` Kailang 2018-12-05 7:42 ` [PATCH 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD " Jian-Hong Pan 2018-12-05 7:42 ` [PATCH 3/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX433FN " Jian-Hong Pan 2 siblings, 1 reply; 21+ messages in thread From: Jian-Hong Pan @ 2018-12-05 7:42 UTC (permalink / raw) To: Jaroslav Kysela, Takashi Iwai Cc: Kailang Yang, Hui Wang, alsa-devel, linux-kernel, linux, Chris Chiu, Jian-Hong Pan, Daniel Drake From: Chris Chiu <chiu@endlessm.com> The known ALC256_FIXUP_ASUS_MIC fixup can fix the headphone jack sensing and enable use of the internal microphone on this laptop X542UN. However, it's ALC294 so create a new fixup named ALC294_FIXUP_ASUS_MIC to avoid confusion. Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com> Signed-off-by: Daniel Drake <drake@endlessm.com> Signed-off-by: Chris Chiu <chiu@endlessm.com> --- sound/pci/hda/patch_realtek.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index bb40624fb6d5..bbae06267054 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5517,6 +5517,7 @@ enum { ALC285_FIXUP_LENOVO_HEADPHONE_NOISE, ALC295_FIXUP_HP_AUTO_MUTE, ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE, + ALC294_FIXUP_ASUS_MIC, }; static const struct hda_fixup alc269_fixups[] = { @@ -6403,6 +6404,16 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_HEADSET_MIC }, + [ALC294_FIXUP_ASUS_MIC] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x13, 0x90a60160 }, /* use as internal mic */ + { 0x19, 0x04a11120 }, /* use as headset mic, without its own jack detect */ + { } + }, + .chained = true, + .chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -7152,6 +7163,10 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { SND_HDA_PIN_QUIRK(0x10ec0293, 0x1028, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE, ALC292_STANDARD_PINS, {0x13, 0x90a60140}), + SND_HDA_PIN_QUIRK(0x10ec0294, 0x1043, "ASUS", ALC294_FIXUP_ASUS_MIC, + {0x14, 0x90170110}, + {0x1b, 0x90a70130}, + {0x21, 0x04211020}), SND_HDA_PIN_QUIRK(0x10ec0295, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE, ALC295_STANDARD_PINS, {0x17, 0x21014020}, -- 2.11.0 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* RE: [PATCH 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN 2018-12-05 7:42 ` [PATCH 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN Jian-Hong Pan @ 2018-12-05 8:36 ` Kailang 2018-12-05 9:33 ` Jian-Hong Pan 0 siblings, 1 reply; 21+ messages in thread From: Kailang @ 2018-12-05 8:36 UTC (permalink / raw) To: Jian-Hong Pan, Jaroslav Kysela, Takashi Iwai Cc: Hui Wang, alsa-devel, linux-kernel, linux, Chris Chiu, Daniel Drake Hi Jian-Hong, Could you test to change the model to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC? .chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE ==> change to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC BR, Kailang -----Original Message----- From: Jian-Hong Pan <jian-hong@endlessm.com> Sent: Wednesday, December 5, 2018 3:42 PM To: Jaroslav Kysela <perex@perex.cz>; Takashi Iwai <tiwai@suse.com> Cc: Kailang <kailang@realtek.com>; Hui Wang <hui.wang@canonical.com>; alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; linux@endlessm.com; Chris Chiu <chiu@endlessm.com>; Jian-Hong Pan <jian-hong@endlessm.com>; Daniel Drake <drake@endlessm.com> Subject: [PATCH 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN From: Chris Chiu <chiu@endlessm.com> The known ALC256_FIXUP_ASUS_MIC fixup can fix the headphone jack sensing and enable use of the internal microphone on this laptop X542UN. However, it's ALC294 so create a new fixup named ALC294_FIXUP_ASUS_MIC to avoid confusion. Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com> Signed-off-by: Daniel Drake <drake@endlessm.com> Signed-off-by: Chris Chiu <chiu@endlessm.com> --- sound/pci/hda/patch_realtek.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index bb40624fb6d5..bbae06267054 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5517,6 +5517,7 @@ enum { ALC285_FIXUP_LENOVO_HEADPHONE_NOISE, ALC295_FIXUP_HP_AUTO_MUTE, ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE, + ALC294_FIXUP_ASUS_MIC, }; static const struct hda_fixup alc269_fixups[] = { @@ -6403,6 +6404,16 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_HEADSET_MIC }, + [ALC294_FIXUP_ASUS_MIC] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x13, 0x90a60160 }, /* use as internal mic */ + { 0x19, 0x04a11120 }, /* use as headset mic, without its own jack detect */ + { } + }, + .chained = true, + .chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -7152,6 +7163,10 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { SND_HDA_PIN_QUIRK(0x10ec0293, 0x1028, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE, ALC292_STANDARD_PINS, {0x13, 0x90a60140}), + SND_HDA_PIN_QUIRK(0x10ec0294, 0x1043, "ASUS", ALC294_FIXUP_ASUS_MIC, + {0x14, 0x90170110}, + {0x1b, 0x90a70130}, + {0x21, 0x04211020}), SND_HDA_PIN_QUIRK(0x10ec0295, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE, ALC295_STANDARD_PINS, {0x17, 0x21014020}, -- 2.11.0 ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN 2018-12-05 8:36 ` Kailang @ 2018-12-05 9:33 ` Jian-Hong Pan 2018-12-05 11:42 ` Kailang 0 siblings, 1 reply; 21+ messages in thread From: Jian-Hong Pan @ 2018-12-05 9:33 UTC (permalink / raw) To: Kailang Yang Cc: Jaroslav Kysela, tiwai, Hui Wang, alsa-devel, Linux Kernel, Linux Upstreaming Team, Chris Chiu, Daniel Drake Kailang <kailang@realtek.com> 於 2018年12月5日 週三 下午4:36寫道： > > Hi Jian-Hong, > > Could you test to change the model to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC? > > .chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE ==> change to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC According to the comment https://patchwork.kernel.org/patch/10713087/#22360253 , should I try ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC on this model? Jian-Hong Pan ^ permalink raw reply [flat|nested] 21+ messages in thread
* RE: [PATCH 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN 2018-12-05 9:33 ` Jian-Hong Pan @ 2018-12-05 11:42 ` Kailang 2018-12-06 8:44 ` Jian-Hong Pan 0 siblings, 1 reply; 21+ messages in thread From: Kailang @ 2018-12-05 11:42 UTC (permalink / raw) To: Jian-Hong Pan Cc: Jaroslav Kysela, tiwai, Hui Wang, alsa-devel, Linux Kernel, Linux Upstreaming Team, Chris Chiu, Daniel Drake No. Don't try ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC model for ALC286 platform. ________________________________________ 從: Jian-Hong Pan [jian-hong@endlessm.com] 寄件日期: 2018年12月5日 下午 05:33 至: Kailang 副本: Jaroslav Kysela; tiwai@suse.com; Hui Wang; alsa-devel@alsa-project.org; Linux Kernel; Linux Upstreaming Team; Chris Chiu; Daniel Drake 主旨: Re: [PATCH 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN Kailang <kailang@realtek.com> 於 2018年12月5日 週三 下午4:36寫道： > > Hi Jian-Hong, > > Could you test to change the model to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC? > > .chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE ==> change to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC According to the comment https://patchwork.kernel.org/patch/10713087/#22360253 , should I try ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC on this model? Jian-Hong Pan ------Please consider the environment before printing this e-mail. ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN 2018-12-05 11:42 ` Kailang @ 2018-12-06 8:44 ` Jian-Hong Pan 2018-12-06 8:45 ` [PATCH v2 0/3] Add ALC294 quirks for ASUS laptops Jian-Hong Pan 0 siblings, 1 reply; 21+ messages in thread From: Jian-Hong Pan @ 2018-12-06 8:44 UTC (permalink / raw) To: Kailang Yang Cc: Jaroslav Kysela, Takashi Iwai, Hui Wang, alsa-devel, Linux Kernel, Linux Upstreaming Team, Chris Chiu, Daniel Drake > Kailang <kailang@realtek.com> 於 2018年12月5日 週三 下午4:36寫道： > > > > Hi Jian-Hong, > > > > Could you test to change the model to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC? > > > > .chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE ==> change to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC We do not have ASUS X542UN in hand right now, but we have ASUS X542UQ which goes with the same quirk as X542UN. I tested with ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC, and it also works. So, I am going to send new patch set using ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC for ALC294. Thanks, Jian-Hong Pan ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v2 0/3] Add ALC294 quirks for ASUS laptops 2018-12-06 8:44 ` Jian-Hong Pan @ 2018-12-06 8:45 ` Jian-Hong Pan 2018-12-06 8:45 ` [PATCH v2 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN Jian-Hong Pan ` (2 more replies) 0 siblings, 3 replies; 21+ messages in thread From: Jian-Hong Pan @ 2018-12-06 8:45 UTC (permalink / raw) To: Jaroslav Kysela, Takashi Iwai, Kailang Yang Cc: Hui Wang, alsa-devel, linux-kernel, linux, Jian-Hong Pan Add Realtek ALC294 quirks for ASUS X542UN, UX533FD, UX433FN and UX333FA laptops. Chris Chiu (1): ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN Jian-Hong Pan (2): ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 ALSA: hda/realtek: Enable audio jacks of ASUS UX433FN/UX333FA with ALC294 sound/pci/hda/patch_realtek.c | 44 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) -- 2.11.0 ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v2 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN 2018-12-06 8:45 ` [PATCH v2 0/3] Add ALC294 quirks for ASUS laptops Jian-Hong Pan @ 2018-12-06 8:45 ` Jian-Hong Pan 2018-12-06 8:45 ` [PATCH v2 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 Jian-Hong Pan 2018-12-06 8:45 ` [PATCH v2 3/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX433FN/UX333FA with ALC294 Jian-Hong Pan 2 siblings, 0 replies; 21+ messages in thread From: Jian-Hong Pan @ 2018-12-06 8:45 UTC (permalink / raw) To: Jaroslav Kysela, Takashi Iwai, Kailang Yang Cc: Hui Wang, alsa-devel, linux-kernel, linux, Chris Chiu, Jian-Hong Pan, Daniel Drake From: Chris Chiu <chiu@endlessm.com> The known ALC256_FIXUP_ASUS_MIC fixup can fix the headphone jack sensing and enable use of the internal microphone on this laptop X542UN. However, it's ALC294 so create a new fixup named ALC294_FIXUP_ASUS_MIC to avoid confusion. Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com> Signed-off-by: Daniel Drake <drake@endlessm.com> Signed-off-by: Chris Chiu <chiu@endlessm.com> --- v2: - .chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE ==> change to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC sound/pci/hda/patch_realtek.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index bb40624fb6d5..d32e50b1ed60 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5517,6 +5517,7 @@ enum { ALC285_FIXUP_LENOVO_HEADPHONE_NOISE, ALC295_FIXUP_HP_AUTO_MUTE, ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE, + ALC294_FIXUP_ASUS_MIC, }; static const struct hda_fixup alc269_fixups[] = { @@ -6403,6 +6404,16 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_HEADSET_MIC }, + [ALC294_FIXUP_ASUS_MIC] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x13, 0x90a60160 }, /* use as internal mic */ + { 0x19, 0x04a11120 }, /* use as headset mic, without its own jack detect */ + { } + }, + .chained = true, + .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -7152,6 +7163,10 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { SND_HDA_PIN_QUIRK(0x10ec0293, 0x1028, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE, ALC292_STANDARD_PINS, {0x13, 0x90a60140}), + SND_HDA_PIN_QUIRK(0x10ec0294, 0x1043, "ASUS", ALC294_FIXUP_ASUS_MIC, + {0x14, 0x90170110}, + {0x1b, 0x90a70130}, + {0x21, 0x04211020}), SND_HDA_PIN_QUIRK(0x10ec0295, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE, ALC295_STANDARD_PINS, {0x17, 0x21014020}, -- 2.11.0 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 2018-12-06 8:45 ` [PATCH v2 0/3] Add ALC294 quirks for ASUS laptops Jian-Hong Pan 2018-12-06 8:45 ` [PATCH v2 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN Jian-Hong Pan @ 2018-12-06 8:45 ` Jian-Hong Pan 2018-12-07 3:31 ` Kailang 2018-12-06 8:45 ` [PATCH v2 3/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX433FN/UX333FA with ALC294 Jian-Hong Pan 2 siblings, 1 reply; 21+ messages in thread From: Jian-Hong Pan @ 2018-12-06 8:45 UTC (permalink / raw) To: Jaroslav Kysela, Takashi Iwai, Kailang Yang Cc: Hui Wang, alsa-devel, linux-kernel, linux, Jian-Hong Pan, Daniel Drake The ASUS UX533FD with ALC294 cannot detect the headset MIC and output through the internal speaker and the headphone until ALC294_FIXUP_ASUS_SPK_NOISE quirk applied. Signed-off-by: Daniel Drake <drake@endlessm.com> Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com> --- v2: - Modify the HDA verbs for UX333FA support - Make a new ALC294_FIXUP_ASUS_HEADSET_MIC quirk for ALC294 chain - .chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE ==> change to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC sound/pci/hda/patch_realtek.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index d32e50b1ed60..1525bcdf96e8 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5518,6 +5518,8 @@ enum { ALC295_FIXUP_HP_AUTO_MUTE, ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE, ALC294_FIXUP_ASUS_MIC, + ALC294_FIXUP_ASUS_HEADSET_MIC, + ALC294_FIXUP_ASUS_SPK_NOISE, }; static const struct hda_fixup alc269_fixups[] = { @@ -6414,6 +6416,28 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC }, + [ALC294_FIXUP_ASUS_HEADSET_MIC] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x19, 0x01a1113c }, /* use as headset mic, without its own jack detect */ + { } + }, + .chained = true, + .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC + }, + [ALC294_FIXUP_ASUS_SPK_NOISE] = { + .type = HDA_FIXUP_VERBS, + .v.verbs = (const struct hda_verb[]) { + /* Set EAPD high */ + { 0x20, AC_VERB_SET_COEF_INDEX, 0x10 }, + { 0x20, 0x4c4, 0x20 }, + { 0x20, AC_VERB_SET_COEF_INDEX, 0x40 }, + { 0x20, 0x488, 0x00 }, + { } + }, + .chained = true, + .chain_id = ALC294_FIXUP_ASUS_HEADSET_MIC + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -6556,6 +6580,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1043, 0x12e0, "ASUS X541SA", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x13b0, "ASUS Z550SA", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXUP_ASUS_ZENBOOK), + SND_PCI_QUIRK(0x1043, 0x14a1, "ASUS UX533FD", ALC294_FIXUP_ASUS_SPK_NOISE), SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC), SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW), -- 2.11.0 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* RE: [PATCH v2 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 2018-12-06 8:45 ` [PATCH v2 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 Jian-Hong Pan @ 2018-12-07 3:31 ` Kailang 2018-12-07 3:48 ` Jian-Hong Pan 0 siblings, 1 reply; 21+ messages in thread From: Kailang @ 2018-12-07 3:31 UTC (permalink / raw) To: Jian-Hong Pan, Jaroslav Kysela, Takashi Iwai Cc: Hui Wang, alsa-devel, linux-kernel, linux, Daniel Drake Hi Jian Hong, Could I know who give you the value as below? + { 0x20, AC_VERB_SET_COEF_INDEX, 0x10 }, + { 0x20, 0x4c4, 0x20 }, + { 0x20, AC_VERB_SET_COEF_INDEX, 0x40 }, + { 0x20, 0x488, 0x00 }, BR, Kailang -----Original Message----- From: Jian-Hong Pan <jian-hong@endlessm.com> Sent: Thursday, December 6, 2018 4:46 PM To: Jaroslav Kysela <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>; Kailang <kailang@realtek.com> Cc: Hui Wang <hui.wang@canonical.com>; alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; linux@endlessm.com; Jian-Hong Pan <jian-hong@endlessm.com>; Daniel Drake <drake@endlessm.com> Subject: [PATCH v2 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 The ASUS UX533FD with ALC294 cannot detect the headset MIC and output through the internal speaker and the headphone until ALC294_FIXUP_ASUS_SPK_NOISE quirk applied. Signed-off-by: Daniel Drake <drake@endlessm.com> Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com> --- v2: - Modify the HDA verbs for UX333FA support - Make a new ALC294_FIXUP_ASUS_HEADSET_MIC quirk for ALC294 chain - .chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE ==> change to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC sound/pci/hda/patch_realtek.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index d32e50b1ed60..1525bcdf96e8 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5518,6 +5518,8 @@ enum { ALC295_FIXUP_HP_AUTO_MUTE, ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE, ALC294_FIXUP_ASUS_MIC, + ALC294_FIXUP_ASUS_HEADSET_MIC, + ALC294_FIXUP_ASUS_SPK_NOISE, }; static const struct hda_fixup alc269_fixups[] = { @@ -6414,6 +6416,28 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC }, + [ALC294_FIXUP_ASUS_HEADSET_MIC] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x19, 0x01a1113c }, /* use as headset mic, without its own jack detect */ + { } + }, + .chained = true, + .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC + }, + [ALC294_FIXUP_ASUS_SPK_NOISE] = { + .type = HDA_FIXUP_VERBS, + .v.verbs = (const struct hda_verb[]) { + /* Set EAPD high */ + { 0x20, AC_VERB_SET_COEF_INDEX, 0x10 }, + { 0x20, 0x4c4, 0x20 }, + { 0x20, AC_VERB_SET_COEF_INDEX, 0x40 }, + { 0x20, 0x488, 0x00 }, + { } + }, + .chained = true, + .chain_id = ALC294_FIXUP_ASUS_HEADSET_MIC + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -6556,6 +6580,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1043, 0x12e0, "ASUS X541SA", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x13b0, "ASUS Z550SA", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXUP_ASUS_ZENBOOK), + SND_PCI_QUIRK(0x1043, 0x14a1, "ASUS UX533FD", +ALC294_FIXUP_ASUS_SPK_NOISE), SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC), SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW), -- 2.11.0 ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 2018-12-07 3:31 ` Kailang @ 2018-12-07 3:48 ` Jian-Hong Pan 2018-12-07 6:52 ` Kailang 0 siblings, 1 reply; 21+ messages in thread From: Jian-Hong Pan @ 2018-12-07 3:48 UTC (permalink / raw) To: Kailang Yang Cc: Jaroslav Kysela, Takashi Iwai, Hui Wang, alsa-devel, Linux Kernel, Linux Upstreaming Team, Daniel Drake Kailang <kailang@realtek.com> 於 2018年12月7日 週五 上午11:32寫道： > > Hi Jian Hong, > > Could I know who give you the value as below? > > + { 0x20, AC_VERB_SET_COEF_INDEX, 0x10 }, > + { 0x20, 0x4c4, 0x20 }, > + { 0x20, AC_VERB_SET_COEF_INDEX, 0x40 }, > + { 0x20, 0x488, 0x00 }, A module maker. Regards, Jian-Hong Pan > -----Original Message----- > From: Jian-Hong Pan <jian-hong@endlessm.com> > Sent: Thursday, December 6, 2018 4:46 PM > To: Jaroslav Kysela <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>; Kailang <kailang@realtek.com> > Cc: Hui Wang <hui.wang@canonical.com>; alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; linux@endlessm.com; Jian-Hong Pan <jian-hong@endlessm.com>; Daniel Drake <drake@endlessm.com> > Subject: [PATCH v2 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 > > The ASUS UX533FD with ALC294 cannot detect the headset MIC and output through the internal speaker and the headphone until ALC294_FIXUP_ASUS_SPK_NOISE quirk applied. > > Signed-off-by: Daniel Drake <drake@endlessm.com> > Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com> > --- > v2: > - Modify the HDA verbs for UX333FA support > - Make a new ALC294_FIXUP_ASUS_HEADSET_MIC quirk for ALC294 chain > - .chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE ==> change to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC > > sound/pci/hda/patch_realtek.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index d32e50b1ed60..1525bcdf96e8 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -5518,6 +5518,8 @@ enum { > ALC295_FIXUP_HP_AUTO_MUTE, > ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE, > ALC294_FIXUP_ASUS_MIC, > + ALC294_FIXUP_ASUS_HEADSET_MIC, > + ALC294_FIXUP_ASUS_SPK_NOISE, > }; > > static const struct hda_fixup alc269_fixups[] = { @@ -6414,6 +6416,28 @@ static const struct hda_fixup alc269_fixups[] = { > .chained = true, > .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC > }, > + [ALC294_FIXUP_ASUS_HEADSET_MIC] = { > + .type = HDA_FIXUP_PINS, > + .v.pins = (const struct hda_pintbl[]) { > + { 0x19, 0x01a1113c }, /* use as headset mic, without its own jack detect */ > + { } > + }, > + .chained = true, > + .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC > + }, > + [ALC294_FIXUP_ASUS_SPK_NOISE] = { > + .type = HDA_FIXUP_VERBS, > + .v.verbs = (const struct hda_verb[]) { > + /* Set EAPD high */ > + { 0x20, AC_VERB_SET_COEF_INDEX, 0x10 }, > + { 0x20, 0x4c4, 0x20 }, > + { 0x20, AC_VERB_SET_COEF_INDEX, 0x40 }, > + { 0x20, 0x488, 0x00 }, > + { } > + }, > + .chained = true, > + .chain_id = ALC294_FIXUP_ASUS_HEADSET_MIC > + }, > }; > > static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -6556,6 +6580,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1043, 0x12e0, "ASUS X541SA", ALC256_FIXUP_ASUS_MIC), > SND_PCI_QUIRK(0x1043, 0x13b0, "ASUS Z550SA", ALC256_FIXUP_ASUS_MIC), > SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXUP_ASUS_ZENBOOK), > + SND_PCI_QUIRK(0x1043, 0x14a1, "ASUS UX533FD", > +ALC294_FIXUP_ASUS_SPK_NOISE), > SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), > SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC), > SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW), > -- > 2.11.0 > ^ permalink raw reply [flat|nested] 21+ messages in thread
* RE: [PATCH v2 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 2018-12-07 3:48 ` Jian-Hong Pan @ 2018-12-07 6:52 ` Kailang 2018-12-07 9:13 ` Jian-Hong Pan 0 siblings, 1 reply; 21+ messages in thread From: Kailang @ 2018-12-07 6:52 UTC (permalink / raw) To: Jian-Hong Pan Cc: Jaroslav Kysela, Takashi Iwai, Hui Wang, alsa-devel, Linux Kernel, Linux Upstreaming Team, Daniel Drake, josh Hi Jian Hong, I call our agent guy @ WTMEC. Please modify as bellowing then test again. Remove EAPD control by hidden. If this modify patch was pass audio test, please regenerate patch to Takashi. If this patch will solve the speaker no sound issue, I think the model name maybe could rename to ALC294_FIXUP_ASUS_SPK. Because it doesn't relate with Noise. > + [ALC294_FIXUP_ASUS_SPK_NOISE] = { > + .type = HDA_FIXUP_VERBS, > + .v.verbs = (const struct hda_verb[]) { > + { 0x20, AC_VERB_SET_COEF_INDEX, 0x40 }, > + { 0x20, AC_VERB_SET_PROC_COEF, 0x8800 }, > + { } > + }, > + .chained = true, > + .chain_id = ALC294_FIXUP_ASUS_HEADSET_MIC > + }, > }; BR, Kailang -----Original Message----- From: Jian-Hong Pan <jian-hong@endlessm.com> Sent: Friday, December 7, 2018 11:48 AM To: Kailang <kailang@realtek.com> Cc: Jaroslav Kysela <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>; Hui Wang <hui.wang@canonical.com>; alsa-devel@alsa-project.org; Linux Kernel <linux-kernel@vger.kernel.org>; Linux Upstreaming Team <linux@endlessm.com>; Daniel Drake <drake@endlessm.com> Subject: Re: [PATCH v2 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 Kailang <kailang@realtek.com> 於 2018年12月7日 週五 上午11:32寫道： > > Hi Jian Hong, > > Could I know who give you the value as below? > > + { 0x20, AC_VERB_SET_COEF_INDEX, 0x10 }, > + { 0x20, 0x4c4, 0x20 }, > + { 0x20, AC_VERB_SET_COEF_INDEX, 0x40 }, > + { 0x20, 0x488, 0x00 }, A module maker. Regards, Jian-Hong Pan > -----Original Message----- > From: Jian-Hong Pan <jian-hong@endlessm.com> > Sent: Thursday, December 6, 2018 4:46 PM > To: Jaroslav Kysela <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>; > Kailang <kailang@realtek.com> > Cc: Hui Wang <hui.wang@canonical.com>; alsa-devel@alsa-project.org; > linux-kernel@vger.kernel.org; linux@endlessm.com; Jian-Hong Pan > <jian-hong@endlessm.com>; Daniel Drake <drake@endlessm.com> > Subject: [PATCH v2 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS > UX533FD with ALC294 > > The ASUS UX533FD with ALC294 cannot detect the headset MIC and output through the internal speaker and the headphone until ALC294_FIXUP_ASUS_SPK_NOISE quirk applied. > > Signed-off-by: Daniel Drake <drake@endlessm.com> > Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com> > --- > v2: > - Modify the HDA verbs for UX333FA support > - Make a new ALC294_FIXUP_ASUS_HEADSET_MIC quirk for ALC294 chain > - .chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE ==> change to > ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC > > sound/pci/hda/patch_realtek.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c > b/sound/pci/hda/patch_realtek.c index d32e50b1ed60..1525bcdf96e8 > 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -5518,6 +5518,8 @@ enum { > ALC295_FIXUP_HP_AUTO_MUTE, > ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE, > ALC294_FIXUP_ASUS_MIC, > + ALC294_FIXUP_ASUS_HEADSET_MIC, > + ALC294_FIXUP_ASUS_SPK_NOISE, > }; > > static const struct hda_fixup alc269_fixups[] = { @@ -6414,6 +6416,28 @@ static const struct hda_fixup alc269_fixups[] = { > .chained = true, > .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC > }, > + [ALC294_FIXUP_ASUS_HEADSET_MIC] = { > + .type = HDA_FIXUP_PINS, > + .v.pins = (const struct hda_pintbl[]) { > + { 0x19, 0x01a1113c }, /* use as headset mic, without its own jack detect */ > + { } > + }, > + .chained = true, > + .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC > + }, > + [ALC294_FIXUP_ASUS_SPK_NOISE] = { > + .type = HDA_FIXUP_VERBS, > + .v.verbs = (const struct hda_verb[]) { > + /* Set EAPD high */ > + { 0x20, AC_VERB_SET_COEF_INDEX, 0x10 }, > + { 0x20, 0x4c4, 0x20 }, > + { 0x20, AC_VERB_SET_COEF_INDEX, 0x40 }, > + { 0x20, 0x488, 0x00 }, > + { } > + }, > + .chained = true, > + .chain_id = ALC294_FIXUP_ASUS_HEADSET_MIC > + }, > }; > > static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -6556,6 +6580,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1043, 0x12e0, "ASUS X541SA", ALC256_FIXUP_ASUS_MIC), > SND_PCI_QUIRK(0x1043, 0x13b0, "ASUS Z550SA", ALC256_FIXUP_ASUS_MIC), > SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", > ALC269VB_FIXUP_ASUS_ZENBOOK), > + SND_PCI_QUIRK(0x1043, 0x14a1, "ASUS UX533FD", > +ALC294_FIXUP_ASUS_SPK_NOISE), > SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), > SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC), > SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", > ALC269_FIXUP_ASUS_G73JW), > -- > 2.11.0 > ------Please consider the environment before printing this e-mail. ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 2018-12-07 6:52 ` Kailang @ 2018-12-07 9:13 ` Jian-Hong Pan 2018-12-07 9:17 ` [PATCH v3 0/3] Add ALC294 quirks for ASUS laptops Jian-Hong Pan 0 siblings, 1 reply; 21+ messages in thread From: Jian-Hong Pan @ 2018-12-07 9:13 UTC (permalink / raw) To: Kailang Yang Cc: Jaroslav Kysela, Takashi Iwai, Hui Wang, alsa-devel, Linux Kernel, Linux Upstreaming Team, Daniel Drake, josh > Hi Jian Hong, > > I call our agent guy @ WTMEC. > Please modify as bellowing then test again. > Remove EAPD control by hidden. > If this modify patch was pass audio test, please regenerate patch to Takashi. > If this patch will solve the speaker no sound issue, I think the model name maybe could rename to ALC294_FIXUP_ASUS_SPK. > Because it doesn't relate with Noise. > > > + [ALC294_FIXUP_ASUS_SPK_NOISE] = { > > + .type = HDA_FIXUP_VERBS, > > + .v.verbs = (const struct hda_verb[]) { > > + { 0x20, AC_VERB_SET_COEF_INDEX, 0x40 }, > > + { 0x20, AC_VERB_SET_PROC_COEF, 0x8800 }, > > + { } > > + }, > > + .chained = true, > > + .chain_id = ALC294_FIXUP_ASUS_HEADSET_MIC > > + }, > > }; > Thanks for the help! I have tried the new verbs, and they work on the laptops. I am going to send the new patches. Regards, Jian-Hong Pan ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v3 0/3] Add ALC294 quirks for ASUS laptops 2018-12-07 9:13 ` Jian-Hong Pan @ 2018-12-07 9:17 ` Jian-Hong Pan 2018-12-07 9:17 ` [PATCH v3 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN Jian-Hong Pan ` (3 more replies) 0 siblings, 4 replies; 21+ messages in thread From: Jian-Hong Pan @ 2018-12-07 9:17 UTC (permalink / raw) To: Jaroslav Kysela, Takashi Iwai, Kailang Yang Cc: Hui Wang, alsa-devel, linux-kernel, linux, josh, Jian-Hong Pan Add Realtek ALC294 quirks for ASUS X542UN, UX533FD, UX433FN and UX333FA laptops. Chris Chiu (1): ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN Jian-Hong Pan (2): ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 ALSA: hda/realtek: Enable audio jacks of ASUS UX433FN/UX333FA with ALC294 sound/pci/hda/patch_realtek.c | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) -- 2.11.0 ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v3 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN 2018-12-07 9:17 ` [PATCH v3 0/3] Add ALC294 quirks for ASUS laptops Jian-Hong Pan @ 2018-12-07 9:17 ` Jian-Hong Pan 2018-12-07 9:17 ` [PATCH v3 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 Jian-Hong Pan ` (2 subsequent siblings) 3 siblings, 0 replies; 21+ messages in thread From: Jian-Hong Pan @ 2018-12-07 9:17 UTC (permalink / raw) To: Jaroslav Kysela, Takashi Iwai, Kailang Yang Cc: Hui Wang, alsa-devel, linux-kernel, linux, josh, Chris Chiu, Jian-Hong Pan, Daniel Drake From: Chris Chiu <chiu@endlessm.com> The known ALC256_FIXUP_ASUS_MIC fixup can fix the headphone jack sensing and enable use of the internal microphone on this laptop X542UN. However, it's ALC294 so create a new fixup named ALC294_FIXUP_ASUS_MIC to avoid confusion. Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com> Signed-off-by: Daniel Drake <drake@endlessm.com> Signed-off-by: Chris Chiu <chiu@endlessm.com> --- v2: - .chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE ==> change to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC sound/pci/hda/patch_realtek.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index bb40624fb6d5..d32e50b1ed60 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5517,6 +5517,7 @@ enum { ALC285_FIXUP_LENOVO_HEADPHONE_NOISE, ALC295_FIXUP_HP_AUTO_MUTE, ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE, + ALC294_FIXUP_ASUS_MIC, }; static const struct hda_fixup alc269_fixups[] = { @@ -6403,6 +6404,16 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_HEADSET_MIC }, + [ALC294_FIXUP_ASUS_MIC] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x13, 0x90a60160 }, /* use as internal mic */ + { 0x19, 0x04a11120 }, /* use as headset mic, without its own jack detect */ + { } + }, + .chained = true, + .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -7152,6 +7163,10 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { SND_HDA_PIN_QUIRK(0x10ec0293, 0x1028, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE, ALC292_STANDARD_PINS, {0x13, 0x90a60140}), + SND_HDA_PIN_QUIRK(0x10ec0294, 0x1043, "ASUS", ALC294_FIXUP_ASUS_MIC, + {0x14, 0x90170110}, + {0x1b, 0x90a70130}, + {0x21, 0x04211020}), SND_HDA_PIN_QUIRK(0x10ec0295, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE, ALC295_STANDARD_PINS, {0x17, 0x21014020}, -- 2.11.0 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v3 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 2018-12-07 9:17 ` [PATCH v3 0/3] Add ALC294 quirks for ASUS laptops Jian-Hong Pan 2018-12-07 9:17 ` [PATCH v3 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN Jian-Hong Pan @ 2018-12-07 9:17 ` Jian-Hong Pan 2018-12-07 9:17 ` [PATCH v3 3/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX433FN/UX333FA " Jian-Hong Pan 2018-12-10 10:27 ` [PATCH v3 0/3] Add ALC294 quirks for ASUS laptops Takashi Iwai 3 siblings, 0 replies; 21+ messages in thread From: Jian-Hong Pan @ 2018-12-07 9:17 UTC (permalink / raw) To: Jaroslav Kysela, Takashi Iwai, Kailang Yang Cc: Hui Wang, alsa-devel, linux-kernel, linux, josh, Jian-Hong Pan, Daniel Drake The ASUS UX533FD with ALC294 cannot detect the headset MIC and outputs through the internal speaker and the headphone until ALC294_FIXUP_ASUS_SPK and ALC294_FIXUP_ASUS_HEADSET_MIC quirk applied. Signed-off-by: Daniel Drake <drake@endlessm.com> Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com> --- v2: - Modify the HDA verbs for UX333FA support - Make a new ALC294_FIXUP_ASUS_HEADSET_MIC quirk for ALC294 chain - .chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE ==> change to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC v3: - Modify the HDA verbs from Realtek's suggestion - Modify the quirk's entry name sound/pci/hda/patch_realtek.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index d32e50b1ed60..aa7aabd6e09a 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5518,6 +5518,8 @@ enum { ALC295_FIXUP_HP_AUTO_MUTE, ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE, ALC294_FIXUP_ASUS_MIC, + ALC294_FIXUP_ASUS_HEADSET_MIC, + ALC294_FIXUP_ASUS_SPK, }; static const struct hda_fixup alc269_fixups[] = { @@ -6414,6 +6416,26 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC }, + [ALC294_FIXUP_ASUS_HEADSET_MIC] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x19, 0x01a1113c }, /* use as headset mic, without its own jack detect */ + { } + }, + .chained = true, + .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC + }, + [ALC294_FIXUP_ASUS_SPK] = { + .type = HDA_FIXUP_VERBS, + .v.verbs = (const struct hda_verb[]) { + /* Set EAPD high */ + { 0x20, AC_VERB_SET_COEF_INDEX, 0x40 }, + { 0x20, AC_VERB_SET_PROC_COEF, 0x8800 }, + { } + }, + .chained = true, + .chain_id = ALC294_FIXUP_ASUS_HEADSET_MIC + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -6556,6 +6578,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1043, 0x12e0, "ASUS X541SA", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x13b0, "ASUS Z550SA", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXUP_ASUS_ZENBOOK), + SND_PCI_QUIRK(0x1043, 0x14a1, "ASUS UX533FD", ALC294_FIXUP_ASUS_SPK), SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC), SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW), -- 2.11.0 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v3 3/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX433FN/UX333FA with ALC294 2018-12-07 9:17 ` [PATCH v3 0/3] Add ALC294 quirks for ASUS laptops Jian-Hong Pan 2018-12-07 9:17 ` [PATCH v3 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN Jian-Hong Pan 2018-12-07 9:17 ` [PATCH v3 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 Jian-Hong Pan @ 2018-12-07 9:17 ` Jian-Hong Pan 2018-12-10 10:27 ` [PATCH v3 0/3] Add ALC294 quirks for ASUS laptops Takashi Iwai 3 siblings, 0 replies; 21+ messages in thread From: Jian-Hong Pan @ 2018-12-07 9:17 UTC (permalink / raw) To: Jaroslav Kysela, Takashi Iwai, Kailang Yang Cc: Hui Wang, alsa-devel, linux-kernel, linux, josh, Jian-Hong Pan, Daniel Drake The ASUS UX433FN and UX333FA with ALC294 cannot detect the headset MIC and output through the internal speaker and the headphone until ALC294_FIXUP_ASUS_SPK and ALC294_FIXUP_ASUS_HEADSET_MIC quirk applied. Signed-off-by: Daniel Drake <drake@endlessm.com> Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com> --- v2: - Add UX333FA support. ASUS UX533FD, UX433FN and UX333FA use the same quirk now. v3: - Modify the quirk's entry name sound/pci/hda/patch_realtek.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index aa7aabd6e09a..14c883a16290 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -7190,6 +7190,10 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { {0x14, 0x90170110}, {0x1b, 0x90a70130}, {0x21, 0x04211020}), + SND_HDA_PIN_QUIRK(0x10ec0294, 0x1043, "ASUS", ALC294_FIXUP_ASUS_SPK, + {0x12, 0x90a60130}, + {0x17, 0x90170110}, + {0x21, 0x04211020}), SND_HDA_PIN_QUIRK(0x10ec0295, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE, ALC295_STANDARD_PINS, {0x17, 0x21014020}, -- 2.11.0 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH v3 0/3] Add ALC294 quirks for ASUS laptops 2018-12-07 9:17 ` [PATCH v3 0/3] Add ALC294 quirks for ASUS laptops Jian-Hong Pan ` (2 preceding siblings ...) 2018-12-07 9:17 ` [PATCH v3 3/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX433FN/UX333FA " Jian-Hong Pan @ 2018-12-10 10:27 ` Takashi Iwai 3 siblings, 0 replies; 21+ messages in thread From: Takashi Iwai @ 2018-12-10 10:27 UTC (permalink / raw) To: Jian-Hong Pan Cc: Jaroslav Kysela, Kailang Yang, alsa-devel, Hui Wang, linux, linux-kernel, josh On Fri, 07 Dec 2018 10:17:10 +0100, Jian-Hong Pan wrote: > > Add Realtek ALC294 quirks for ASUS X542UN, UX533FD, UX433FN and UX333FA laptops. > > Chris Chiu (1): > ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN > > Jian-Hong Pan (2): > ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 > ALSA: hda/realtek: Enable audio jacks of ASUS UX433FN/UX333FA with > ALC294 Now applied all three patches. Thanks. Takashi ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v2 3/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX433FN/UX333FA with ALC294 2018-12-06 8:45 ` [PATCH v2 0/3] Add ALC294 quirks for ASUS laptops Jian-Hong Pan 2018-12-06 8:45 ` [PATCH v2 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN Jian-Hong Pan 2018-12-06 8:45 ` [PATCH v2 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 Jian-Hong Pan @ 2018-12-06 8:45 ` Jian-Hong Pan 2 siblings, 0 replies; 21+ messages in thread From: Jian-Hong Pan @ 2018-12-06 8:45 UTC (permalink / raw) To: Jaroslav Kysela, Takashi Iwai, Kailang Yang Cc: Hui Wang, alsa-devel, linux-kernel, linux, Jian-Hong Pan, Daniel Drake The ASUS UX433FN and UX333FA with ALC294 cannot detect the headset MIC and output through the internal speaker and the headphone until ALC294_FIXUP_ASUS_SPK_NOISE quirk applied. Signed-off-by: Daniel Drake <drake@endlessm.com> Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com> --- v2: - Add UX333FA support. ASUS UX533FD, UX433FN and UX333FA use the same quirk now. sound/pci/hda/patch_realtek.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 1525bcdf96e8..97d1a4aaeccd 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -7192,6 +7192,10 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { {0x14, 0x90170110}, {0x1b, 0x90a70130}, {0x21, 0x04211020}), + SND_HDA_PIN_QUIRK(0x10ec0294, 0x1043, "ASUS", ALC294_FIXUP_ASUS_SPK_NOISE, + {0x12, 0x90a60130}, + {0x17, 0x90170110}, + {0x21, 0x04211020}), SND_HDA_PIN_QUIRK(0x10ec0295, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE, ALC295_STANDARD_PINS, {0x17, 0x21014020}, -- 2.11.0 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 2018-12-05 7:42 [PATCH 0/3] Add ALC294 quirks for ASUS laptops Jian-Hong Pan 2018-12-05 7:42 ` [PATCH 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN Jian-Hong Pan @ 2018-12-05 7:42 ` Jian-Hong Pan 2018-12-05 7:42 ` [PATCH 3/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX433FN " Jian-Hong Pan 2 siblings, 0 replies; 21+ messages in thread From: Jian-Hong Pan @ 2018-12-05 7:42 UTC (permalink / raw) To: Jaroslav Kysela, Takashi Iwai Cc: Kailang Yang, Hui Wang, alsa-devel, linux-kernel, linux, Jian-Hong Pan, Daniel Drake The ASUS UX533FD with ALC294 cannot detect the headset MIC and output through the internal speaker and the headphone until ALC294_FIXUP_ASUS_SPK_NOISE quirk applied. Signed-off-by: Daniel Drake <drake@endlessm.com> Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com> --- sound/pci/hda/patch_realtek.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index bbae06267054..5c25c8c3f703 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5518,6 +5518,7 @@ enum { ALC295_FIXUP_HP_AUTO_MUTE, ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE, ALC294_FIXUP_ASUS_MIC, + ALC294_FIXUP_ASUS_SPK_NOISE, }; static const struct hda_fixup alc269_fixups[] = { @@ -6414,6 +6415,17 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE }, + [ALC294_FIXUP_ASUS_SPK_NOISE] = { + .type = HDA_FIXUP_VERBS, + .v.verbs = (const struct hda_verb[]) { + /* Set EAPD high */ + {0x20, AC_VERB_SET_COEF_INDEX, 0x10}, + {0x20, AC_VERB_SET_PROC_COEF, 0x14}, + {} + }, + .chained = true, + .chain_id = ALC255_FIXUP_ASUS_MIC_NO_PRESENCE + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -6556,6 +6568,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1043, 0x12e0, "ASUS X541SA", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x13b0, "ASUS Z550SA", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXUP_ASUS_ZENBOOK), + SND_PCI_QUIRK(0x1043, 0x14a1, "ASUS UX533FD", ALC294_FIXUP_ASUS_SPK_NOISE), SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC), SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW), -- 2.11.0 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 3/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX433FN with ALC294 2018-12-05 7:42 [PATCH 0/3] Add ALC294 quirks for ASUS laptops Jian-Hong Pan 2018-12-05 7:42 ` [PATCH 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN Jian-Hong Pan 2018-12-05 7:42 ` [PATCH 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD " Jian-Hong Pan @ 2018-12-05 7:42 ` Jian-Hong Pan 2 siblings, 0 replies; 21+ messages in thread From: Jian-Hong Pan @ 2018-12-05 7:42 UTC (permalink / raw) To: Jaroslav Kysela, Takashi Iwai Cc: Kailang Yang, Hui Wang, alsa-devel, linux-kernel, linux, Jian-Hong Pan, Daniel Drake The ASUS UX433FN with ALC294 cannot detect the headset MIC and output through the internal speaker and the headphone until ALC294_FIXUP_ASUS_SPK_NOISE quirk applied. Signed-off-by: Daniel Drake <drake@endlessm.com> Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com> --- sound/pci/hda/patch_realtek.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 5c25c8c3f703..56925140bfe6 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -7180,6 +7180,10 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { {0x14, 0x90170110}, {0x1b, 0x90a70130}, {0x21, 0x04211020}), + SND_HDA_PIN_QUIRK(0x10ec0294, 0x1043, "ASUS", ALC294_FIXUP_ASUS_SPK_NOISE, + {0x12, 0x90a60130}, + {0x17, 0x90170110}, + {0x21, 0x04211020}), SND_HDA_PIN_QUIRK(0x10ec0295, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE, ALC295_STANDARD_PINS, {0x17, 0x21014020}, -- 2.11.0 ^ permalink raw reply related [flat|nested] 21+ messages in thread
end of thread, other threads:[~2018-12-10 10:27 UTC | newest] Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-12-05 7:42 [PATCH 0/3] Add ALC294 quirks for ASUS laptops Jian-Hong Pan 2018-12-05 7:42 ` [PATCH 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN Jian-Hong Pan 2018-12-05 8:36 ` Kailang 2018-12-05 9:33 ` Jian-Hong Pan 2018-12-05 11:42 ` Kailang 2018-12-06 8:44 ` Jian-Hong Pan 2018-12-06 8:45 ` [PATCH v2 0/3] Add ALC294 quirks for ASUS laptops Jian-Hong Pan 2018-12-06 8:45 ` [PATCH v2 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN Jian-Hong Pan 2018-12-06 8:45 ` [PATCH v2 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 Jian-Hong Pan 2018-12-07 3:31 ` Kailang 2018-12-07 3:48 ` Jian-Hong Pan 2018-12-07 6:52 ` Kailang 2018-12-07 9:13 ` Jian-Hong Pan 2018-12-07 9:17 ` [PATCH v3 0/3] Add ALC294 quirks for ASUS laptops Jian-Hong Pan 2018-12-07 9:17 ` [PATCH v3 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN Jian-Hong Pan 2018-12-07 9:17 ` [PATCH v3 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 Jian-Hong Pan 2018-12-07 9:17 ` [PATCH v3 3/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX433FN/UX333FA " Jian-Hong Pan 2018-12-10 10:27 ` [PATCH v3 0/3] Add ALC294 quirks for ASUS laptops Takashi Iwai 2018-12-06 8:45 ` [PATCH v2 3/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX433FN/UX333FA with ALC294 Jian-Hong Pan 2018-12-05 7:42 ` [PATCH 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD " Jian-Hong Pan 2018-12-05 7:42 ` [PATCH 3/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX433FN " Jian-Hong Pan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).