From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DB96C07E85 for ; Fri, 7 Dec 2018 11:46:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 425A62083D for ; Fri, 7 Dec 2018 11:46:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="unwm1oiN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 425A62083D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726088AbeLGLqZ (ORCPT ); Fri, 7 Dec 2018 06:46:25 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:44689 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725985AbeLGLqY (ORCPT ); Fri, 7 Dec 2018 06:46:24 -0500 Received: by mail-ed1-f65.google.com with SMTP id y56so3441676edd.11; Fri, 07 Dec 2018 03:46:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YQVhFedNKIcX5C3M5v5vQqKHdNP/jZsJfdiEpUfk9TY=; b=unwm1oiNV0qsga6ccKGjCKGz0OxyZIlSrEsBMJLbsHBIrzMURBAnWlOvVyt996/mkT ZnItnTo8zwkLCXJsl1dCGaDxBIdbBs26EIs5IpVwj7DvrSuYHEuElZ2v3DIaRmJnuFH5 saNSb12WbBJF8I6ZJqCyr54wpu8D3buBEyGp5geSGyi3pq4ffW8DtUXzlLxAh452cD/V jTcxfk6Mavf0KnR2fgvIdHlZD2vpdO4LtGEj283LWgvNMyGPSf8H5DyoIta3xZywUmLS t4mo+nf7XY3XkMr7qzNKQ0U5yFOMpQHK9ruPfDthlbPHqIjfbO2/j3UuxZj+MAkt8Gav ZP4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YQVhFedNKIcX5C3M5v5vQqKHdNP/jZsJfdiEpUfk9TY=; b=WezNuCf1QO/pJXGAvHieBA5Kb3/79mKV3gDajIB4i+oIhSFtMHh1UoiQ1bPUPuYtQA C8KrAub4GK0WBGCu5ZeKluS+bgumimSyAFtA2dMedgSpz+wnvhAkpglY9gxqyeZi1oaF aSy+YokJT1jUKSwX8+iuN1brcYfNz6Is0c/m8J/HYlB7UWvKNJXhhDd3JdXB2ewEd3G6 68LosJPEgQ0rjIucHVG4Wl2VDqN5qyh0ect67diVHF6uYafFBzIRIO7AT2Kd5fUxc/4b 1mkcPA0iu1yB7CDCdBF7+h8CYRMG7zd71GR1QTWg9Rb72xvASvpIcMXwLnIjyAXmneyw Ed4A== X-Gm-Message-State: AA+aEWYHREUrLPkmwGA/q6TZHSHxIi+VPu7VHPpru0CyKz0xFXxyRJ40 iXksFn57nYE4e8EpPE1UO0Rd93vL X-Google-Smtp-Source: AFSGD/UDeWLELCLWfio77QCnXgRqEs8Reu7HKw/dY9SGWtrTthPC7tEuJ1HFxtKw7Vb7GdLvJvq5nw== X-Received: by 2002:a17:906:12d3:: with SMTP id l19-v6mr1722572ejb.74.1544183181719; Fri, 07 Dec 2018 03:46:21 -0800 (PST) Received: from localhost (pD9E51040.dip0.t-ipconnect.de. [217.229.16.64]) by smtp.gmail.com with ESMTPSA id 13-v6sm505342ejx.39.2018.12.07.03.46.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Dec 2018 03:46:21 -0800 (PST) Date: Fri, 7 Dec 2018 12:46:19 +0100 From: Thierry Reding To: Rob Herring Cc: devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Sean Hudson , Frank Rowand , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linuxppc-dev , Grant Likely , Kumar Gala , ARM-SoC Maintainers , Mark Rutland , Jon Hunter , linux-tegra@vger.kernel.org Subject: Re: [PATCH v2 30/34] dt-bindings: arm: Convert Tegra board/soc bindings to json-schema Message-ID: <20181207114619.GB30719@ulmo> References: <20181203213223.16986-1-robh@kernel.org> <20181203213223.16986-31-robh@kernel.org> <20181204085022.GB25962@ulmo> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="61jdw2sOBCFtR2d/" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --61jdw2sOBCFtR2d/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 06, 2018 at 04:38:44PM -0600, Rob Herring wrote: > On Tue, Dec 4, 2018 at 2:50 AM Thierry Reding = wrote: > > > > On Mon, Dec 03, 2018 at 03:32:19PM -0600, Rob Herring wrote: > > > Convert Tegra SoC bindings to DT schema format using json-schema. > > > > > > Cc: Mark Rutland > > > Cc: Thierry Reding > > > Cc: Jonathan Hunter > > > Cc: devicetree@vger.kernel.org > > > Cc: linux-tegra@vger.kernel.org > > > Signed-off-by: Rob Herring > > > --- > > > .../devicetree/bindings/arm/tegra.txt | 65 ----------- > > > .../devicetree/bindings/arm/tegra.yaml | 101 ++++++++++++++++= ++ > > > 2 files changed, 101 insertions(+), 65 deletions(-) > > > delete mode 100644 Documentation/devicetree/bindings/arm/tegra.txt > > > create mode 100644 Documentation/devicetree/bindings/arm/tegra.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/arm/tegra.txt b/Docume= ntation/devicetree/bindings/arm/tegra.txt > > > deleted file mode 100644 > > > index c59b15f64346..000000000000 > > > --- a/Documentation/devicetree/bindings/arm/tegra.txt > > > +++ /dev/null > > > @@ -1,65 +0,0 @@ > > > -NVIDIA Tegra device tree bindings > > > -------------------------------------------- > > > - > > > -SoCs > > > -------------------------------------------- > > > - > > > -Each device tree must specify which Tegra SoC it uses, using one of = the > > > -following compatible values: > > > - > > > - nvidia,tegra20 > > > - nvidia,tegra30 > > > - nvidia,tegra114 > > > - nvidia,tegra124 > > > - nvidia,tegra132 > > > - nvidia,tegra210 > > > - nvidia,tegra186 > > > - nvidia,tegra194 > > > - > > > -Boards > > > -------------------------------------------- > > > - > > > -Each device tree must specify which one or more of the following > > > -board-specific compatible values: > > > - > > > - ad,medcom-wide > > > - ad,plutux > > > - ad,tamonten > > > - ad,tec > > > - compal,paz00 > > > - compulab,trimslice > > > - nvidia,beaver > > > - nvidia,cardhu > > > - nvidia,cardhu-a02 > > > - nvidia,cardhu-a04 > > > - nvidia,dalmore > > > - nvidia,harmony > > > - nvidia,jetson-tk1 > > > - nvidia,norrin > > > - nvidia,p2371-0000 > > > - nvidia,p2371-2180 > > > - nvidia,p2571 > > > - nvidia,p2771-0000 > > > - nvidia,p2972-0000 > > > - nvidia,roth > > > - nvidia,seaboard > > > - nvidia,tn7 > > > - nvidia,ventana > > > - toradex,apalis_t30 > > > - toradex,apalis_t30-eval > > > - toradex,apalis_t30-v1.1 > > > - toradex,apalis_t30-v1.1-eval > > > - toradex,apalis-tk1 > > > - toradex,apalis-tk1-eval > > > - toradex,apalis-tk1-v1.2 > > > - toradex,apalis-tk1-v1.2-eval > > > - toradex,colibri_t20 > > > - toradex,colibri_t20-eval-v3 > > > - toradex,colibri_t20-iris > > > - toradex,colibri_t30 > > > - toradex,colibri_t30-eval-v3 > > > - > > > -Trusted Foundations > > > -------------------------------------------- > > > -Tegra supports the Trusted Foundation secure monitor. See the > > > -"tlm,trusted-foundations" binding's documentation for more details. > > > diff --git a/Documentation/devicetree/bindings/arm/tegra.yaml b/Docum= entation/devicetree/bindings/arm/tegra.yaml > > > new file mode 100644 > > > index 000000000000..66493892ffc1 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/arm/tegra.yaml > > > @@ -0,0 +1,101 @@ > > > +# SPDX-License-Identifier: GPL-2.0 > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/arm/tegra.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > Could you explain what these are? They give 404, so I assume they are > > more like placeholders and not actually used? >=20 > Please read the documentation in patch 2. They are used, but aren't live = URLs. Okay, thanks for pointing that out. I wasn't Cc'ed on that patch, so it took a while to hunt it down. > > > + > > > +title: NVIDIA Tegra device tree bindings > > > + > > > +maintainers: > > > + - Marcel Ziswiler > > > + - Peter De Schrijver > > > > Not sure how you got that list, but probably from git history. I think > > it makes sense to replace Marcel and Peter with Jon and myself. >=20 > Will do. >=20 > > Other than that, looks fine to me. Some of the enumerations below look > > somewhat hard to parse, but I suspect that it will become second nature > > in no time. >=20 > We can add descriptions and/or comments if that helps. I didn't add > them if not already there. My comment was regarding the schema syntax with the oneOf, - items, etc. That's all new to me and difficult to read, but I'm sure I'll get used to it. Thierry --61jdw2sOBCFtR2d/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlwKXYgACgkQ3SOs138+ s6GutQ/8CGUawOVXWa2O3RRFvjPZq9Bl151N7gluvIlFcVkD8TNspGoYaTDxSc9r 2GnDUorHpU3mroiOnB1mDvCuPvrWwMmLgI+7fPSIkMJ5wCC24qFjSMvEXgzVCeu+ JaZL4VxICnKxWtrlPRlDfFlLuOP91Zgj+sT2zBK517m3gbjFWN1im+42+lrNsO60 tNLIJyFAUkGjtzNYPNFKJxuW8+Ubgl33S5pRPNmRpuImb6Pmou0LMRYM5l3R8dvj 5+yeHXiKgwi25HNXIaa9+Kc9ouBOaR+cqY2+fI4VelaQ07Ip+eURXed7tDZrm2h3 0wgkBAwuBh9AlIhP0njOTw72b1s6UHZ18o6yFYzaGr3tQej504ZPf49BI9TTa/Ws Pp0FRrIuKa3bpOlEL+Z04VYbV0erjIC5bb8eqJrJiKXE9EAKequjVcHBDtuhUGiG pTEm1dXpCplN8RJRHazTksM9AygJxqmF+0vlQI5E/utjQEjfm3WYnDsmZNZ5yJQD I0vd65LKeMGu32lm1S9vVrlLbwHwcL3/tgly++A2EwjD8OrNCw8rXDNvicK+sJ9E sBB/67Jay2JviIHRhPeHyZuCpe9mxXZEKaMi+WpEdOED4miar02/fejWpjDRrYnt eU4soLlgiTj/KP+ihgQXtQWGTE7pbuCUPXHYll+v/GcWPuTKiss= =/353 -----END PGP SIGNATURE----- --61jdw2sOBCFtR2d/--