From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, xc-racer2@live.ca,
simon@lineageos.org
Subject: Re: [PATCH 6/8] Input: dt-bindings: tm2-touchkey: Document new keycodes property
Date: Sat, 8 Dec 2018 20:57:35 -0800 [thread overview]
Message-ID: <20181209045735.GG211094@dtor-ws> (raw)
In-Reply-To: <20181207105811.1831-7-pawel.mikolaj.chmiel@gmail.com>
On Fri, Dec 07, 2018 at 11:58:09AM +0100, Paweł Chmiel wrote:
> From: Jonathan Bakker <xc-racer2@live.ca>
>
> Document new optional property for setting custom keycodes.
>
> Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
> ---
> .../devicetree/bindings/input/cypress,tm2-touchkey.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt b/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt
> index dfb3b9f0ee40..3b54d997b8de 100644
> --- a/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt
> +++ b/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt
> @@ -10,6 +10,9 @@ Required properties:
> - vcc-supply : internal regulator output. 1.8V
> - vdd-supply : power supply for IC 3.3V
>
> +Optional properties:
> +- keycodes: array of keycodes (max 4), default KEY_PHONE and KEY_BACK
> +
> [0]: Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
>
> Example:
> @@ -23,5 +26,6 @@ Example:
> interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
> vcc-supply=<&ldo32_reg>;
> vdd-supply=<&ldo33_reg>;
> + keycodes = /bits/ 8 <KEY_PHONE KEY_BACK>;
We definitely have key codes bigger than 255. Just keep them normal
ints please.
> };
> };
> --
> 2.17.1
>
--
Dmitry
next prev parent reply other threads:[~2018-12-09 4:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 10:58 [PATCH 0/8] Input: tm2-touchkey: Add support for Aries and Midas Paweł Chmiel
2018-12-07 10:58 ` [PATCH 1/8] Input: tm2-touchkey: Add support for midas touchkey Paweł Chmiel
2018-12-09 4:22 ` Dmitry Torokhov
2018-12-07 10:58 ` [PATCH 2/8] Input: dt-bindings: " Paweł Chmiel
2018-12-20 17:09 ` Rob Herring
2018-12-07 10:58 ` [PATCH 3/8] Input: tm2-touchkey: Use predefined device name Paweł Chmiel
2018-12-09 4:23 ` Dmitry Torokhov
2018-12-07 10:58 ` [PATCH 4/8] Input: tm2-touchkey: Correct initial brightness Paweł Chmiel
2018-12-07 10:58 ` [PATCH 5/8] Input: tm2-touchkey: Allow specifying custom keycodes Paweł Chmiel
2018-12-07 10:58 ` [PATCH 6/8] Input: dt-bindings: tm2-touchkey: Document new keycodes property Paweł Chmiel
2018-12-09 4:57 ` Dmitry Torokhov [this message]
2018-12-07 10:58 ` [PATCH 7/8] Input: tm2-touchkey: Add support for aries touchkey variant Paweł Chmiel
2018-12-07 10:58 ` [PATCH 8/8] Input: dt-bindings: tm2-touchkey: Add support for aries touchkey Paweł Chmiel
2018-12-20 17:10 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181209045735.GG211094@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.mikolaj.chmiel@gmail.com \
--cc=robh+dt@kernel.org \
--cc=simon@lineageos.org \
--cc=xc-racer2@live.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).