From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Max Filippov <jcmvbkbc@gmail.com>,
Oleg Nesterov <oleg@redhat.com>,
Andy Lutomirski <luto@kernel.org>
Cc: Elvira Khabirova <lineprinter@altlinux.org>,
Eugene Syromyatnikov <esyr@redhat.com>,
Chris Zankel <chris@zankel.net>, Paul Moore <paul@paul-moore.com>,
Eric Paris <eparis@redhat.com>,
linux-xtensa@linux-xtensa.org, linux-audit@redhat.com,
linux-kernel@vger.kernel.org
Subject: [PATCH v5 19/25] xtensa: define syscall_get_* functions
Date: Mon, 10 Dec 2018 07:30:41 +0300 [thread overview]
Message-ID: <20181210043041.GS6131@altlinux.org> (raw)
In-Reply-To: 20181210042352.GA6092@altlinux.org
syscall_get_* functions are required to be implemented on all
architectures in order to extend the generic ptrace API with
PTRACE_GET_SYSCALL_INFO request.
This adds all 5 syscall_get_* functions on xtensa as documented
in asm-generic/syscall.h: syscall_get_nr, syscall_get_arguments,
syscall_get_error, syscall_get_return_value, and syscall_get_arch.
Cc: Max Filippov <jcmvbkbc@gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Elvira Khabirova <lineprinter@altlinux.org>
Cc: Eugene Syromyatnikov <esyr@redhat.com>
Cc: Chris Zankel <chris@zankel.net>
Cc: Paul Moore <paul@paul-moore.com>
Cc: Eric Paris <eparis@redhat.com>
Cc: linux-xtensa@linux-xtensa.org
Cc: linux-audit@redhat.com
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
---
Notes:
v5: added syscall_get_nr, syscall_get_arguments, syscall_get_error,
and syscall_get_return_value
v2: added Acked-by
v1: added syscall_get_arch
arch/xtensa/include/asm/syscall.h | 69 +++++++++++++++++++++++++++++++
include/uapi/linux/audit.h | 1 +
2 files changed, 70 insertions(+)
diff --git a/arch/xtensa/include/asm/syscall.h b/arch/xtensa/include/asm/syscall.h
index 3673ff1f1bc5..d529c855a144 100644
--- a/arch/xtensa/include/asm/syscall.h
+++ b/arch/xtensa/include/asm/syscall.h
@@ -8,6 +8,75 @@
* Copyright (C) 2001 - 2007 Tensilica Inc.
*/
+#include <uapi/linux/audit.h>
+
+static inline int
+syscall_get_nr(struct task_struct *task, struct pt_regs *regs)
+{
+ return regs->syscall;
+}
+
+static inline void
+syscall_get_arguments(struct task_struct *task, struct pt_regs *regs,
+ unsigned int i, unsigned int n, unsigned long *args)
+{
+ switch (i) {
+ case 0:
+ if (!n--)
+ break;
+ *args++ = regs->areg[6];
+ /* fall through */
+ case 1:
+ if (!n--)
+ break;
+ *args++ = regs->areg[3];
+ /* fall through */
+ case 2:
+ if (!n--)
+ break;
+ *args++ = regs->areg[4];
+ /* fall through */
+ case 3:
+ if (!n--)
+ break;
+ *args++ = regs->areg[5];
+ /* fall through */
+ case 4:
+ if (!n--)
+ break;
+ *args++ = regs->areg[8];
+ /* fall through */
+ case 5:
+ if (!n--)
+ break;
+ *args++ = regs->areg[9];
+ /* fall through */
+ case 6:
+ if (!n--)
+ break;
+ /* fall through */
+ default:
+ BUG();
+ }
+}
+
+static inline long
+syscall_get_error(struct task_struct *task, struct pt_regs *regs)
+{
+ return IS_ERR_VALUE(regs->areg[2]) ? regs->areg[2] : 0;
+
+static inline long
+syscall_get_return_value(struct task_struct *task, struct pt_regs *regs)
+{
+ return regs->areg[2];
+}
+
+static inline int
+syscall_get_arch(void)
+{
+ return AUDIT_ARCH_XTENSA;
+}
+
struct pt_regs;
asmlinkage long xtensa_ptrace(long, long, long, long);
asmlinkage long xtensa_sigreturn(struct pt_regs*);
diff --git a/include/uapi/linux/audit.h b/include/uapi/linux/audit.h
index 1e9808f3a240..bcc0619b046f 100644
--- a/include/uapi/linux/audit.h
+++ b/include/uapi/linux/audit.h
@@ -425,6 +425,7 @@ enum {
#define AUDIT_ARCH_TILEGX32 (EM_TILEGX|__AUDIT_ARCH_LE)
#define AUDIT_ARCH_TILEPRO (EM_TILEPRO|__AUDIT_ARCH_LE)
#define AUDIT_ARCH_X86_64 (EM_X86_64|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE)
+#define AUDIT_ARCH_XTENSA (EM_XTENSA)
#define AUDIT_PERM_EXEC 1
#define AUDIT_PERM_WRITE 2
--
ldv
next prev parent reply other threads:[~2018-12-10 4:30 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181210042352.GA6092@altlinux.org>
2018-12-10 4:27 ` [PATCH v5 01/25] alpha: define remaining syscall_get_* functions Dmitry V. Levin
2018-12-10 4:28 ` [PATCH v5 02/25] Move EM_ARCOMPACT and EM_ARCV2 to uapi/linux/elf-em.h Dmitry V. Levin
2018-12-10 4:29 ` [PATCH v5 03/25] arc: define syscall_get_arch() Dmitry V. Levin
2018-12-10 4:29 ` [PATCH v5 04/25] c6x: " Dmitry V. Levin
2018-12-11 22:40 ` Mark Salter
2018-12-10 4:29 ` [PATCH v5 05/25] elf-em.h: add EM_CSKY Dmitry V. Levin
2018-12-10 4:29 ` [PATCH v5 06/25] csky: define syscall_get_arch() Dmitry V. Levin
2018-12-10 4:29 ` [PATCH v5 07/25] h8300: define remaining syscall_get_* functions Dmitry V. Levin
2018-12-10 4:29 ` [PATCH v5 08/25] Move EM_HEXAGON to uapi/linux/elf-em.h Dmitry V. Levin
2018-12-10 4:29 ` [PATCH v5 09/25] hexagon: define remaining syscall_get_* functions Dmitry V. Levin
2018-12-10 4:29 ` [PATCH v5 10/25] Move EM_NDS32 to uapi/linux/elf-em.h Dmitry V. Levin
2018-12-10 4:29 ` [PATCH v5 11/25] nds32: define syscall_get_arch() Dmitry V. Levin
2018-12-10 4:30 ` [PATCH v5 12/25] nios2: " Dmitry V. Levin
2018-12-10 4:30 ` [PATCH v5 13/25] m68k: add asm/syscall.h Dmitry V. Levin
2018-12-10 8:45 ` Geert Uytterhoeven
2018-12-10 12:40 ` Dmitry V. Levin
2018-12-10 13:06 ` Geert Uytterhoeven
2018-12-10 13:30 ` Dmitry V. Levin
2018-12-12 8:55 ` Dmitry V. Levin
2018-12-12 9:01 ` Geert Uytterhoeven
2018-12-12 9:27 ` Dmitry V. Levin
2018-12-12 9:43 ` Geert Uytterhoeven
2018-12-12 12:04 ` Dmitry V. Levin
2018-12-12 12:27 ` Geert Uytterhoeven
2018-12-12 12:37 ` Dmitry V. Levin
2018-12-12 12:54 ` Geert Uytterhoeven
2018-12-12 13:07 ` Dmitry V. Levin
2018-12-12 23:12 ` Dmitry V. Levin
2019-03-29 22:04 ` Dmitry V. Levin
2019-03-30 20:57 ` Geert Uytterhoeven
2018-12-10 4:30 ` [PATCH v5 14/25] mips: define syscall_get_error() Dmitry V. Levin
2018-12-10 4:30 ` [PATCH v5 15/25] parisc: " Dmitry V. Levin
2018-12-10 4:30 ` [PATCH v5 16/25] powerpc: " Dmitry V. Levin
2018-12-10 4:30 ` [PATCH v5 17/25] riscv: define syscall_get_arch() Dmitry V. Levin
2018-12-10 4:30 ` [PATCH v5 18/25] Move EM_XTENSA to uapi/linux/elf-em.h Dmitry V. Levin
2018-12-10 4:30 ` Dmitry V. Levin [this message]
2018-12-10 5:02 ` [PATCH v5 19/25] xtensa: define syscall_get_* functions Max Filippov
2018-12-10 12:53 ` Dmitry V. Levin
2018-12-10 20:14 ` Max Filippov
2018-12-10 20:24 ` Dmitry V. Levin
2018-12-10 20:30 ` Dmitry V. Levin
2018-12-10 21:29 ` Max Filippov
2018-12-12 10:45 ` kbuild test robot
2018-12-19 5:58 ` kbuild test robot
2018-12-10 4:30 ` [PATCH v5 20/25] Move EM_UNICORE to uapi/linux/elf-em.h Dmitry V. Levin
2018-12-10 4:30 ` [PATCH v5 21/25] unicore32: add asm/syscall.h Dmitry V. Levin
2018-12-10 4:31 ` [PATCH v5 22/25] syscall_get_arch: add "struct task_struct *" argument Dmitry V. Levin
2018-12-10 17:29 ` Kees Cook
2018-12-11 22:44 ` Mark Salter
2018-12-10 4:31 ` [PATCH v5 23/25] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call Dmitry V. Levin
2018-12-10 4:31 ` [PATCH v5 24/25] ptrace: add PTRACE_GET_SYSCALL_INFO request Dmitry V. Levin
2018-12-10 14:11 ` Oleg Nesterov
2018-12-10 16:21 ` Dmitry V. Levin
2018-12-11 15:29 ` Oleg Nesterov
2018-12-11 16:23 ` Dmitry V. Levin
2018-12-11 20:27 ` Dmitry V. Levin
2018-12-12 18:00 ` Oleg Nesterov
2018-12-10 14:26 ` kbuild test robot
2018-12-10 16:09 ` Dmitry V. Levin
2018-12-10 18:04 ` Paul Burton
2018-12-10 21:04 ` Palmer Dabbelt
2018-12-10 19:38 ` Andy Lutomirski
2018-12-10 17:44 ` Kees Cook
2018-12-12 9:28 ` kbuild test robot
2018-12-10 4:31 ` [PATCH v5 25/25] selftests/ptrace: add a test case for PTRACE_GET_SYSCALL_INFO Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210043041.GS6131@altlinux.org \
--to=ldv@altlinux.org \
--cc=chris@zankel.net \
--cc=eparis@redhat.com \
--cc=esyr@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=lineprinter@altlinux.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=luto@kernel.org \
--cc=oleg@redhat.com \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).