From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Anthony Yznaga <anthony.yznaga@oracle.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"adobriyan@gmail.com" <adobriyan@gmail.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"vbabka@suse.cz" <vbabka@suse.cz>,
"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
"willy@infradead.org" <willy@infradead.org>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"rppt@linux.vnet.ibm.com" <rppt@linux.vnet.ibm.com>,
"mhocko@suse.com" <mhocko@suse.com>,
"alexander.h.duyck@linux.intel.com"
<alexander.h.duyck@linux.intel.com>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
"miles.chen@mediatek.com" <miles.chen@mediatek.com>
Subject: Re: [PATCH v2] /proc/kpagecount: return 0 for special pages that are never mapped
Date: Mon, 10 Dec 2018 23:39:28 +0000 [thread overview]
Message-ID: <20181210233928.GA11726@hori1.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <1544481313-27318-1-git-send-email-anthony.yznaga@oracle.com>
On Mon, Dec 10, 2018 at 02:35:13PM -0800, Anthony Yznaga wrote:
> Certain pages that are never mapped to userspace have a type
> indicated in the page_type field of their struct pages (e.g. PG_buddy).
> page_type overlaps with _mapcount so set the count to 0 and avoid
> calling page_mapcount() for these pages.
>
> Signed-off-by: Anthony Yznaga <anthony.yznaga@oracle.com>
> Acked-by: Matthew Wilcox <willy@infradead.org>
Looks good to me.
Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> ---
> v2 - incorporated feedback from Matthew Wilcox
>
> fs/proc/page.c | 2 +-
> include/linux/page-flags.h | 6 ++++++
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/fs/proc/page.c b/fs/proc/page.c
> index 6c517b11acf8..40b05e0d4274 100644
> --- a/fs/proc/page.c
> +++ b/fs/proc/page.c
> @@ -46,7 +46,7 @@ static ssize_t kpagecount_read(struct file *file, char __user *buf,
> ppage = pfn_to_page(pfn);
> else
> ppage = NULL;
> - if (!ppage || PageSlab(ppage))
> + if (!ppage || PageSlab(ppage) || page_has_type(ppage))
> pcount = 0;
> else
> pcount = page_mapcount(ppage);
> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> index 50ce1bddaf56..39b4494e29f1 100644
> --- a/include/linux/page-flags.h
> +++ b/include/linux/page-flags.h
> @@ -669,6 +669,7 @@ static inline int TestClearPageDoubleMap(struct page *page)
>
> #define PAGE_TYPE_BASE 0xf0000000
> /* Reserve 0x0000007f to catch underflows of page_mapcount */
> +#define PAGE_MAPCOUNT_RESERVE -128
> #define PG_buddy 0x00000080
> #define PG_balloon 0x00000100
> #define PG_kmemcg 0x00000200
> @@ -677,6 +678,11 @@ static inline int TestClearPageDoubleMap(struct page *page)
> #define PageType(page, flag) \
> ((page->page_type & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE)
>
> +static inline int page_has_type(struct page *page)
> +{
> + return (int)page->page_type < PAGE_MAPCOUNT_RESERVE;
> +}
> +
> #define PAGE_TYPE_OPS(uname, lname) \
> static __always_inline int Page##uname(struct page *page) \
> { \
> --
> 1.8.3.1
>
>
prev parent reply other threads:[~2018-12-11 0:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 22:35 [PATCH v2] /proc/kpagecount: return 0 for special pages that are never mapped Anthony Yznaga
2018-12-10 23:39 ` Naoya Horiguchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210233928.GA11726@hori1.linux.bs1.fc.nec.co.jp \
--to=n-horiguchi@ah.jp.nec.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=anthony.yznaga@oracle.com \
--cc=hannes@cmpxchg.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=miles.chen@mediatek.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).