From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12393C07E85 for ; Tue, 11 Dec 2018 08:38:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D656A2081B for ; Tue, 11 Dec 2018 08:38:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D656A2081B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726214AbeLKIiX (ORCPT ); Tue, 11 Dec 2018 03:38:23 -0500 Received: from smtp.nue.novell.com ([195.135.221.5]:55745 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726094AbeLKIiX (ORCPT ); Tue, 11 Dec 2018 03:38:23 -0500 Received: from emea4-mta.ukb.novell.com ([10.120.13.87]) by smtp.nue.novell.com with ESMTP (TLS encrypted); Tue, 11 Dec 2018 09:38:20 +0100 Received: from linux-l9pv.suse (nwb-a10-snat.microfocus.com [10.120.13.201]) by emea4-mta.ukb.novell.com with ESMTP (TLS encrypted); Tue, 11 Dec 2018 08:37:59 +0000 Date: Tue, 11 Dec 2018 16:37:54 +0800 From: joeyli To: Yu Chen Cc: "Rafael J. Wysocki" , Len Brown , linux-kernel@vger.kernel.org, Lenny Szubowicz , Jacob Pan , Rui Zhang , linux-acpi@vger.kernel.org Subject: Re: [PATCH][RFC v2] ACPI: acpi_pad: Do not launch acpi_pad threads on idle cpus Message-ID: <20181211083754.GE28555@linux-l9pv.suse> References: <1525521202-32519-1-git-send-email-yu.c.chen@intel.com> <20181210063153.GO5327@linux-l9pv.suse> <20181211031220.GA23975@chenyu-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181211031220.GA23975@chenyu-desktop> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yu Chen, Thanks for your response! On Tue, Dec 11, 2018 at 11:12:21AM +0800, Yu Chen wrote: > Hi Joey, > On Mon, Dec 10, 2018 at 02:31:53PM +0800, joeyli wrote: > > Hi Chen Yu and ACPI experts, > > > > On Sat, May 05, 2018 at 07:53:22PM +0800, Chen Yu wrote: > > > According to current implementation of acpi_pad driver, > > > it does not make sense to spawn any power saving threads > > > on the cpus which are already idle - it might bring > > > unnecessary overhead on these idle cpus and causes power > > > waste. So verify the condition that if the number of 'busy' > > > cpus exceeds the amount of the 'forced idle' cpus is met. > > > This is applicable due to round-robin attribute of the > > > power saving threads, otherwise ignore the setting/ACPI > > > notification. > > > > > > Suggested-by: Lenny Szubowicz > > > Suggested-by: Len Brown > > > Cc: "Rafael J. Wysocki" > > > Cc: Lenny Szubowicz > > > Cc: Len Brown > > > Cc: Jacob Pan > > > Cc: Rui Zhang > > > Cc: linux-acpi@vger.kernel.org > > > Signed-off-by: Chen Yu > > > > Do you have any news for this patch? Why it did not merged by kernel > > maineline? > > > We are evaluating if this could be integrated into idle injection framework. > May I know if there's any requirement/background from SUSE on this? > I am also looking at your patch and idle injection framework. Currently I do not have good suggestion for your patches yet. But I will try to ready my knowledge when you send out new version. Thanks a lot! Joey Lee > > > > > --- > > > drivers/acpi/acpi_pad.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++++- > > > 1 file changed, 51 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c > > > index 552c1f7..515e60e 100644 > > > --- a/drivers/acpi/acpi_pad.c > > > +++ b/drivers/acpi/acpi_pad.c > > > @@ -254,12 +254,62 @@ static void set_power_saving_task_num(unsigned int num) > > > } > > > } > > > > > > +/* > > > + * Extra acpi_pad threads should not be created until > > > + * the requested idle count is less than/equals to the > > > + * number of the busy cpus - it does not make sense to > > > + * throttle the idle cpus. > > > + */ > > > +#define SAMPLE_INTERVAL_JIF 20 > > > + > > > +static u64 get_idle_time(int cpu) > > > +{ > > > + u64 idle, idle_usecs = -1ULL; > > > + > > > + idle_usecs = get_cpu_idle_time_us(cpu, NULL); > > > + > > > + if (idle_usecs == -1ULL) > > > + idle = kcpustat_cpu(cpu).cpustat[CPUTIME_IDLE]; > > > + else > > > + idle = idle_usecs * NSEC_PER_USEC; > > > + > > > + return idle; > > > +} > > > + > > > +static bool idle_nr_valid(unsigned int num_cpus) > > > +{ > > > + int busy_nr = 0, i = 0, load_thresh = 100 - idle_pct; > > > + > > > + if (!num_cpus) > > > + return true; > > > + > > > + for_each_online_cpu(i) { > > > + u64 wall_time, idle_time; > > > + unsigned int elapsed_delta, idle_delta, load; > > > + > > > + wall_time = jiffies64_to_nsecs(get_jiffies_64()); > > > + idle_time = get_idle_time(i); > > > + /* Wait and see... */ > > > + schedule_timeout_uninterruptible(SAMPLE_INTERVAL_JIF); > > > + > > > + idle_delta = get_idle_time(i) - idle_time; > > > + elapsed_delta = jiffies64_to_nsecs(get_jiffies_64()) - wall_time; > > > + idle_delta = (idle_delta > elapsed_delta) ? elapsed_delta : idle_delta; > > > + load = 100 * (elapsed_delta - idle_delta) / elapsed_delta; > > > + if (load >= load_thresh) > > > + busy_nr++; > > > + } > > > + > > > + return (busy_nr >= num_cpus) ? true : false; > > > +} > > > + > > > static void acpi_pad_idle_cpus(unsigned int num_cpus) > > > { > > > get_online_cpus(); > > > > > > num_cpus = min_t(unsigned int, num_cpus, num_online_cpus()); > > > - set_power_saving_task_num(num_cpus); > > > + if (idle_nr_valid(num_cpus)) > > > + set_power_saving_task_num(num_cpus); > > > > > > put_online_cpus(); > > > } > > > -- > > > 2.7.4 > > > > > > -- > > > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > > > the body of a message to majordomo@vger.kernel.org > > > More majordomo info at http://vger.kernel.org/majordomo-info.html