From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96964C07E85 for ; Tue, 11 Dec 2018 12:29:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5A7972081B for ; Tue, 11 Dec 2018 12:29:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544531397; bh=RBNTldWktr52Y6MxAAfN+HXAfEJpD4kjE75GrOVAGok=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=JOz9YQ68pkbCae9t0UUY1qah16eR0DZh6By+jY6HuW2v+8vnFM/OnVrdSci53yTCJ BSALfMV73zNkfUmCMDS2MiVXvPs0P0NM9mykonVW37NWC9KOaC2oybjAmh+dQ/6Bp3 4bk8QzlDlAvpqGMeqH3phubwSbJuBa9xsV4/IAqk= DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A7972081B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726435AbeLKM34 (ORCPT ); Tue, 11 Dec 2018 07:29:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:45122 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726230AbeLKM3z (ORCPT ); Tue, 11 Dec 2018 07:29:55 -0500 Received: from quaco.ghostprotocols.net (unknown [190.15.121.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B25D42081B; Tue, 11 Dec 2018 12:29:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544531394; bh=RBNTldWktr52Y6MxAAfN+HXAfEJpD4kjE75GrOVAGok=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ENaMKYoQyK0hRQsjc6LCUEOtjvAmrCTVjJa09tXaZk0tdfSw6/93ssqquABb6aofr 6FXEC5Cqe3Y5Km/uUocXkrr2t8b1c4TVbbYypfw4/5nXeIneTHfeUPSS48a0b3w36C /G1+hdt74RDWVydKKoJkykSh1fN7cnubxfLPBjfo= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 7D5834042C; Tue, 11 Dec 2018 09:29:52 -0300 (-03) Date: Tue, 11 Dec 2018 09:29:52 -0300 From: Arnaldo Carvalho de Melo To: Steven Rostedt Cc: LKML , Linux Trace Devel , Jiri Olsa , Ingo Molnar , Namhyung Kim Subject: Re: [PATCH] tools/lib/traceevent: Fix processing of dereferenced args in bprintk events Message-ID: <20181211122952.GC14480@kernel.org> References: <20181210134522.3f71e2ca@gandalf.local.home> <20181210184807.GA26445@kernel.org> <20181210162621.2050475a@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181210162621.2050475a@gandalf.local.home> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Dec 10, 2018 at 04:26:21PM -0500, Steven Rostedt escreveu: > On Mon, 10 Dec 2018 15:48:07 -0300 > Arnaldo Carvalho de Melo wrote: > > > Em Mon, Dec 10, 2018 at 01:45:22PM -0500, Steven Rostedt escreveu: > > > From: "Steven Rostedt (VMware)" > > > > > > In the case that a bprintk event has a dereferenced pointer that is stored > > > as a string, and there's more values to process (more args), the arg was not > > > updated to point to the next arg after processing the dereferenced pointer, > > > and it screwed up what was to be displayed. > > > > Thanks, applied. > > > > > Cc: stable@vger.kernel.org > > > Fixes: 7db96bb49629 ("tools lib traceevent: Handle new pointer processing of bprint strings") > > Arnaldo, > > It seems that I cut and pasted the sha1 of the "fixes" part wrong. Can > you add a "3". That is, the above should have been: 37db96bb49629 Done, git rebase -i + reword -> push -f'ed :-) https://git.kernel.org/acme/c/1e862fa6b4e9 - Arnaldo > Thanks, > > -- Steve > > > > > > Signed-off-by: Steven Rostedt (VMware) > > > --- > > > tools/lib/traceevent/event-parse.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c > > > index 3692f29fee46..70144b98141c 100644 > > > --- a/tools/lib/traceevent/event-parse.c > > > +++ b/tools/lib/traceevent/event-parse.c > > > @@ -4970,6 +4970,7 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct tep_e > > > > > > if (arg->type == TEP_PRINT_BSTRING) { > > > trace_seq_puts(s, arg->string.string); > > > + arg = arg->next; > > > break; > > > } > > > > > > -- > > > 2.19.1 > > -- - Arnaldo