From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFB61C07E85 for ; Tue, 11 Dec 2018 15:57:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73791205C9 for ; Tue, 11 Dec 2018 15:57:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544543872; bh=AFy2SJ9PDkhJynCc4bZ8GT/S8IcadC4JbDgUHd7/UeA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=oiWDZGfMMnI6Mr6g702ZJ+DeZ3F+hxkhra/WhdnSzUy3fLHsrVRgkrvxQEey/8xnz OxrPxls3nNB/K5vPpKqZ20YI9ZYQ1M+Ng0jRTuFZ6V9ITLveWTfWq5IDQJSWKJvCpm 0ECN0ttYF7JtPByNuJNo6V4hOGZIxJuA3NHMHqRI= DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73791205C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730908AbeLKP5v (ORCPT ); Tue, 11 Dec 2018 10:57:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:46822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730884AbeLKP5o (ORCPT ); Tue, 11 Dec 2018 10:57:44 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D56F2146D; Tue, 11 Dec 2018 15:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544543863; bh=AFy2SJ9PDkhJynCc4bZ8GT/S8IcadC4JbDgUHd7/UeA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rI9wGKn8AAflW6XsF1quy1AWvqvsIQEKrcmK6/t96bd30ouHaufomvE+tHi7kvSrn aRzpMB6jITov8iodPxTpvdVf5GKf6QTr5zIkRaQXjrZe+hba7nGwnfd1w1i4cqbSlh r60Pw7Ehe5V5yMhTVLhty8kuXeJfKlr9SOoWxBCk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paulo Alcantara , Aurelien Aptel , Steve French Subject: [PATCH 4.19 093/118] cifs: Fix separator when building path from dentry Date: Tue, 11 Dec 2018 16:41:52 +0100 Message-Id: <20181211151648.026520102@linuxfoundation.org> X-Mailer: git-send-email 2.20.0 In-Reply-To: <20181211151644.216668863@linuxfoundation.org> References: <20181211151644.216668863@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Paulo Alcantara commit c988de29ca161823db6a7125e803d597ef75b49c upstream. Make sure to use the CIFS_DIR_SEP(cifs_sb) as path separator for prefixpath too. Fixes a bug with smb1 UNIX extensions. Fixes: a6b5058fafdf ("fs/cifs: make share unaccessible at root level mountable") Signed-off-by: Paulo Alcantara Reviewed-by: Aurelien Aptel Signed-off-by: Steve French CC: Stable Signed-off-by: Greg Kroah-Hartman --- fs/cifs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/cifs/dir.c +++ b/fs/cifs/dir.c @@ -174,7 +174,7 @@ cifs_bp_rename_retry: cifs_dbg(FYI, "using cifs_sb prepath <%s>\n", cifs_sb->prepath); memcpy(full_path+dfsplen+1, cifs_sb->prepath, pplen-1); - full_path[dfsplen] = '\\'; + full_path[dfsplen] = dirsep; for (i = 0; i < pplen-1; i++) if (full_path[dfsplen+1+i] == '/') full_path[dfsplen+1+i] = CIFS_DIR_SEP(cifs_sb);