linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] kprobes/x86/xen: blacklist non-attachable xen interrupt functions
@ 2018-12-10 15:12 Andrea Righi
  2018-12-11  9:43 ` Masami Hiramatsu
  2018-12-17 15:57 ` Boris Ostrovsky
  0 siblings, 2 replies; 3+ messages in thread
From: Andrea Righi @ 2018-12-10 15:12 UTC (permalink / raw)
  To: Masami Hiramatsu, Boris Ostrovsky, Juergen Gross, Stefano Stabellini
  Cc: Thomas Gleixner, Ingo Molnar, Borislav Petkov, H. Peter Anvin,
	x86, xen-devel, linux-kernel

Blacklist symbols in Xen probe-prohibited areas, so that user can see
these prohibited symbols in debugfs.

See also: a50480cb6d61.

Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
---
 arch/x86/xen/xen-asm_64.S | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/xen/xen-asm_64.S b/arch/x86/xen/xen-asm_64.S
index bb1c2da0381d..1e9ef0ba30a5 100644
--- a/arch/x86/xen/xen-asm_64.S
+++ b/arch/x86/xen/xen-asm_64.S
@@ -12,6 +12,7 @@
 #include <asm/segment.h>
 #include <asm/asm-offsets.h>
 #include <asm/thread_info.h>
+#include <asm/asm.h>
 
 #include <xen/interface/xen.h>
 
@@ -24,6 +25,7 @@ ENTRY(xen_\name)
 	pop %r11
 	jmp  \name
 END(xen_\name)
+_ASM_NOKPROBE(xen_\name)
 .endm
 
 xen_pv_trap divide_error
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] kprobes/x86/xen: blacklist non-attachable xen interrupt functions
  2018-12-10 15:12 [PATCH] kprobes/x86/xen: blacklist non-attachable xen interrupt functions Andrea Righi
@ 2018-12-11  9:43 ` Masami Hiramatsu
  2018-12-17 15:57 ` Boris Ostrovsky
  1 sibling, 0 replies; 3+ messages in thread
From: Masami Hiramatsu @ 2018-12-11  9:43 UTC (permalink / raw)
  To: Andrea Righi
  Cc: Boris Ostrovsky, Juergen Gross, Stefano Stabellini,
	Thomas Gleixner, Ingo Molnar, Borislav Petkov, H. Peter Anvin,
	x86, xen-devel, linux-kernel

On Mon, 10 Dec 2018 16:12:57 +0100
Andrea Righi <righi.andrea@gmail.com> wrote:

> Blacklist symbols in Xen probe-prohibited areas, so that user can see
> these prohibited symbols in debugfs.
> 
> See also: a50480cb6d61.

Looks good to me, thanks!

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

> 
> Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
> ---
>  arch/x86/xen/xen-asm_64.S | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/x86/xen/xen-asm_64.S b/arch/x86/xen/xen-asm_64.S
> index bb1c2da0381d..1e9ef0ba30a5 100644
> --- a/arch/x86/xen/xen-asm_64.S
> +++ b/arch/x86/xen/xen-asm_64.S
> @@ -12,6 +12,7 @@
>  #include <asm/segment.h>
>  #include <asm/asm-offsets.h>
>  #include <asm/thread_info.h>
> +#include <asm/asm.h>
>  
>  #include <xen/interface/xen.h>
>  
> @@ -24,6 +25,7 @@ ENTRY(xen_\name)
>  	pop %r11
>  	jmp  \name
>  END(xen_\name)
> +_ASM_NOKPROBE(xen_\name)
>  .endm
>  
>  xen_pv_trap divide_error
> -- 
> 2.17.1
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] kprobes/x86/xen: blacklist non-attachable xen interrupt functions
  2018-12-10 15:12 [PATCH] kprobes/x86/xen: blacklist non-attachable xen interrupt functions Andrea Righi
  2018-12-11  9:43 ` Masami Hiramatsu
@ 2018-12-17 15:57 ` Boris Ostrovsky
  1 sibling, 0 replies; 3+ messages in thread
From: Boris Ostrovsky @ 2018-12-17 15:57 UTC (permalink / raw)
  To: Andrea Righi, Masami Hiramatsu, Juergen Gross, Stefano Stabellini
  Cc: Thomas Gleixner, Ingo Molnar, Borislav Petkov, H. Peter Anvin,
	x86, xen-devel, linux-kernel

On 12/10/18 10:12 AM, Andrea Righi wrote:
> Blacklist symbols in Xen probe-prohibited areas, so that user can see
> these prohibited symbols in debugfs.
>
> See also: a50480cb6d61.
>
> Signed-off-by: Andrea Righi <righi.andrea@gmail.com>

Applied to for-linus-4.21

-boris



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-12-17 15:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-10 15:12 [PATCH] kprobes/x86/xen: blacklist non-attachable xen interrupt functions Andrea Righi
2018-12-11  9:43 ` Masami Hiramatsu
2018-12-17 15:57 ` Boris Ostrovsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).