From: Wolfram Sang <wsa@the-dreams.de>
To: Parthiban Nallathambi <pn@denx.de>
Cc: manivannan.sadhasivam@linaro.org, afaerber@suse.de,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@cubietech.com, thomas.liau@actions-semi.com,
linux-actions@lists.infradead.org
Subject: Re: [PATCH v3 3/4] i2c: Add Actions Semiconductor Owl family S700 I2C support
Date: Tue, 11 Dec 2018 21:54:44 +0100 [thread overview]
Message-ID: <20181211205444.rpfn5cmsndy4y2lv@ninjato> (raw)
In-Reply-To: <20181211080448.24007-4-pn@denx.de>
[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]
On Tue, Dec 11, 2018 at 09:04:47AM +0100, Parthiban Nallathambi wrote:
> Add S700 to the list of devices supported by Owl I2C driver.
>
> Add Actions Semiconductor Owl family S700 I2C driver.
>
> Signed-off-by: Parthiban Nallathambi <pn@denx.de>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Rob, is this okay or should we drop this patch and update the DT to
contain first the s700 compatible and then s900 as fallback?
> ---
> drivers/i2c/busses/i2c-owl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-owl.c b/drivers/i2c/busses/i2c-owl.c
> index 96b4572e6d9c..b6b5a495118b 100644
> --- a/drivers/i2c/busses/i2c-owl.c
> +++ b/drivers/i2c/busses/i2c-owl.c
> @@ -475,6 +475,7 @@ static int owl_i2c_probe(struct platform_device *pdev)
> }
>
> static const struct of_device_id owl_i2c_of_match[] = {
> + { .compatible = "actions,s700-i2c" },
> { .compatible = "actions,s900-i2c" },
> { /* sentinel */ }
> };
> --
> 2.17.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-12-11 20:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 8:04 [PATCH v3 0/4] Add Actions Semi Owl family S700 I2C support Parthiban Nallathambi
2018-12-11 8:04 ` [PATCH v3 1/4] dt-bindings: i2c: Add S700 support for Actions Semi Soc's Parthiban Nallathambi
2018-12-17 22:17 ` Rob Herring
2019-01-03 19:13 ` Wolfram Sang
2018-12-11 8:04 ` [PATCH v3 2/4] arm64: dts: actions: s700: Add I2C controller nodes Parthiban Nallathambi
2019-01-05 17:58 ` Manivannan Sadhasivam
2018-12-11 8:04 ` [PATCH v3 3/4] i2c: Add Actions Semiconductor Owl family S700 I2C support Parthiban Nallathambi
2018-12-11 20:54 ` Wolfram Sang [this message]
2019-01-03 19:13 ` Wolfram Sang
2018-12-11 8:04 ` [PATCH v3 4/4] arm64: dts: actions: s700-cubieboard7: Enable I2C0 and I2C1 Parthiban Nallathambi
2018-12-13 3:47 ` kbuild test robot
2019-01-05 17:59 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211205444.rpfn5cmsndy4y2lv@ninjato \
--to=wsa@the-dreams.de \
--cc=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@cubietech.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=pn@denx.de \
--cc=robh+dt@kernel.org \
--cc=thomas.liau@actions-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).