From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E38CC65BAF for ; Wed, 12 Dec 2018 10:30:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33E652080F for ; Wed, 12 Dec 2018 10:30:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=verge.net.au header.i=@verge.net.au header.b="XZQ3AkI0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33E652080F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=verge.net.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727035AbeLLKah (ORCPT ); Wed, 12 Dec 2018 05:30:37 -0500 Received: from kirsty.vergenet.net ([202.4.237.240]:44166 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726591AbeLLKah (ORCPT ); Wed, 12 Dec 2018 05:30:37 -0500 Received: from reginn.horms.nl (watermunt.horms.nl [80.127.179.77]) by kirsty.vergenet.net (Postfix) with ESMTPA id 0D44325AE79; Wed, 12 Dec 2018 21:30:35 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=verge.net.au; s=mail; t=1544610635; bh=8N/R4NrAODBFMbPHuZ0KPbs20/k+XDHQkwp9W9nOges=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XZQ3AkI0YHEbBqgOgC1r+Nh/MBBWUJCls+YfyU5U7k76mdzEu2PbaSFFsnMIuxvWV bCnm+HH6JbAergRWolflne16SY+QkDhDue5cOm61FKtW9+fk42i9u11NqMB36wzt02 r9lsK69OA6GmuJXtI+hiYbAfSD4RE7HTLwhaVhuw= Received: by reginn.horms.nl (Postfix, from userid 7100) id 5D23C9404C7; Wed, 12 Dec 2018 11:30:33 +0100 (CET) Date: Wed, 12 Dec 2018 11:30:33 +0100 From: Simon Horman To: Geert Uytterhoeven Cc: Arnd Bergmann , Magnus Damm , Geert Uytterhoeven , Biju Das , Fabrizio Castro , Yoshihiro Shimoda , Jacopo Mondi , Sergei Shtylyov , Linux-Renesas , Linux Kernel Mailing List Subject: Re: [PATCH] ARM: shmobile: fix build regressions Message-ID: <20181212103032.ejjr6itnyb6uzck5@verge.net.au> References: <20181210210033.3276054-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organisation: Horms Solutions BV User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 11, 2018 at 09:58:05AM +0100, Geert Uytterhoeven wrote: > Hi Arnd, > > On Mon, Dec 10, 2018 at 10:00 PM Arnd Bergmann wrote: > > A number of Kconfig options have become available now to random ARM > > platforms outside of ARCH_MULTIPLATFORM, which now causes Kconfig > > warnings, and other build errors when those select options that > > lack additonal dependencies, e.g.: > > > > WARNING: unmet direct dependencies detected for HAVE_ARM_ARCH_TIMER > > Depends on [n]: CPU_V7 [=n] > > Selected by [y]: > > - ARCH_RCAR_GEN2 [=y] && SOC_RENESAS [=y] > > - ARCH_R8A73A4 [=y] && SOC_RENESAS [=y] && ARM [=y] > > > > WARNING: unmet direct dependencies detected for SYS_SUPPORTS_EM_STI > > Depends on [n]: GENERIC_CLOCKEVENTS [=n] > > Selected by [y]: > > - ARCH_EMEV2 [=y] && SOC_RENESAS [=y] && ARM [=y] > > > > Put the old dependency on ARCH_RENESAS back for the moment to restore > > the previous behavior. > > > > Fixes: 062887bf5ef7 ("ARM: shmobile: Move SoC Kconfig symbols to drivers/soc/renesas/") > > Signed-off-by: Arnd Bergmann > > --- > > drivers/soc/renesas/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig > > index 4d8012e1205c..68bfca6f20dd 100644 > > --- a/drivers/soc/renesas/Kconfig > > +++ b/drivers/soc/renesas/Kconfig > > @@ -44,7 +44,7 @@ config ARCH_RZN1 > > bool > > select ARM_AMBA > > > > -if ARM > > +if ARM && ARCH_RENESAS > > After a closer look, I think restricting this from ARM to ARCH_MULTI_V7 > should work, too (ARCH_MULTI_V7 selects CPU_V7, and ARCH_MULTIPLATFORM > selects GENERIC_CLOCKEVENTS). Hi Arnd, what is your preferred way forwards here? I'm tempted to take your patch as-is and then work on refining the dependency as a follow-up.