From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, <linux-kernel@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH 1/2] regulator: wm8994: Rely on core to handle GPIO descriptor
Date: Wed, 12 Dec 2018 14:22:34 +0000 [thread overview]
Message-ID: <20181212142234.GP16508@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <20181211095319.11393-1-linus.walleij@linaro.org>
On Tue, Dec 11, 2018 at 10:53:18AM +0100, Linus Walleij wrote:
> After making sure that the regulator core always take over
> handling of the GPIO descriptors, the gpiod_put()
> on the errorpath of the wm8994 driver becomes redundant.
>
> Reported-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
prev parent reply other threads:[~2018-12-12 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 9:53 [PATCH 1/2] regulator: wm8994: Rely on core to handle GPIO descriptor Linus Walleij
2018-12-11 9:53 ` [PATCH 2/2] regulator: arizona-ldo1: " Linus Walleij
2018-12-12 14:23 ` Charles Keepax
2018-12-12 14:22 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212142234.GP16508@imbe.wolfsonmicro.main \
--to=ckeepax@opensource.cirrus.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).