linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] gpio: aspeed: remove duplicated statement
@ 2018-12-12 21:53 Tao Ren
  2018-12-13  1:09 ` Joel Stanley
  2018-12-21 10:14 ` Linus Walleij
  0 siblings, 2 replies; 3+ messages in thread
From: Tao Ren @ 2018-12-12 21:53 UTC (permalink / raw)
  To: Linus Walleij, Joel Stanley, Andrew Jeffery, linux-gpio,
	linux-arm-kernel, linux-aspeed, linux-kernel, openbmc
  Cc: Tao Ren

Remove duplicated assignment statement from aspeed_gpio_probe() function.

Signed-off-by: Tao Ren <taoren@fb.com>
---
 drivers/gpio/gpio-aspeed.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
index 2342e154029b..854bce4fb9e7 100644
--- a/drivers/gpio/gpio-aspeed.c
+++ b/drivers/gpio/gpio-aspeed.c
@@ -1185,7 +1185,6 @@ static int __init aspeed_gpio_probe(struct platform_device *pdev)
 
 	gpio->chip.parent = &pdev->dev;
 	gpio->chip.ngpio = gpio->config->nr_gpios;
-	gpio->chip.parent = &pdev->dev;
 	gpio->chip.direction_input = aspeed_gpio_dir_in;
 	gpio->chip.direction_output = aspeed_gpio_dir_out;
 	gpio->chip.get_direction = aspeed_gpio_get_direction;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] gpio: aspeed: remove duplicated statement
  2018-12-12 21:53 [PATCH] gpio: aspeed: remove duplicated statement Tao Ren
@ 2018-12-13  1:09 ` Joel Stanley
  2018-12-21 10:14 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Joel Stanley @ 2018-12-13  1:09 UTC (permalink / raw)
  To: Tao Ren
  Cc: Linus Walleij, Andrew Jeffery, linux-gpio, Linux ARM,
	linux-aspeed, Linux Kernel Mailing List, OpenBMC Maillist

On Thu, 13 Dec 2018 at 08:24, Tao Ren <taoren@fb.com> wrote:
>
> Remove duplicated assignment statement from aspeed_gpio_probe() function.
>
> Signed-off-by: Tao Ren <taoren@fb.com>

Acked-by: Joel Stanley <joel@jms.id.au>

Thanks Tao!

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gpio: aspeed: remove duplicated statement
  2018-12-12 21:53 [PATCH] gpio: aspeed: remove duplicated statement Tao Ren
  2018-12-13  1:09 ` Joel Stanley
@ 2018-12-21 10:14 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2018-12-21 10:14 UTC (permalink / raw)
  To: Tao Ren
  Cc: Joel Stanley, Andrew Jeffery, open list:GPIO SUBSYSTEM,
	Linux ARM, linux-aspeed, linux-kernel, OpenBMC Maillist

On Wed, Dec 12, 2018 at 10:53 PM Tao Ren <taoren@fb.com> wrote:

> Remove duplicated assignment statement from aspeed_gpio_probe() function.
>
> Signed-off-by: Tao Ren <taoren@fb.com>

Patch applied with Joel's ACK.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-12-21 10:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-12 21:53 [PATCH] gpio: aspeed: remove duplicated statement Tao Ren
2018-12-13  1:09 ` Joel Stanley
2018-12-21 10:14 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).