From: Petr Mladek <pmladek@suse.com>
To: Daniel Wang <wonderfly@google.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Sasha Levin <sashal@kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
stable@vger.kernel.org, Alexander.Levin@microsoft.com,
Andrew Morton <akpm@linux-foundation.org>,
byungchul.park@lge.com, dave.hansen@intel.com,
hannes@cmpxchg.org, jack@suse.cz, linux-kernel@vger.kernel.org,
linux-mm@kvack.org,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Mel Gorman <mgorman@suse.de>,
mhocko@kernel.org, pavel@ucw.cz,
penguin-kernel@i-love.sakura.ne.jp,
Peter Zijlstra <peterz@infradead.org>,
tj@kernel.org, Linus Torvalds <torvalds@linux-foundation.org>,
vbabka@suse.cz, Cong Wang <xiyou.wangcong@gmail.com>,
Peter Feiner <pfeiner@google.com>
Subject: Re: 4.14 backport request for dbdda842fe96f: "printk: Add console owner and waiter logic to load balance console writes"
Date: Thu, 13 Dec 2018 10:59:31 +0100 [thread overview]
Message-ID: <20181213095931.24qovurhtpa3jxzl@pathway.suse.cz> (raw)
In-Reply-To: <CAJmjG2-eoKTHtChWK0fdWfy872h5N1c-NgxBKZra1+ujutF+Fw@mail.gmail.com>
On Wed 2018-12-12 18:39:42, Daniel Wang wrote:
> > Additionally, for dbdda842fe96f to work as expected we really
> need fd5f7cde1b85d4c. Otherwise printk() can schedule under
> console_sem and console_owner, which will deactivate the "load
> balance" logic.
>
> It looks like fd5f7cde1b85d4c got into 4.14.82 that was released last month.
>
> On Wed, Dec 12, 2018 at 6:27 PM Sergey Senozhatsky
> <sergey.senozhatsky.work@gmail.com> wrote:
> >
> > On (12/12/18 16:40), Daniel Wang wrote:
> > > In case this was buried in previous messages, the commit I'd like to
> > > get backported to 4.14 is dbdda842fe96f: printk: Add console owner and
> > > waiter logic to load balance console writes. But another followup
> > > patch that fixes a bug in that patch is also required. That is
> > > c14376de3a1b: printk: Wake klogd when passing console_lock owner.
> >
> > Additionally, for dbdda842fe96f to work as expected we really
> > need fd5f7cde1b85d4c. Otherwise printk() can schedule under
> > console_sem and console_owner, which will deactivate the "load
> > balance" logic.
To make it clear. Please, make sure that the following commits are
backported together:
+ dbdda842fe96f8932ba ("printk: Add console owner and waiter
logic to load balance console writes")
+ c162d5b4338d72deed6 ("printk: Hide console waiter logic into
helpers")
+ fd5f7cde1b85d4c8e09 ("printk: Never set console_may_schedule
in console_trylock()")
+ c14376de3a1befa70d9 ("printk: Wake klogd when passing
console_lock owner")
I generated this list from git log using "Fixes:" tag. It seems
to mention all commits dicussed above.
Best Regards,
Petr
next prev parent reply other threads:[~2018-12-13 9:59 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 19:46 4.14 backport request for dbdda842fe96f: "printk: Add console owner and waiter logic to load balance console writes" Daniel Wang
2018-10-01 19:23 ` Steven Rostedt
2018-10-01 20:13 ` Pavel Machek
2018-10-01 20:21 ` Vlastimil Babka
2018-10-01 20:38 ` Daniel Wang
2018-10-01 20:29 ` Steven Rostedt
2018-10-01 20:37 ` Daniel Wang
2018-10-01 20:40 ` Sasha Levin
2018-10-02 8:42 ` Petr Mladek
2018-10-02 17:21 ` Daniel Wang
2018-10-03 0:15 ` Daniel Wang
2018-10-03 1:23 ` Steven Rostedt
2018-10-03 9:14 ` Petr Mladek
2018-10-03 17:16 ` Daniel Wang
2018-10-03 17:37 ` Steven Rostedt
2018-10-03 18:37 ` Daniel Wang
2018-10-03 23:37 ` Daniel Wang
2018-10-04 7:44 ` Sergey Senozhatsky
2018-10-04 8:05 ` Sergey Senozhatsky
2018-10-04 8:36 ` Petr Mladek
2018-10-04 8:55 ` Sergey Senozhatsky
2018-10-21 18:09 ` Daniel Wang
2018-10-22 9:32 ` Petr Mladek
2018-10-22 10:09 ` Sergey Senozhatsky
2018-11-01 16:05 ` Daniel Wang
2018-11-09 6:47 ` Sergey Senozhatsky
2018-12-12 1:16 ` Daniel Wang
2018-12-12 5:21 ` Sergey Senozhatsky
2018-12-12 6:08 ` Daniel Wang
2018-12-12 6:28 ` Sergey Senozhatsky
2018-12-12 6:48 ` Sasha Levin
2018-12-12 8:10 ` Sergey Senozhatsky
2018-12-12 13:36 ` Petr Mladek
2018-12-12 13:59 ` Sergey Senozhatsky
2018-12-12 17:43 ` Sasha Levin
2018-12-12 20:11 ` Daniel Wang
2018-12-12 21:43 ` Sasha Levin
2018-12-12 21:49 ` Daniel Wang
2018-12-12 21:52 ` Sasha Levin
2018-12-12 21:56 ` Daniel Wang
2018-12-13 0:40 ` Daniel Wang
2018-12-13 2:27 ` Sergey Senozhatsky
2018-12-13 2:39 ` Daniel Wang
2018-12-13 9:59 ` Petr Mladek [this message]
2018-12-13 14:29 ` Sasha Levin
2018-12-13 2:07 ` Sergey Senozhatsky
2018-12-28 0:16 ` Sergey Senozhatsky
2018-12-28 8:27 ` Greg KH
2018-12-28 22:03 ` Daniel Wang
2018-12-30 3:03 ` Sergey Senozhatsky
2018-10-04 7:49 ` Petr Mladek
2018-10-02 8:16 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213095931.24qovurhtpa3jxzl@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=Alexander.Levin@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=byungchul.park@lge.com \
--cc=dave.hansen@intel.com \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=pavel@ucw.cz \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
--cc=pfeiner@google.com \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=wonderfly@google.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).