From: Petr Mladek <pmladek@suse.com>
To: "Liu, Chuansheng" <chuansheng.liu@intel.com>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"sergey.senozhatsky@gmail.com" <sergey.senozhatsky@gmail.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"dvyukov@google.com" <dvyukov@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] kernel/hung_task.c: Force console verbose before panic
Date: Thu, 13 Dec 2018 12:54:26 +0100 [thread overview]
Message-ID: <20181213115426.lmymctoawomzlkdo@pathway.suse.cz> (raw)
In-Reply-To: <27240C0AC20F114CBF8149A2696CBE4A6015B675@SHSMSX101.ccr.corp.intel.com>
On Thu 2018-12-13 01:51:22, Liu, Chuansheng wrote:
> Based on patch commit 401c636a0eeb ("kernel/hung_task.c:
> show all hung tasks before panic"), we could get the
> call stack of hung task.
>
> However, if the console loglevel is not high, we still
> can not see the useful panic information in practice,
> and in most cases users don't set console loglevel to
> high level.
>
> This patch is to force console verbose before system
> panic, so that the real useful information can be seen
> in the console, instead of being like the following,
> which doesn't have hung task information.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Makes sense and looks good to me:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2018-12-13 11:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 1:51 [PATCH V2] kernel/hung_task.c: Force console verbose before panic Liu, Chuansheng
2018-12-13 11:54 ` Petr Mladek [this message]
2018-12-13 12:40 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213115426.lmymctoawomzlkdo@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=chuansheng.liu@intel.com \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).