From: Roman Kagan <rkagan@virtuozzo.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] x86/hyper-v: Stop caring about EOI for direct stimers
Date: Thu, 13 Dec 2018 12:17:26 +0000 [thread overview]
Message-ID: <20181213121722.GA2474@rkaganb.sw.ru> (raw)
In-Reply-To: <20181212165017.13278-2-vkuznets@redhat.com>
On Wed, Dec 12, 2018 at 05:50:16PM +0100, Vitaly Kuznetsov wrote:
> Turns out we over-engineered Direct Mode for stimers a bit: unlike
> traditional stimers where we may want to try to re-inject the message upon
> EOI, Direct Mode stimers just set the irq in APIC and kvm_apic_set_irq()
> fails only when APIC is disabled (see APIC_DM_FIXED case in
> __apic_accept_irq()). Remove the redundant part.
>
> Suggested-by: Roman Kagan <rkagan@virtuozzo.com>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
> arch/x86/kvm/hyperv.c | 36 +++---------------------------------
> 1 file changed, 3 insertions(+), 33 deletions(-)
Reviewed-by: Roman Kagan <rkagan@virtuozzo.com>
next prev parent reply other threads:[~2018-12-13 12:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 16:50 [PATCH v2 0/2] x86/kvm/hyper-v: Direct Mode stimers fixes Vitaly Kuznetsov
2018-12-12 16:50 ` [PATCH v2 1/2] x86/hyper-v: Stop caring about EOI for direct stimers Vitaly Kuznetsov
2018-12-13 12:17 ` Roman Kagan [this message]
2018-12-12 16:50 ` [PATCH v2 2/2] x86/kvm/hyper-v: disallow setting illegal vectors for direct mode stimers Vitaly Kuznetsov
2018-12-13 12:18 ` Roman Kagan
2018-12-14 10:53 ` [PATCH v2 0/2] x86/kvm/hyper-v: Direct Mode stimers fixes Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213121722.GA2474@rkaganb.sw.ru \
--to=rkagan@virtuozzo.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).