From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: tgraf@suug.ch, herbert@gondor.apana.org.au, neilb@suse.com,
tom@quantonium.net, keescook@chromium.org, paulb@mellanox.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] test_rhashtable: remove semaphore usage
Date: Fri, 14 Dec 2018 13:25:51 -0800 (PST) [thread overview]
Message-ID: <20181214.132551.1587998892072248943.davem@davemloft.net> (raw)
In-Reply-To: <20181210211957.210189-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 10 Dec 2018 22:17:20 +0100
> @@ -635,8 +636,9 @@ static int threadfunc(void *data)
> int i, step, err = 0, insert_retries = 0;
> struct thread_data *tdata = data;
>
> - up(&prestart_sem);
> - if (down_interruptible(&startup_sem))
> + if (atomic_dec_and_test(&startup_count))
> + wake_up(&startup_wait);
> + if (wait_event_interruptible(startup_wait, atomic_read(&startup_count) == -1))
> pr_err(" thread[%d]: down_interruptible failed\n", tdata->id);
Arnd, please adjust this pr_err() text to match the new code as pointed out by
Phil Sutter.
Thank you.
next prev parent reply other threads:[~2018-12-14 21:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 21:17 [PATCH] test_rhashtable: remove semaphore usage Arnd Bergmann
2018-12-11 1:29 ` David Miller
2018-12-11 5:45 ` Herbert Xu
2018-12-11 7:38 ` Phil Sutter
2018-12-14 21:25 ` David Miller [this message]
2018-12-16 19:50 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214.132551.1587998892072248943.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=herbert@gondor.apana.org.au \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.com \
--cc=netdev@vger.kernel.org \
--cc=paulb@mellanox.com \
--cc=tgraf@suug.ch \
--cc=tom@quantonium.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).