LKML Archive on
 help / color / Atom feed
From: MyungJoo Ham <>
To: Kyungmin Park <>
Cc: Chanwoo Choi <>,
	"" <>,
	"" <>,
	"" <>,
	Sibi Sankar <>
Subject: RE: [PATCH v4] PM / devfreq: Restart previous governor if new governor fails to start
Date: Fri, 14 Dec 2018 10:45:27 +0900
Message-ID: <20181214014527epcms1p6c783b4cd1602bbcbcb6e725f840db479@epcms1p6> (raw)
In-Reply-To: <CGME20181212135338epcas5p12f7a8cd1c7aab5d5c936cbc5c33eee07@epcms1p6>

> From: Saravana Kannan <>
> If the new governor fails to start, switch back to old governor so that the
> devfreq state is not left in some weird limbo.
> Signed-off-by: Sibi Sankar <>
> Signed-off-by: Saravana Kannan <>
> Reviewed-by: Chanwoo Choi <>


In overall, the idea and the implementation looks good.

However, I have a question:

What if the following line fails?

+		df->governor->event_handler(df, DEVFREQ_GOV_START,
+					    NULL);

Don't we still need something to handle for such events?


  parent reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12 13:53 Sibi Sankar
     [not found] ` <CGME20181212135338epcas5p12f7a8cd1c7aab5d5c936cbc5c33eee07@epcms1p6>
2018-12-14  1:45   ` MyungJoo Ham [this message]
2019-02-19  5:12     ` Sibi Sankar
2019-03-04  8:21       ` Sibi Sankar
     [not found]       ` <CGME20181212135338epcas5p12f7a8cd1c7aab5d5c936cbc5c33eee07@epcms1p8>
2019-03-05  7:18         ` MyungJoo Ham
2019-03-06 17:44           ` Sibi Sankar

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181214014527epcms1p6c783b4cd1602bbcbcb6e725f840db479@epcms1p6 \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on

Archives are clonable:
	git clone --mirror lkml/git/0.git
	git clone --mirror lkml/git/1.git
	git clone --mirror lkml/git/2.git
	git clone --mirror lkml/git/3.git
	git clone --mirror lkml/git/4.git
	git clone --mirror lkml/git/5.git
	git clone --mirror lkml/git/6.git
	git clone --mirror lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ \
	public-inbox-index lkml

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox