From: Torsten Duwe <duwe@lst.de>
To: Amit Daniel Kachhap <amit.kachhap@arm.com>
Cc: Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
julien.thierry@arm.com, rostedt@goodmis.org, jpoimboe@redhat.com,
mingo@redhat.com, Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
takahiro.akashi@linaro.org,
LAK <linux-arm-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org, live-patching@vger.kernel.org
Subject: Re: [PATCH v5] arm64: implement ftrace with regs
Date: Fri, 14 Dec 2018 10:47:14 +0100 [thread overview]
Message-ID: <20181214094714.GA30043@lst.de> (raw)
In-Reply-To: <CADGdYn46uQWfoDmRjk1OFj9fYXYbC669Ar=oVtnx141HcMFr8w@mail.gmail.com>
On Thu, Dec 13, 2018 at 11:01:38PM +0530, Amit Daniel Kachhap wrote:
> On Fri, Nov 30, 2018 at 9:53 PM Torsten Duwe <duwe@lst.de> wrote:
>
> Hi Torsten,
>
> I was testing your patch and it seems to work fine for function trace. However
> function graph trace seems broken. Is it work in progress ? or I am
> missing something.
What did you base your tests on, you didn't specify?
OTOH neither did I ;-) I precluded all addressees had the full picture.
Precisely, I basically start with 4.19, but 4.20-rc shouldn't make a
difference. BUT...
> > [Changes from v4]
> >
> > * include Ard's feedback and pending changes:
> > - ADR/ADRP veneers
> > - ftrace_trampolines[2]
> > - add a .req for fp, just in case
" [PATCH 1/2] arm64/insn: add support for emitting ADR/ADRP instructions "
<20181122084646.3247-2-ard.biesheuvel@linaro.org> et.al, esp:
Git-commit: bdb85cd1d20669dfae813555dddb745ad09323ba
> > - comment on the pt_regs.stackframe[2] mapping
> > * include Mark's ftrace cleanup
> > - GLOBAL()
> > - prepare_ftrace_return(pc, &lr, fp)
> >
" [PATCH 1/6] linkage: add generic GLOBAL() macro "
<20181115224203.24847-2-mark.rutland@arm.com> et.al., esp:
Git-commit: 7dc48bf96aa0fc8aa5b38cc3e5c36ac03171e680
change the API this patch set relies on. AFAIU they are on their way into
mainline so I updated v5 accordingly. If you don't have these, just use v4;
the other changes are only for compatibility and cosmetics.
HTH,
Torsten
next prev parent reply other threads:[~2018-12-14 9:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 16:20 [PATCH v5] arm64: implement ftrace with regs Torsten Duwe
2018-12-13 17:31 ` Amit Daniel Kachhap
2018-12-14 9:47 ` Torsten Duwe [this message]
2018-12-14 16:15 ` Amit Daniel Kachhap
2018-12-15 12:41 ` Torsten Duwe
2018-12-17 4:22 ` Amit Daniel Kachhap
2018-12-17 13:34 ` Torsten Duwe
2019-01-04 14:13 ` Torsten Duwe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214094714.GA30043@lst.de \
--to=duwe@lst.de \
--cc=amit.kachhap@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=jpoimboe@redhat.com \
--cc=julien.thierry@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=takahiro.akashi@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).