From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Masami Hiramatsu <masami.hiramatsu@linaro.org>
Subject: Re: ASoC: About graph node issue without 'reg' property
Date: Fri, 14 Dec 2018 11:13:59 +0900 [thread overview]
Message-ID: <20181214111358.FB47.4A936039@socionext.com> (raw)
In-Reply-To: <87tvjh7zj2.wl-kuninori.morimoto.gx@renesas.com>
Hi Morimoto-san, Mark,
On Fri, 14 Dec 2018 09:05:02 +0900 <kuninori.morimoto.gx@renesas.com> wrote:
>
> Hi Hayashi-san
>
> Sorry for my buggy patch.
> I and Tony could confirm that my posted patch can solve
> this issue. I will re-post it again as v3 patch-series.
> I'm happy if you can test it (and give it Tested-by).
>
> https://patchwork.kernel.org/patch/10727943/
Thank you for your great effort, and sorry my cross-post before your RFC patch
because I didn't catch it.
I confirmed your RFC patch solved the issue.
I'll also test your v3 patch-series on my environment.
> > [1 <text/plain; us-ascii (quoted-printable)>]
> > On Thu, Dec 13, 2018 at 04:24:28PM +0000, Mark Brown wrote:
> > > On Thu, Dec 13, 2018 at 07:39:45PM +0900, Kunihiko Hayashi wrote:
> > >
> > > > Maybe I think that we'd better add 'reg' properties to each port,
> > > > however, there might be same matter in other SoCs, so I'm not sure
> > > > whether your patch breaks the backword compatibility or
> > > > our devicetrees are wrong.
> >
> > > > I'd be glad if I could hear something about this issue from you.
> >
> > > There's an ongoing thread between Morimoto-san and Tony Lindgren around
> > > the graph card including this issue, there Morimoto-san proposed some
> > > code which would let the reg property be optional. Device trees should
> > > still be updated but that way we wouldn't actually break anything which
> > > would be good.
Yes. It's desiable to add the reg property in spite of the fixes.
I'll update our devicetrees.
Thank you,
> >
> > There's a patch now - "[PATCH][RFC] ASoC: simple-card-utils: fixup
> > asoc_simple_card_get_dai_id() ID method".
> > [2 signature.asc <application/pgp-signature (7bit)>]
> > No public key for 24D68B725D5487D0 created at 2018-12-14T03:27:38+0900 using RSA
---
Best Regards,
Kunihiko Hayashi
next prev parent reply other threads:[~2018-12-14 2:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 10:39 ASoC: About graph node issue without 'reg' property Kunihiko Hayashi
2018-12-13 16:24 ` Mark Brown
2018-12-13 18:27 ` Mark Brown
2018-12-14 0:05 ` Kuninori Morimoto
2018-12-14 2:13 ` Kunihiko Hayashi [this message]
2018-12-17 0:47 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214111358.FB47.4A936039@socionext.com \
--to=hayashi.kunihiko@socionext.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu@linaro.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).