linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] irqchip/irq-imx-gpcv2: add IRQCHIP_DECLARE for i.MX8MQ compatible
@ 2018-12-14 12:15 Lucas Stach
  2018-12-17 15:51 ` Lucas Stach
  0 siblings, 1 reply; 3+ messages in thread
From: Lucas Stach @ 2018-12-14 12:15 UTC (permalink / raw)
  To: Marc Zyngier, Andrey Smirnov
  Cc: Thomas Gleixner, Jason Cooper, linux-kernel, kernel, patchwork-lst

The GPC node on i.MX8MQ can not claim to be compatible with the i.MX7D
GPC, as the power gating part has some significant differences. Thus we
can not rely on the irqchip being probed with the old compatible.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/irqchip/irq-imx-gpcv2.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
index 17a2dad2d4c2..68b9cca24044 100644
--- a/drivers/irqchip/irq-imx-gpcv2.c
+++ b/drivers/irqchip/irq-imx-gpcv2.c
@@ -289,4 +289,5 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node,
 	return 0;
 }
 
-IRQCHIP_DECLARE(imx_gpcv2, "fsl,imx7d-gpc", imx_gpcv2_irqchip_init);
+IRQCHIP_DECLARE(imx_gpcv2_imx7d, "fsl,imx7d-gpc", imx_gpcv2_irqchip_init);
+IRQCHIP_DECLARE(imx_gpcv2_imx8mq, "fsl,imx8mq-gpc", imx_gpcv2_irqchip_init);
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] irqchip/irq-imx-gpcv2: add IRQCHIP_DECLARE for i.MX8MQ compatible
  2018-12-14 12:15 [PATCH] irqchip/irq-imx-gpcv2: add IRQCHIP_DECLARE for i.MX8MQ compatible Lucas Stach
@ 2018-12-17 15:51 ` Lucas Stach
  2018-12-18 12:59   ` Marc Zyngier
  0 siblings, 1 reply; 3+ messages in thread
From: Lucas Stach @ 2018-12-17 15:51 UTC (permalink / raw)
  To: Marc Zyngier, Andrey Smirnov
  Cc: Thomas Gleixner, patchwork-lst, Jason Cooper, kernel, linux-kernel

Hi Marc,

Am Freitag, den 14.12.2018, 13:15 +0100 schrieb Lucas Stach:
> The GPC node on i.MX8MQ can not claim to be compatible with the i.MX7D
> GPC, as the power gating part has some significant differences. Thus we
> can not rely on the irqchip being probed with the old compatible.
> 
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  drivers/irqchip/irq-imx-gpcv2.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
> index 17a2dad2d4c2..68b9cca24044 100644
> --- a/drivers/irqchip/irq-imx-gpcv2.c
> +++ b/drivers/irqchip/irq-imx-gpcv2.c
> @@ -289,4 +289,5 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node,
> >  	return 0;
>  }
>  
> -IRQCHIP_DECLARE(imx_gpcv2, "fsl,imx7d-gpc", imx_gpcv2_irqchip_init);
> +IRQCHIP_DECLARE(imx_gpcv2_imx7d, "fsl,imx7d-gpc", imx_gpcv2_irqchip_init);
> +IRQCHIP_DECLARE(imx_gpcv2_imx8mq, "fsl,imx8mq-gpc", imx_gpcv2_irqchip_init);

It would be nice if we could get this into 4.21, as this is the last
missing bit preventing me from pushing forward on the patches
describing the i.MX8MQ IRQ hierarchy properly for the next cycle.

Regards,
Lucas

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] irqchip/irq-imx-gpcv2: add IRQCHIP_DECLARE for i.MX8MQ compatible
  2018-12-17 15:51 ` Lucas Stach
@ 2018-12-18 12:59   ` Marc Zyngier
  0 siblings, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2018-12-18 12:59 UTC (permalink / raw)
  To: Lucas Stach, Andrey Smirnov
  Cc: Thomas Gleixner, patchwork-lst, Jason Cooper, kernel, linux-kernel

On 17/12/2018 15:51, Lucas Stach wrote:
> Hi Marc,
> 
> Am Freitag, den 14.12.2018, 13:15 +0100 schrieb Lucas Stach:
>> The GPC node on i.MX8MQ can not claim to be compatible with the i.MX7D
>> GPC, as the power gating part has some significant differences. Thus we
>> can not rely on the irqchip being probed with the old compatible.
>>
>>> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
>> ---
>>  drivers/irqchip/irq-imx-gpcv2.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
>> index 17a2dad2d4c2..68b9cca24044 100644
>> --- a/drivers/irqchip/irq-imx-gpcv2.c
>> +++ b/drivers/irqchip/irq-imx-gpcv2.c
>> @@ -289,4 +289,5 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node,
>>>  	return 0;
>>  }
>>  
>> -IRQCHIP_DECLARE(imx_gpcv2, "fsl,imx7d-gpc", imx_gpcv2_irqchip_init);
>> +IRQCHIP_DECLARE(imx_gpcv2_imx7d, "fsl,imx7d-gpc", imx_gpcv2_irqchip_init);
>> +IRQCHIP_DECLARE(imx_gpcv2_imx8mq, "fsl,imx8mq-gpc", imx_gpcv2_irqchip_init);
> 
> It would be nice if we could get this into 4.21, as this is the last
> missing bit preventing me from pushing forward on the patches
> describing the i.MX8MQ IRQ hierarchy properly for the next cycle.

Now applied.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-12-18 12:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-14 12:15 [PATCH] irqchip/irq-imx-gpcv2: add IRQCHIP_DECLARE for i.MX8MQ compatible Lucas Stach
2018-12-17 15:51 ` Lucas Stach
2018-12-18 12:59   ` Marc Zyngier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).