linux-next: build warning after merge of the irqchip tree

linux-next: build warning after merge of the irqchip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]

Hi all,

After merging the irqchip tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from include/linux/io.h:25,
                 from include/linux/of_address.h:7,
                 from drivers/irqchip/irq-imx-gpcv2.c:9:
drivers/irqchip/irq-imx-gpcv2.c: In function 'imx_gpcv2_irqchip_init':
arch/arm/include/asm/io.h:96:22: warning: this statement may fall through [-Wimplicit-fallthrough=]
 #define __raw_writel __raw_writel
                      ^
arch/arm/include/asm/io.h:305:29: note: in expansion of macro '__raw_writel'
 #define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c)
                             ^~~~~~~~~~~~
drivers/irqchip/irq-imx-gpcv2.c:263:4: note: in expansion of macro 'writel_relaxed'
    writel_relaxed(~0, reg + GPC_IMR1_CORE3);
    ^~~~~~~~~~~~~~
drivers/irqchip/irq-imx-gpcv2.c:264:3: note: here
   case 2:       /* FALLTHROUGH */
   ^~~~

Introduced by commit

  ed01edc0ab6f ("irqchip/irq-imx-gpcv2: Add support for i.MX8MQ")

This is caused by my use of -Wimplicit-fallthrough for Kees Cook.

Replacing the "/* FALLTHROUGH */"  with "/* fall through */" but on the
line above will suppress the warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the irqchip tree

[Marc Zyngier]

On Fri, 14 Dec 2018 03:44:06 +0000,
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> [1  <text/plain; US-ASCII (quoted-printable)>]
> Hi all,
> 
> After merging the irqchip tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> In file included from include/linux/io.h:25,
>                  from include/linux/of_address.h:7,
>                  from drivers/irqchip/irq-imx-gpcv2.c:9:
> drivers/irqchip/irq-imx-gpcv2.c: In function 'imx_gpcv2_irqchip_init':
> arch/arm/include/asm/io.h:96:22: warning: this statement may fall through [-Wimplicit-fallthrough=]
>  #define __raw_writel __raw_writel
>                       ^
> arch/arm/include/asm/io.h:305:29: note: in expansion of macro '__raw_writel'
>  #define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c)
>                              ^~~~~~~~~~~~
> drivers/irqchip/irq-imx-gpcv2.c:263:4: note: in expansion of macro 'writel_relaxed'
>     writel_relaxed(~0, reg + GPC_IMR1_CORE3);
>     ^~~~~~~~~~~~~~
> drivers/irqchip/irq-imx-gpcv2.c:264:3: note: here
>    case 2:       /* FALLTHROUGH */
>    ^~~~
> 
> Introduced by commit
> 
>   ed01edc0ab6f ("irqchip/irq-imx-gpcv2: Add support for i.MX8MQ")
> 
> This is caused by my use of -Wimplicit-fallthrough for Kees Cook.
> 
> Replacing the "/* FALLTHROUGH */"  with "/* fall through */" but on the
> line above will suppress the warning.

I've now pushed out a patch that does exactly that. Thanks for
spotting this.

	M.

-- 
Jazz is not dead, it just smell funny.

Re: linux-next: build warning after merge of the irqchip tree

[Marc Zyngier]

Hi Stephen,

On 2021-09-03 07:47, Stephen Rothwell wrote:
> Hi all,
> 
> On Fri, 13 Aug 2021 19:44:57 +1000 Stephen Rothwell
> <sfr@canb.auug.org.au> wrote:
>> 
>> After merging the irqchip tree, today's linux-next build (htmldocs)
>> produced this warning:
>> 
>> Documentation/core-api/irq/irq-domain.rst:178: WARNING: Inline 
>> emphasis start-string without end-string.
>> 
>> Introduced by commit
>> 
>>   991007ba6cca ("Documentation: Update irq_domain.rst with new lookup 
>> APIs")
> 
> I am still getting this warning.

Thanks for the reminder. Fix now queued.

         M.
-- 
Jazz is not dead. It just smells funny...

Re: linux-next: build warning after merge of the irqchip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 488 bytes --]

Hi all,

On Fri, 13 Aug 2021 19:44:57 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the irqchip tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/core-api/irq/irq-domain.rst:178: WARNING: Inline emphasis start-string without end-string.
> 
> Introduced by commit
> 
>   991007ba6cca ("Documentation: Update irq_domain.rst with new lookup APIs")

I am still getting this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the irqchip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

Hi all,

After merging the irqchip tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/core-api/irq/irq-domain.rst:178: WARNING: Inline emphasis start-string without end-string.

Introduced by commit

  991007ba6cca ("Documentation: Update irq_domain.rst with new lookup APIs")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the irqchip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1720 bytes --]

Hi Marc,

On Thu, 08 Jul 2021 17:32:01 +0100 Marc Zyngier <maz@kernel.org> wrote:
>
> On Thu, 08 Jul 2021 13:50:37 +0100,
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > 
> > On Thu, 08 Jul 2021 09:10:10 +0100 Marc Zyngier <maz@kernel.org> wrote:  
> > >
> > > Hmmm... I've had a fix for this sitting in irqchip-fixes for some
> > > time. But I now realise that this branch is not included in -next
> > > while tip tracks it.
> > > 
> > > Any chance you could add [1] to -next in the future?
> > > 
> > > 
> > > [1] git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git irq/irqchip-fixes  
> > 
> > So I assume this a branch of bug fixes for the current release, right?  
> 
> Yes, that's exactly what this is.
> 
> > In which case I will add it tomorrow.  

Added from today.

Thanks for adding your subsystem tree as a participant of linux-next.  As
you may know, this is not a judgement of your code.  The purpose of
linux-next is for integration testing and to lower the impact of
conflicts between subsystems in the next merge window. 

You will need to ensure that the patches/commits in your tree/series have
been:
     * submitted under GPL v2 (or later) and include the Contributor's
        Signed-off-by,
     * posted to the relevant mailing list,
     * reviewed by you (or another maintainer of your subsystem tree),
     * successfully unit tested, and 
     * destined for the current or next Linux merge window.

Basically, this should be just what you would send to Linus (or ask him
to fetch).  It is allowed to be rebased if you deem it necessary.

-- 
Cheers,
Stephen Rothwell 
sfr@canb.auug.org.au

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the irqchip tree

[Marc Zyngier]

On Thu, 08 Jul 2021 13:50:37 +0100,
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> [1  <text/plain; US-ASCII (quoted-printable)>]
> Hi Marc,
> 
> On Thu, 08 Jul 2021 09:10:10 +0100 Marc Zyngier <maz@kernel.org> wrote:
> >
> > Hmmm... I've had a fix for this sitting in irqchip-fixes for some
> > time. But I now realise that this branch is not included in -next
> > while tip tracks it.
> > 
> > Any chance you could add [1] to -next in the future?
> > 
> > Thanks,
> > 
> > 	M.
> > 
> > [1] git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git irq/irqchip-fixes
> 
> So I assume this a branch of bug fixes for the current release, right?

Yes, that's exactly what this is.

> In which case I will add it tomorrow.

Thanks a lot!

	M.

-- 
Without deviation from the norm, progress is not possible.

Re: linux-next: build warning after merge of the irqchip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

Hi Marc,

On Thu, 08 Jul 2021 09:10:10 +0100 Marc Zyngier <maz@kernel.org> wrote:
>
> Hmmm... I've had a fix for this sitting in irqchip-fixes for some
> time. But I now realise that this branch is not included in -next
> while tip tracks it.
> 
> Any chance you could add [1] to -next in the future?
> 
> Thanks,
> 
> 	M.
> 
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git irq/irqchip-fixes

So I assume this a branch of bug fixes for the current release, right?
In which case I will add it tomorrow.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the irqchip tree

[Marc Zyngier]

Hi Stephen,

On Thu, 08 Jul 2021 03:18:55 +0100,
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> Hi all,
> 
> On Tue, 15 Jun 2021 21:01:43 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the irqchip tree, today's linux-next build (htmldocs)
> > produced this warning:
> > 
> > kernel/irq/irqdesc.c:692: warning: Excess function parameter 'lookup' description in 'handle_domain_irq'
> > 
> > Introduced by commit
> > 
> >   e1c054918c6c ("genirq: Move non-irqdomain handle_domain_irq() handling into ARM's handle_IRQ()")
> 
> I am still getting this warning.

Hmmm... I've had a fix for this sitting in irqchip-fixes for some
time. But I now realise that this branch is not included in -next
while tip tracks it.

Any chance you could add [1] to -next in the future?

Thanks,

	M.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git irq/irqchip-fixes

-- 
Without deviation from the norm, progress is not possible.

Re: linux-next: build warning after merge of the irqchip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

Hi all,

On Tue, 15 Jun 2021 21:01:43 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the irqchip tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> kernel/irq/irqdesc.c:692: warning: Excess function parameter 'lookup' description in 'handle_domain_irq'
> 
> Introduced by commit
> 
>   e1c054918c6c ("genirq: Move non-irqdomain handle_domain_irq() handling into ARM's handle_IRQ()")

I am still getting this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the irqchip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

Hi all,

After merging the irqchip tree, today's linux-next build (htmldocs)
produced this warning:

kernel/irq/irqdesc.c:692: warning: Excess function parameter 'lookup' description in 'handle_domain_irq'

Introduced by commit

  e1c054918c6c ("genirq: Move non-irqdomain handle_domain_irq() handling into ARM's handle_IRQ()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the irqchip tree

[Marc Zyngier]

Hi Stephen,

On Tue, 08 Jun 2021 00:21:48 +0100,
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> Hi all,
> 
> After merging the irqchip tree, yesterday's linux-next build (htmldocs)
> produced this warning:
> 
> include/linux/interrupt.h:131: warning: Function parameter or member 'desc' not described in 'irqaction'
> 
> Introduced by commit
> 
>   bb33916b527f ("genirq: Replace irqaction:irq with a pointer to the irqdesc")

Huhuh... This patch should have never made it in -next. I must have
messed up once more.

/me goes and rebuild the branch now, which will also get rid of the
fixups lacking SoBs.

Thanks for the heads up,

	M.

-- 
Without deviation from the norm, progress is not possible.

linux-next: build warning after merge of the irqchip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Hi all,

After merging the irqchip tree, yesterday's linux-next build (htmldocs)
produced this warning:

include/linux/interrupt.h:131: warning: Function parameter or member 'desc' not described in 'irqaction'

Introduced by commit

  bb33916b527f ("genirq: Replace irqaction:irq with a pointer to the irqdesc")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the irqchip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 749 bytes --]

Hi Jason,

After merging the irqchip tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

include/linux/irqchip/arm-gic.h:109:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from arch/arm/mach-ux500/pm.c:13:0:
include/linux/irqchip/arm-gic.h:109:53: warning: 'struct irq_domain' declared inside parameter list
 int gicv2m_of_init(struct device_node *node, struct irq_domain *parent);
                                                     ^

and many more similar.

Introduced by commit 853a33ce6932 ("irqchip: gic-v2m: Add support for
ARM GICv2m MSI(-X) doorbell").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]