linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Florian Westphal <fw@strlen.de>
Cc: Wolfgang Walter <linux@stwm.de>,
	David Miller <davem@davemloft.net>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	steffen.klassert@secunet.com, christophe.gouault@6wind.com
Subject: Re: INFO: rcu detected stall in xfrm_hash_rebuild
Date: Fri, 14 Dec 2018 22:56:32 +0800	[thread overview]
Message-ID: <20181214145632.urh3n4vua66wvmkx@gondor.apana.org.au> (raw)
In-Reply-To: <20181214143532.43zgy2hwkdskwfn2@breakpoint.cc>

On Fri, Dec 14, 2018 at 03:35:32PM +0100, Florian Westphal wrote:
>
> Ok.  An alternative would be to remove the support for
> policy hash table thresholds (which decide what kinds of policies
> go to exact table and which ones go into inexact ones), i.e.
> partially revert 880a6fab8f6ba5b5abe59ea6
> ("xfrm: configure policy hash table thresholds by netlink").
> 
> This would remove the need for the rehashing support that
> re-sorts the policies into either exact/inexact lists) when the
> those tunables are changed.
> 
> We could also easily convert the exact table to an rhashtable
> then if we wanted to.

We could also do both.  In fact that was the reason why I started
working on rhashtable in the first place.  The idea is to extend
the run-time rehashing to include both parts of the database.

So you would look up the old table/list combo and then move onto
the new one.

Of course I never had time to finish this and I think the entity
asking for this has moved onto something else.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2018-12-14 14:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-10  7:50 INFO: rcu detected stall in xfrm_hash_rebuild syzbot
2018-12-10 12:47 ` Florian Westphal
2018-12-10 17:58   ` David Miller
2018-12-14 13:11     ` Wolfgang Walter
2018-12-14 14:35       ` Florian Westphal
2018-12-14 14:56         ` Herbert Xu [this message]
2018-12-14 16:04         ` Christophe Gouault
2018-12-14 16:23           ` Florian Westphal
2018-12-14 16:28             ` Christophe Gouault
2018-12-14 19:07             ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181214145632.urh3n4vua66wvmkx@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=christophe.gouault@6wind.com \
    --cc=davem@davemloft.net \
    --cc=fw@strlen.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@stwm.de \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).